Fix travis build, enable tests

Author: cemremengu

.travis.yml

@@ -1,14 +1,23 @@
 language: node_js
+sudo: required
+dist: xenial
 
 node_js:
-  - "9"
+  - "10"
   - "8"
   - "6"
-
+  
 script:
   - npm run lint-ci
   - npm run test-ci
 
+env:
+  - ORACLE_HOME=/u01/app/oracle/product/11.2.0/xe ORACLE_SID=XE OCI_LIB_DIR=/u01/app/oracle/product/11.2.0/xe/lib LD_LIBRARY_PATH=/u01/app/oracle/product/11.2.0/xe/lib
+
+before_install:
+  - wget https://raw.githubusercontent.com/Vincit/travis-oracledb-xe/master/accept_the_license_agreement_for_oracledb_xe_11g_and_install.sh
+  - bash ./accept_the_license_agreement_for_oracledb_xe_11g_and_install.sh
+
 notifications:
   email:
     on_success: never

test/client.test.js

@@ -7,8 +7,8 @@ const plugin = require('../plugin')
 test('accepts singleton client', (t) => {
   t.plan(4)
   oracledb.createPool({
-    user: 'SYSTEM',
-    password: 'oracle',
+    user: 'travis',
+    password: 'travis',
     connectString: 'localhost/XE'
   }, (err, pool) => {
     if (err) t.threw(err)
@@ -34,8 +34,8 @@ test('accepts singleton client', (t) => {
 test('retrieves a cached pool', (t) => {
   t.plan(4)
   oracledb.createPool({
-    user: 'SYSTEM',
-    password: 'oracle',
+    user: 'travis',
+    password: 'travis',
     connectString: 'localhost/XE',
     poolAlias: 'foo'
   }, (err, pool) => {

test/pool.test.js

@@ -1,44 +1,41 @@
 'use strict'
 
-// Unless someone can provide an Oracle Docker image to test against, we'll
-// just have to assume this works.
+const test = require('tap').test
+const plugin = require('../plugin')
 
-// const test = require('tap').test
-// const plugin = require('../plugin')
+test('creates usable pool from config', (t) => {
+  t.plan(6)
 
-// test('creates usable pool from config', (t) => {
-//   t.plan(6)
+  const fastify = {
+    decorate (name, obj) {
+      t.is(name, 'oracle')
+      this[name] = obj
+    },
 
-//   const fastify = {
-//     decorate (name, obj) {
-//       t.is(name, 'oracle')
-//       this[name] = obj
-//     },
+    addHook (name, fn) {
+      t.is(name, 'onClose')
+      t.match(fn, /fastify\.oracle\.close/)
+    }
+  }
 
-//     addHook (name, fn) {
-//       t.is(name, 'onClose')
-//       t.match(fn, /fastify\.oracle\.close/)
-//     }
-//   }
-
-//   const opts = {
-//     user: 'SYSTEM',
-//     password: 'oracle',
-//     connectString: 'localhost/xe'
-//   }
-//   plugin(fastify, {pool: opts}, (err) => {
-//     if (err) t.threw(err)
-//     t.ok(fastify.oracle)
-//     fastify.oracle.getConnection()
-//       .then((conn) => {
-//         conn.execute('select 1 as foo from dual')
-//           .then((rows) => {
-//             t.is(rows.length, 1)
-//             t.is(rows[0].foo, 1)
-//           })
-//           .then(() => conn.close())
-//           .catch(t.threw)
-//       })
-//       .catch(t.threw)
-//   })
-// })
+  const opts = {
+    user: 'travis',
+    password: 'travis',
+    connectString: 'localhost/xe'
+  }
+  plugin(fastify, {pool: opts}, (err) => {
+    if (err) t.threw(err)
+    t.ok(fastify.oracle)
+    fastify.oracle.getConnection()
+      .then((conn) => {
+        conn.execute('select 1 from dual')
+          .then((result) => {
+            t.is(result.rows.length, 1)
+            t.is(result.rows[0][0], 1)
+          })
+          .then(() => conn.close())
+          .catch(t.threw)
+      })
+      .catch(t.threw)
+  })
+})