Update logic

Author: cemremengu

plugin.js

@@ -7,25 +7,20 @@ function executionScope (pool, fn, cb) {
   pool.getConnection(function (err, conn) {
     if (err) return cb(err)
 
-    const release = (conn) => {
-      conn.close(function (_) {
-      })
-    }
-
     const commit = (err, res) => {
       if (err) {
-        release(conn)
-        return cb(err)
+        return conn.close(function () {
+          return cb(err)
+        })
       }
 
       conn.commit(function (err) {
-        release(conn)
-
-        if (err) {
-          return cb(err)
-        }
-
-        return cb(null, res)
+        conn.close(function () {
+          if (err) {
+            return cb(err)
+          }
+          return cb(null, res)
+        })
       })
     }
 

test/plugin.test.js

@@ -133,7 +133,6 @@ test('execution scope with promise', (t) => {
       t.strictDeepEqual(res.rows, [ { DUMMY: 'X' } ])
 
       fastify.close(err => {
-        console.log(fastify.oracle.pool)
         t.error(err)
         t.is(fastify.oracle.pool.status, fastify.oracle.db.POOL_STATUS_CLOSED)
       })