Merge branch 'v0.34.x-celestia' into rp/messages-is-sorted

Author: rootulp

.golangci.yml

@@ -60,11 +60,7 @@ linters-settings:
   #   check-shadowing: true
   revive:
     min-confidence: 0
-  maligned:
-    suggest-new: true
   misspell:
     locale: US
     ignore-words:
       - behaviour
-
-

.mergify.yml

@@ -56,6 +56,11 @@ func (r ResponseProcessProposal) IsErr() bool {
 	return r.Result != ResponseProcessProposal_ACCEPT
 }
 
+// IsRejected returns true if this ResponseProcessProposal was rejected
+func (r ResponseProcessProposal) IsRejected() bool {
+	return r.Result == ResponseProcessProposal_REJECT
+}
+
 //---------------------------------------------------------------------------
 // override JSON marshaling so we emit defaults (ie. disable omitempty)
 

abci/types/result.go

@@ -20,7 +20,7 @@ The proposed design is as follows.
 
 The proposal and vote types have a BlockID, this will be replaced with a header hash. The proposal will contain add fields.
 
-The current proposal will be updated to include required fields. The entirety of the message will be reworked at a later date. To see the extent of the needed changes you can visit the [spec repo](https://github.com/celestiaorg/celestia-specs/blob/master/specs/proto/consensus.proto#L19)
+The current proposal will be updated to include required fields. The entirety of the message will be reworked at a later date. To see the extent of the needed changes you can visit the [spec repo](https://github.com/celestiaorg/celestia-specs/blob/master/src/specs/proto/consensus.proto#L19)
 
 ```proto
 message Proposal {
@@ -67,7 +67,7 @@ message Vote {
 }
 ```
 
-See [specs](https://github.com/celestiaorg/celestia-specs/blob/master/specs/data_structures.md#vote) for more details on the vote.
+See [specs](https://github.com/celestiaorg/celestia-specs/blob/master/src/specs/data_structures.md#vote) for more details on the vote.
 
 ### Disk Storage
 

docs/celestia-architecture/adr-001-block-propagation.md

@@ -17,7 +17,7 @@ A high-level, implementation-independent formalization of above mentioned sampli
 [_Fraud and Data Availability Proofs: Detecting Invalid Blocks in Light Clients_](https://fc21.ifca.ai/papers/83.pdf).
 
 For the time being, besides the academic paper, no other formalization or specification of the protocol exists.
-Currently, the Celestia specification itself only describes the [erasure coding](https://github.com/celestiaorg/celestia-specs/blob/master/specs/data_structures.md#erasure-coding)
+Currently, the Celestia specification itself only describes the [erasure coding](https://github.com/celestiaorg/celestia-specs/blob/master/src/specs/data_structures.md#erasure-coding)
 and how to construct the extended data square from the block data.
 
 This ADR:
@@ -263,7 +263,7 @@ Proposed
 
 [celestia-specs#126]: https://github.com/celestiaorg/celestia-specs/issues/126
 [celestia-specs#127]: https://github.com/celestiaorg/celestia-specs/pulls/127
-[Header]: https://github.com/celestiaorg/celestia-specs/blob/master/specs/data_structures.md#header
+[Header]: https://github.com/celestiaorg/celestia-specs/blob/master/src/specs/data_structures.md#header
 
 [go-ipfs documentation]: https://github.com/ipfs/go-ipfs/tree/master/docs/examples/go-ipfs-as-a-library#use-go-ipfs-as-a-library-to-spawn-a-node-and-add-a-file
 [ipld experiments]: https://github.com/celestia/ipld-plugin-experiments

docs/celestia-architecture/adr-002-ipld-da-sampling.md

@@ -7,7 +7,7 @@
 ## Context
 
 This ADR builds on top of [ADR 002](adr-002-ipld-da-sampling.md) and will use the implemented APIs described there.
-The reader should familiarize themselves at least with the high-level concepts the as well as in the [specs](https://github.com/celestiaorg/celestia-specs/blob/master/specs/data_structures.md#2d-reed-solomon-encoding-scheme).
+The reader should familiarize themselves at least with the high-level concepts the as well as in the [specs](https://github.com/celestiaorg/celestia-specs/blob/master/src/specs/data_structures.md#2d-reed-solomon-encoding-scheme).
 
 The academic [paper](https://arxiv.org/abs/1905.09274) describes the motivation and context for this API.
 The main motivation can be quoted from section 3.3 of that paper:
@@ -29,7 +29,7 @@ An implementation can be found in [this repository](https://github.com/celestiao
 This ADR basically describes version of the [`GetWithProof`](https://github.com/celestiaorg/nmt/blob/ddcc72040149c115f83b2199eafabf3127ae12ac/nmt.go#L193-L196) of the NMT that leverages the fact that IPFS uses content addressing and that we have implemented an [IPLD plugin](https://github.com/celestiaorg/celestia-core/tree/37502aac69d755c189df37642b87327772f4ac2a/p2p/ipld) for an NMT.
 
 **Note**: The APIs defined here will be particularly relevant for Optimistic Rollup (full) nodes that want to download their Rollup's data (see [celestiaorg/optimint#48](https://github.com/celestiaorg/optimint/issues/48)).
-Another potential use-case of this API could be for so-called [light validator nodes](https://github.com/celestiaorg/celestia-specs/blob/master/specs/node_types.md#node-type-definitions) that want to download and replay the state-relevant portion of the block data, i.e. transactions with [reserved namespace IDs](https://github.com/celestiaorg/celestia-specs/blob/master/specs/consensus.md#reserved-namespace-ids).
+Another potential use-case of this API could be for so-called [light validator nodes](https://github.com/celestiaorg/celestia-specs/blob/master/src/specs/node_types.md#node-type-definitions) that want to download and replay the state-relevant portion of the block data, i.e. transactions with [reserved namespace IDs](https://github.com/celestiaorg/celestia-specs/blob/master/src/specs/consensus.md#reserved-namespace-ids).
 
 ## Alternative Approaches
 

docs/celestia-architecture/adr-003-application-data-retrieval.md

@@ -10,7 +10,7 @@ require (
 	github.com/btcsuite/btcd v0.21.0-beta
 	github.com/btcsuite/btcutil v1.0.2
 	github.com/celestiaorg/nmt v0.10.0
-	github.com/celestiaorg/rsmt2d v0.5.0
+	github.com/celestiaorg/rsmt2d v0.6.0
 	github.com/fortytw2/leaktest v1.3.0
 	github.com/go-kit/kit v0.12.0
 	github.com/go-kit/log v0.2.1