Events raised in wrong browser when opening popup

[aimcosoftware]

I have a ChromiumWebBrowser with handlers, including DisplayHandler attached.

calling window.open() creates a native window as expected, but handler events for the popup are sent to the opener. If the opener has a LifespanHandler, closing the native popup, raises DoClose() on it.

It doesn't raise ChromiumWebBrowser events, e.g. Browser.FrameLoadStart(), is not raised, only attached handler events.

Opening DevTools on the popup, opens the URL of the popup, not DevTools.

This also happens if you supply newBrowser in OnBeforePopup.

Parent browser initialization

Class Wrapper : Inherits Control
  Implements IDisplayHandler
  Private Browser As ChromiumWebBrowser()

  Sub Initialize(Url)
    Browser = New ChromiumWebBrowser(Url)
    Browser.LifeSpanHandler = Locals.LifeSpanHandler
    Browser.DisplayHandler = Me
    Browser.BrowserSettings = Settings()
    Browser.Dock = DockStyle.Fill
    Controls.Add(Browser)
  End Sub
...

End Class

LifespanHandler

Class LifeSpanHandler : Implements ILifeSpanHandler
  Function OnBeforePopup(WebBrowser As IWebBrowser, browser As IBrowser, frame As IFrame, targetUrl As String, targetFrameName As String, targetDisposition As WindowOpenDisposition, userGesture As Boolean, popupFeatures As IPopupFeatures, windowInfo As IWindowInfo, browserSettings As IBrowserSettings, ByRef noJavascriptAccess As Boolean, ByRef newBrowser As IWebBrowser) As Boolean Implements ILifeSpanHandler.OnBeforePopup
    Return False
  End Function
...
End Class

[amaitland]

If the opener has a LifespanHandler, closing the native popup, raises DoClose() on it.

If I understand you correctly then this sounds like the CEF default behaviour to me. All Popups use the Handlers of their parent browser. You can use IBrowser.IsPopup to determine if the handler method was called for a popup or the main browser.

Using DoClose as an example a very simple implementation might look like the following:

protected override bool DoClose(IWebBrowser chromiumWebBrowser, IBrowser browser)
{
	if (browser.IsPopup)
	{
		// default popups e.g. DevTools need to return false
		// so WM_CLOSE is sent to close the window.
		return false;
	}

	// Return true to cancel the close message being sent
	return true;
}

Opening DevTools on the popup, opens the URL of the popup, not DevTools.

That should hopefully be fixed by #4443

[aimcosoftware]

Apart from the issue of ShowDevTools, showing the content of the calling page, everything else works as expected.

[aimcosoftware]

May have spoken too soon, I have changed my LifeSpanHandler to inherit from the Winforms version, and it may now be working.

[amaitland]

May have spoken too soon, I have changed my LifeSpanHandler to inherit from the Winforms version, and it may now be working.

Sounds promising 👍 If you do experience any more issues if you could provide an example that reproduces the problem then I'll have a look.

[aimcosoftware]

If you do experience any more issues

None so far, have tested this scenario:

tab0.ShowDevTools() - (previously OK) - OK
tab0>devTools>window.open("url", "tab1") - (previously OK) - OK
tab1.ShowDevTools() - (previously opened "url") - OK

tab1>devTools>window.open("url", "popup1", "popup") - OK
popup1.ShowDevTools() - OK
popup1>devTools>window.open("url", "tab1") - OK
popup1>devTools>opener.close() - OK
popup1>devTools>close() - OK

[aimcosoftware]

Forgot to mention that when setting WindowInfo.SetAsChild() and returning newBrowser, CEF handles targeFrameName, so OnbeforePopup() is not raised when the target already exists.