Skip to content

Commit 87118a1

Browse files
committed
Call sympy.zeros acording to the docs
1 parent 86b8ab1 commit 87118a1

File tree

8 files changed

+36
-36
lines changed

8 files changed

+36
-36
lines changed

sympybotics/dynamics/extra_dyn.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def frictionforce(rbtdef, ifunc=None):
1313
if not ifunc:
1414
ifunc = identity
1515

16-
fric = zeros((rbtdef.dof, 1))
16+
fric = zeros(rbtdef.dof, 1)
1717

1818
if rbtdef.frictionmodel is None or len(rbtdef.frictionmodel) == 0:
1919
pass
@@ -45,7 +45,7 @@ def driveinertiaterm(rbtdef, ifunc=None):
4545
if not ifunc:
4646
ifunc = identity
4747

48-
driveinertia = zeros((rbtdef.dof, 1))
48+
driveinertia = zeros(rbtdef.dof, 1)
4949

5050
if rbtdef.driveinertiamodel is None:
5151
pass

sympybotics/dynamics/regressor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def regressor(rbtdef, geom, ifunc=None):
1616

1717
dynparms = rbtdef.dynparms()
1818

19-
Y = zeros((rbtdef.dof, len(dynparms)))
19+
Y = zeros(rbtdef.dof, len(dynparms))
2020

2121
for p, parm in enumerate(dynparms):
2222

sympybotics/dynamics/rne.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ def gravityterm(rbtdef, geom, ifunc=None):
3737
if not ifunc:
3838
ifunc = identity
3939
rbtdeftmp = deepcopy(rbtdef)
40-
rbtdeftmp.dq = zeros((rbtdeftmp.dof, 1))
41-
rbtdeftmp.ddq = zeros((rbtdeftmp.dof, 1))
40+
rbtdeftmp.dq = zeros(rbtdeftmp.dof, 1)
41+
rbtdeftmp.ddq = zeros(rbtdeftmp.dof, 1)
4242
rbtdeftmp.frictionmodel = None
4343
geomtmp = Geometry(rbtdeftmp)
4444
return rne(rbtdeftmp, geomtmp, ifunc)
@@ -49,8 +49,8 @@ def coriolisterm(rbtdef, geom, ifunc=None):
4949
if not ifunc:
5050
ifunc = identity
5151
rbtdeftmp = deepcopy(rbtdef)
52-
rbtdeftmp.gravityacc = zeros((3, 1))
53-
rbtdeftmp.ddq = zeros((rbtdeftmp.dof, 1))
52+
rbtdeftmp.gravityacc = zeros(3, 1)
53+
rbtdeftmp.ddq = zeros(rbtdeftmp.dof, 1)
5454
rbtdeftmp.frictionmodel = None
5555
geomtmp = Geometry(rbtdeftmp)
5656
return rne(rbtdeftmp, geomtmp, ifunc)
@@ -62,11 +62,11 @@ def coriolismatrix(rbtdef, geom, ifunc=None):
6262
if not ifunc:
6363
ifunc = identity
6464

65-
C = zeros((rbtdef.dof, rbtdef.dof))
65+
C = zeros(rbtdef.dof, rbtdef.dof)
6666

6767
rbtdeftmp = deepcopy(rbtdef)
68-
rbtdeftmp.gravityacc = zeros((3, 1))
69-
rbtdeftmp.ddq = zeros((rbtdeftmp.dof, 1))
68+
rbtdeftmp.gravityacc = zeros(3, 1)
69+
rbtdeftmp.ddq = zeros(rbtdeftmp.dof, 1)
7070
rbtdeftmp.frictionmodel = None
7171

7272
# # Coriolis vector c element k is given by
@@ -75,10 +75,10 @@ def coriolismatrix(rbtdef, geom, ifunc=None):
7575

7676
# # Find upper triangular A[k]'s
7777

78-
A = [zeros((rbtdef.dof, rbtdef.dof)) for k in range(rbtdef.dof)]
78+
A = [zeros(rbtdef.dof, rbtdef.dof) for k in range(rbtdef.dof)]
7979

8080
for i in range(rbtdef.dof):
81-
rbtdeftmp.dq = zeros((rbtdeftmp.dof, 1))
81+
rbtdeftmp.dq = zeros(rbtdeftmp.dof, 1)
8282
rbtdeftmp.dq[i] = 1
8383
geomtmp = Geometry(rbtdeftmp)
8484
fw_results = rne_forward(rbtdeftmp, geomtmp, ifunc)
@@ -88,7 +88,7 @@ def coriolismatrix(rbtdef, geom, ifunc=None):
8888

8989
for i in range(rbtdef.dof):
9090
for j in range(i+1, rbtdef.dof):
91-
rbtdeftmp.dq = zeros((rbtdeftmp.dof, 1))
91+
rbtdeftmp.dq = zeros(rbtdeftmp.dof, 1)
9292
rbtdeftmp.dq[i] = rbtdeftmp.dq[j] = 1
9393
geomtmp = Geometry(rbtdeftmp)
9494
fw_results = rne_forward(rbtdeftmp, geomtmp, ifunc)
@@ -122,15 +122,15 @@ def inertiamatrix(rbtdef, geom, ifunc=None):
122122
if not ifunc:
123123
ifunc = identity
124124

125-
M = zeros((rbtdef.dof, rbtdef.dof))
125+
M = zeros(rbtdef.dof, rbtdef.dof)
126126

127127
rbtdeftmp = deepcopy(rbtdef)
128-
rbtdeftmp.gravityacc = zeros((3, 1))
128+
rbtdeftmp.gravityacc = zeros(3, 1)
129129
rbtdeftmp.frictionmodel = None
130-
rbtdeftmp.dq = zeros((rbtdeftmp.dof, 1))
130+
rbtdeftmp.dq = zeros(rbtdeftmp.dof, 1)
131131

132132
for i in range(M.rows):
133-
rbtdeftmp.ddq = zeros((rbtdeftmp.dof, 1))
133+
rbtdeftmp.ddq = zeros(rbtdeftmp.dof, 1)
134134
rbtdeftmp.ddq[i] = 1
135135
geomtmp = Geometry(rbtdeftmp)
136136

sympybotics/dynamics/rne_khalil.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ def rne_khalil_forward(rbtdef, geom, ifunc=None):
1515
dV = list(range(0, rbtdef.dof + 1))
1616
U = list(range(0, rbtdef.dof + 1))
1717

18-
w[-1] = zeros((3, 1))
19-
dw[-1] = zeros((3, 1))
18+
w[-1] = zeros(3, 1)
19+
dw[-1] = zeros(3, 1)
2020
dV[-1] = -rbtdef.gravityacc
21-
U[-1] = zeros((3, 3))
21+
U[-1] = zeros(3, 3)
2222

2323
z = Matrix([0, 0, 1])
2424

@@ -58,19 +58,19 @@ def rne_khalil_backward(rbtdef, geom, fw_results, ifunc=None):
5858
# extend Rdh so that Rdh[dof] return identity
5959
Rdh = geom.Rdh + [eye(3)]
6060
# extend pdh so that pRdh[dof] return zero
61-
pdh = geom.pdh + [zeros((3, 1))]
61+
pdh = geom.pdh + [zeros(3, 1)]
6262

6363
F = list(range(rbtdef.dof))
6464
M = list(range(rbtdef.dof))
6565
f = list(range(rbtdef.dof + 1))
6666
m = list(range(rbtdef.dof + 1))
6767

68-
f[rbtdef.dof] = zeros((3, 1))
69-
m[rbtdef.dof] = zeros((3, 1))
68+
f[rbtdef.dof] = zeros(3, 1)
69+
m[rbtdef.dof] = zeros(3, 1)
7070

7171
z = Matrix([0, 0, 1])
7272

73-
tau = zeros((rbtdef.dof, 1))
73+
tau = zeros(rbtdef.dof, 1)
7474

7575
fric = frictionforce(rbtdef)
7676
Idrive = driveinertiaterm(rbtdef)

sympybotics/dynamics/rne_park.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ def rne_park_forward(rbtdef, geom, ifunc=None):
4141
V = list(range(0, rbtdef.dof + 1))
4242
dV = list(range(0, rbtdef.dof + 1))
4343

44-
V[-1] = zeros((6, 1))
45-
dV[-1] = - zeros((3, 1)).col_join(rbtdef.gravityacc)
44+
V[-1] = zeros(6, 1)
45+
dV[-1] = - zeros(3, 1).col_join(rbtdef.gravityacc)
4646

4747
# Forward
4848
for i in range(rbtdef.dof):
@@ -72,9 +72,9 @@ def rne_park_backward(rbtdef, geom, fw_results, ifunc=None):
7272
Tdh_inv = geom.Tdh_inv + [eye(4)]
7373

7474
F = list(range(rbtdef.dof + 1))
75-
F[rbtdef.dof] = zeros((6, 1))
75+
F[rbtdef.dof] = zeros(6, 1)
7676

77-
tau = zeros((rbtdef.dof, 1))
77+
tau = zeros(rbtdef.dof, 1)
7878

7979
fric = frictionforce(rbtdef)
8080
Idrive = driveinertiaterm(rbtdef)

sympybotics/geometry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def __init__(self, robotdef, ifunc=None):
2020
def inverse_T(T):
2121
return T[0:3, 0:3].transpose().row_join(
2222
- T[0:3, 0:3].transpose() * T[0:3, 3]).col_join(
23-
sympy.zeros((1, 3)).row_join(sympy.eye(1)))
23+
sympy.zeros(1, 3).row_join(sympy.eye(1)))
2424

2525
(alpha, a, d, theta) = sympy.symbols('alpha,a,d,theta', real=True)
2626

sympybotics/kinematics.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def sym_skew(v):
4141

4242
self.Jp = list(range(self.rbtdef.dof))
4343
for l in range(self.rbtdef.dof):
44-
self.Jp[l] = sympy.zeros((3, self.rbtdef.dof))
44+
self.Jp[l] = sympy.zeros(3, self.rbtdef.dof)
4545
for j in range(l + 1):
4646
if self.rbtdef._links_sigma[j]:
4747
self.Jp[l][0:3, j] = ifunc(z_ext[j - 1])
@@ -51,18 +51,18 @@ def sym_skew(v):
5151

5252
self.Jo = list(range(self.rbtdef.dof))
5353
for l in range(self.rbtdef.dof):
54-
self.Jo[l] = sympy.zeros((3, self.rbtdef.dof))
54+
self.Jo[l] = sympy.zeros(3, self.rbtdef.dof)
5555
for j in range(l + 1):
5656
if self.rbtdef._links_sigma[j]:
57-
self.Jo[l][0:3, j] = sympy.zeros((3, 1))
57+
self.Jo[l][0:3, j] = sympy.zeros(3, 1)
5858
else:
5959
self.Jo[l][0:3, j] = ifunc(z_ext[j - 1])
6060

6161
elif self.rbtdef._dh_convention == 'modified':
6262

6363
self.Jp = list(range(self.rbtdef.dof))
6464
for l in range(self.rbtdef.dof):
65-
self.Jp[l] = sympy.zeros((3, self.rbtdef.dof))
65+
self.Jp[l] = sympy.zeros(3, self.rbtdef.dof)
6666
for j in range(l + 1):
6767
if self.rbtdef._links_sigma[j]:
6868
self.Jp[l][0:3, j] = ifunc(geom.z[j])
@@ -72,10 +72,10 @@ def sym_skew(v):
7272

7373
self.Jo = list(range(self.rbtdef.dof))
7474
for l in range(self.rbtdef.dof):
75-
self.Jo[l] = sympy.zeros((3, self.rbtdef.dof))
75+
self.Jo[l] = sympy.zeros(3, self.rbtdef.dof)
7676
for j in range(l + 1):
7777
if self.rbtdef._links_sigma[j]:
78-
self.Jo[l][0:3, j] = sympy.zeros((3, 1))
78+
self.Jo[l][0:3, j] = sympy.zeros(3, 1)
7979
else:
8080
self.Jo[l][0:3, j] = ifunc(geom.z[j])
8181

sympybotics/tests/test_results.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def test_scara_dh_sym_geo_kin():
5656
[1, 1, 0, -1]])
5757

5858
assert (scara_geo.T[-1] - T_spong).expand() == sympy.zeros(4)
59-
assert (scara_kin.J[-1] - J_spong).expand() == sympy.zeros((6, 4))
59+
assert (scara_kin.J[-1] - J_spong).expand() == sympy.zeros(6, 4)
6060

6161

6262
def test_puma_dh_num_geo_kin_dyn():

0 commit comments

Comments
 (0)