R828D support #23
Merged
R828D support #23
+1,032
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cargo clippy`, fix tab/space consistency
ccostes
approved these changes
Oct 19, 2025
Owner
ccostes
left a comment
ccostes
left a comment
There was a problem hiding this comment.
Excellent work! Thanks for implementing rtl_tcp!
Just a few comments, but nothing blocking.
tkj666
commented
Oct 20, 2025
Contributor
Author
|
hi, are there any problems preventing the merge? If not, it would be great if you also bump the version and release the changes to crates.io after the merge. |
Owner
|
Oh whoops, I assumed you could merged after I approved 😅 Thanks again for the contributions! Will bump and release crate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2
Additionally, rtl_tcp is added to examples for testing. I currently own a rtl-sdr blog v4 dongle, test with sdr# using rtl_tcp and it works fine. Generic R828D device is not tested though because I don't have one.