Update

Author: cbritopacheco

src/Rodin/PETSc/Assembly/Generic.h

@@ -93,17 +93,15 @@ namespace Rodin::Assembly
 
       void execute(LinearSystemType& out, const InputType& input) const override
       {
+        PetscErrorCode ierr;
         const auto& u = input.getTrialFunction();
         const auto& v = input.getTestFunction();
         const auto& trialFES = u.getFiniteElementSpace();
         const auto& testFES = v.getFiniteElementSpace();
         auto& pb = input.getProblemBody();
         auto& [stiffness, solution, mass] = out;
 
-        MPI_Comm comm;
-        PetscErrorCode ierr;
-        ierr = PetscObjectGetComm(reinterpret_cast<PetscObject>(stiffness), &comm);
-        assert(ierr == PETSC_SUCCESS);
+        const MPI_Comm comm = out.getCommunicator();
 
         const BilinearFormAssemblyType bfa;
         bfa.execute(

src/Rodin/PETSc/CMakeLists.txt

@@ -25,8 +25,6 @@ set(RodinPETSc_SRCS
   Assembly/MPI.cpp
   Assembly/OpenMP.cpp
   Assembly/Sequential.cpp
-  Math/Vector.cpp
-  Math/Matrix.cpp
   Math/LinearSystem.cpp
   Variational/GridFunction.cpp
   Variational/TrialFunction.cpp

src/Rodin/PETSc/Math/LinearSystem.cpp

@@ -6,16 +6,16 @@
 
 namespace Rodin::Math
 {
-  LinearSystem<PETSc::Math::Matrix, PETSc::Math::Vector>::LinearSystem()
-    : m_comm(MPI_COMM_NULL)
-  {}
-
   LinearSystem<PETSc::Math::Matrix, PETSc::Math::Vector>::LinearSystem(MPI_Comm comm)
     : m_comm(comm)
   {
-    MatCreate(comm, &m_operator);
-    VecCreate(comm, &m_solution);
-    VecCreate(comm, &m_vector);
+    PetscErrorCode ierr;
+    ierr = MatCreate(comm, &m_operator);
+    assert(ierr == PETSC_SUCCESS);
+    ierr = VecCreate(comm, &m_solution);
+    assert(ierr == PETSC_SUCCESS);
+    ierr = VecCreate(comm, &m_vector);
+    assert(ierr == PETSC_SUCCESS);
   }
 
   LinearSystem<PETSc::Math::Matrix, PETSc::Math::Vector>::LinearSystem(const LinearSystem& other)
@@ -34,6 +34,18 @@ namespace Rodin::Math
       m_vector(std::exchange(other.m_vector, PETSC_NULLPTR))
   {}
 
+  LinearSystem<PETSc::Math::Matrix, PETSc::Math::Vector>::~LinearSystem()
+  {
+    m_comm = MPI_COMM_NULL;
+    PetscErrorCode ierr;
+    ierr = MatDestroy(&m_operator);
+    assert(ierr == PETSC_SUCCESS);
+    ierr = VecDestroy(&m_solution);
+    assert(ierr == PETSC_SUCCESS);
+    ierr = VecDestroy(&m_vector);
+    assert(ierr == PETSC_SUCCESS);
+  }
+
   LinearSystem<PETSc::Math::Matrix, PETSc::Math::Vector>&
   LinearSystem<PETSc::Math::Matrix, PETSc::Math::Vector>::operator=(const LinearSystem& other)
   {
@@ -61,24 +73,4 @@ namespace Rodin::Math
     }
     return *this;
   }
-
-  LinearSystem<PETSc::Math::Matrix, PETSc::Math::Vector>&
-  LinearSystem<PETSc::Math::Matrix, PETSc::Math::Vector>::create(MPI_Comm comm)
-  {
-    m_comm = comm;
-    MatCreate(comm, &m_operator);
-    VecCreate(comm, &m_solution);
-    VecCreate(comm, &m_vector);
-    return *this;
-  }
-
-  LinearSystem<PETSc::Math::Matrix, PETSc::Math::Vector>&
-  LinearSystem<PETSc::Math::Matrix, PETSc::Math::Vector>::destroy()
-  {
-    m_comm = MPI_COMM_NULL;
-    MatDestroy(&m_operator);
-    VecDestroy(&m_solution);
-    VecDestroy(&m_vector);
-    return *this;
-  }
 }

src/Rodin/PETSc/Math/LinearSystem.h

@@ -40,7 +40,7 @@ namespace Rodin::Math
 
       LinearSystem(LinearSystem&& other) noexcept;
 
-      virtual ~LinearSystem() = default;
+      virtual ~LinearSystem();
 
       LinearSystem& operator=(const LinearSystem& other);