fix: add missing tag_specifications for launch templates (#1212)

kayman-mk · web-flow · commit 28f06af680be · 2024-11-29T23:28:25.000+01:00
## Description Some of the `tag_specifications` were missing and are added in this PR. Leads to more resources being tagged correctly. Closes #1207
diff --git a/docker_autoscaler.tf b/docker_autoscaler.tf
@@ -97,11 +97,14 @@ resource "aws_launch_template" "this" {
     resource_type = "instance"
     tags          = local.tags
   }
-
   tag_specifications {
     resource_type = "volume"
     tags          = local.tags
   }
+  tag_specifications {
+    resource_type = "network-interface"
+    tags          = local.tags
+  }
 
   tags = local.tags
 
diff --git a/main.tf b/main.tf
@@ -308,6 +308,10 @@ resource "aws_launch_template" "gitlab_runner_instance" {
     resource_type = "volume"
     tags          = local.tags
   }
+  tag_specifications {
+    resource_type = "network-interface"
+    tags          = local.tags
+  }
   dynamic "tag_specifications" {
     for_each = var.runner_instance.spot_price == null || var.runner_instance.spot_price == "" ? [] : ["spot"]
     content {
@@ -410,6 +414,11 @@ resource "aws_launch_template" "fleet_gitlab_runner" {
     resource_type = "volume"
     tags          = local.tags
   }
+  tag_specifications {
+    resource_type = "network-interface"
+    tags          = local.tags
+  }
+  # tag_specifications for spot-instances-request do not work. Instance creation fails.
 
   tags = local.tags
 

Original file line number	Diff line number	Diff line change
`@@ -97,11 +97,14 @@ resource "aws_launch_template" "this" {`
`97`	`97`	`resource_type = "instance"`
`98`	`98`	`tags = local.tags`
`99`	`99`	`}`
`100`		`-`
`101`	`100`	`tag_specifications {`
`102`	`101`	`resource_type = "volume"`
`103`	`102`	`tags = local.tags`
`104`	`103`	`}`
	`104`	`+ tag_specifications {`
	`105`	`+ resource_type = "network-interface"`
	`106`	`+ tags = local.tags`
	`107`	`+ }`
`105`	`108`
`106`	`109`	`tags = local.tags`
`107`	`110`