Skip to content

Commit b5e8139

Browse files
authored
🔨 Upgrade meow to 4.0.0 (#84)
* ⬆️ Upgrade meow to 4.0.0 * ✨ Set meow flags and update the command-flag-option matcher * 🔥 Deprecate version method since its handled by meow * 🔥 Remove version() tests' * 🔧 Set travis.yml email notifications to false
1 parent e082be6 commit b5e8139

File tree

6 files changed

+117
-71
lines changed

6 files changed

+117
-71
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@ cache:
1010
directories:
1111
- node_modules
1212
notifications:
13+
email: false
1314
slack:
1415
secure: "BDNxGvbnIyqGhup6lOInE/75OAIV4+cdq2a1XR/Lb3OhTHPcIou3AhBIrj0iD9+EyKWtSMEMpa8fbCd0/lARSr8jxz7RoSR6xxsGJjZ5eX9xSyvtec3y/zXfocBIaPJKJStrh/r01QPIbjOtnI3biYFZXvef/j91gO4qHOqOGDRv523ogdWJC/e69pbNl99glvCH8UXYVIvESMLJymMUizttOHdVo4051xPRqLRye+9UQLv5JXFh2f9p073OjKct3yMXysCrOClcpzEwQDAOo6o0QeOdcQN4m7lhwpbHBadTuZ8m2fEBD00ZbxLyXr2hsO1QZGRULoI9TqgeapoKpbXtpI/UDvKBo4HLKuO3z7XeWUqJsffzYaRTTCs8jcQHGL6nmfr4XmU098p6vRjo7+c+Alfr5C2+YLhhircGRRhvm36FJyBj5BoLne8TVt96EiIlDgzsg98DzmT8p4hq8CvWm45M4vlInHRBOOSiCS7G+p6kAVR92zxZybCJBD9W5NoV8UPvfC3mQqs/LvGCUCSKxNDMD15rNY+a6v/LNDsmXabUBTGxnuyETc4axyu0Iu5gAjQKnBpqdnMNCAcSqxKFy1wYt7VgnMy0XxDLeYqwNBpvw7Yr0vmfDxFvdBLCboGK3jiHpvZagwc77Xdy5usts4LnLvTtGJjc19LdT58="

cli.js

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const updateNotifier = require('update-notifier')
77
const GitmojiCli = require('./src/gitmoji.js')
88
const pkg = require('./package.json')
99

10-
updateNotifier({pkg}).notify()
10+
updateNotifier({ pkg }).notify()
1111

1212
const cli = meow(`
1313
Usage
@@ -25,16 +25,16 @@ const cli = meow(`
2525
$ gitmoji -l
2626
$ gitmoji bug linter -s
2727
`, {
28-
alias: {
29-
c: 'commit',
30-
g: 'config',
31-
h: 'help',
32-
i: 'init',
33-
l: 'list',
34-
r: 'remove',
35-
s: 'search',
36-
u: 'update',
37-
v: 'version'
28+
flags: {
29+
commit: { type: 'boolean', alias: 'c' },
30+
config: { type: 'boolean', alias: 'g' },
31+
help: { type: 'boolean', alias: 'h' },
32+
init: { type: 'boolean', alias: 'i' },
33+
list: { type: 'boolean', alias: 'l' },
34+
remove: { type: 'boolean', alias: 'r' },
35+
search: { type: 'boolean', alias: 's' },
36+
update: { type: 'boolean', alias: 'u' },
37+
version: { type: 'boolean', alias: 'v' }
3838
}
3939
})
4040

@@ -54,9 +54,10 @@ const options = {
5454
list: () => gitmojiCli.list(),
5555
remove: () => gitmojiCli.remove(),
5656
search: () => cli.input.map(element => gitmojiCli.search(element)),
57-
update: () => gitmojiCli.updateCache(),
58-
version: () => console.log(gitmojiCli.version(pkg.version))
57+
update: () => gitmojiCli.updateCache()
5958
}
6059

61-
const command = Object.keys(cli.flags).filter((flag) => options[flag])
60+
const command = Object.keys(cli.flags)
61+
.map((flag) => cli.flags[flag] && flag)
62+
.filter((flag) => options[flag])
6263
options[command] ? options[command]() : cli.showHelp()

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "gitmoji-cli",
3-
"version": "1.8.4",
3+
"version": "1.8.5",
44
"description": "A gitmoji client for using emojis on commit messages.",
55
"engines": {
66
"node": ">=6"
@@ -35,7 +35,7 @@
3535
"execa": "^0.8.0",
3636
"inquirer": "^4.0.0",
3737
"inquirer-autocomplete-prompt": "^0.12.0",
38-
"meow": "^3.7.0",
38+
"meow": "^4.0.0",
3939
"parent-dirs": "^1.0.0",
4040
"path-exists": "^3.0.0",
4141
"update-notifier": "^2.3.0"

src/gitmoji.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,6 @@ class GitmojiCli {
6363
})
6464
}
6565

66-
version (number) {
67-
return number
68-
}
69-
7066
list () {
7167
return this._fetchEmojis()
7268
.then(gitmojis => this._parseGitmojis(gitmojis))

test/gitmojiCli.spec.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ const config = require('../src/config')
44
const prompts = require('../src/prompts')
55
const constants = require('../src/constants')
66
const guard = require('../src/guard')
7-
const pkg = require('../package.json')
87
const stubs = require('./stubs')
98

109
const gitmojiCli = new GitmojiCli(stubs.gitmojiApiClient)
@@ -73,12 +72,6 @@ describe('gitmoji module', () => {
7372
expect(gitmojiCli).toMatchSnapshot()
7473
})
7574

76-
describe('version', () => {
77-
it('should return the version number equal to the package.json one', () => {
78-
expect(gitmojiCli.version(pkg.version)).toEqual(pkg.version)
79-
})
80-
})
81-
8275
describe('commit', () => {
8376
it('should match for the commit snapshot with the given prompts', () => {
8477
config.setIssueFormat('github')

yarn.lock

Lines changed: 99 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -455,21 +455,18 @@ callsites@^2.0.0:
455455
version "2.0.0"
456456
resolved "https://registry.yarnpkg.com/callsites/-/callsites-2.0.0.tgz#06eb84f00eea413da86affefacbffb36093b3c50"
457457

458-
camelcase-keys@^2.0.0:
459-
version "2.1.0"
460-
resolved "https://registry.yarnpkg.com/camelcase-keys/-/camelcase-keys-2.1.0.tgz#308beeaffdf28119051efa1d932213c91b8f92e7"
458+
camelcase-keys@^4.0.0:
459+
version "4.2.0"
460+
resolved "https://registry.yarnpkg.com/camelcase-keys/-/camelcase-keys-4.2.0.tgz#a2aa5fb1af688758259c32c141426d78923b9b77"
461461
dependencies:
462-
camelcase "^2.0.0"
463-
map-obj "^1.0.0"
462+
camelcase "^4.1.0"
463+
map-obj "^2.0.0"
464+
quick-lru "^1.0.0"
464465

465466
camelcase@^1.0.2:
466467
version "1.2.1"
467468
resolved "https://registry.yarnpkg.com/camelcase/-/camelcase-1.2.1.tgz#9bb5304d2e0b56698b2c758b08a3eaa9daa58a39"
468469

469-
camelcase@^2.0.0:
470-
version "2.1.1"
471-
resolved "https://registry.yarnpkg.com/camelcase/-/camelcase-2.1.1.tgz#7c1d16d679a1bbe59ca02cacecfb011e201f5a1f"
472-
473470
camelcase@^4.0.0, camelcase@^4.1.0:
474471
version "4.1.0"
475472
resolved "https://registry.yarnpkg.com/camelcase/-/camelcase-4.1.0.tgz#d545635be1e33c542649c69173e5de6acfae34dd"
@@ -716,7 +713,14 @@ debug@^2.6.9:
716713
dependencies:
717714
ms "2.0.0"
718715

719-
decamelize@^1.0.0, decamelize@^1.1.1, decamelize@^1.1.2:
716+
decamelize-keys@^1.0.0:
717+
version "1.1.0"
718+
resolved "https://registry.yarnpkg.com/decamelize-keys/-/decamelize-keys-1.1.0.tgz#d171a87933252807eb3cb61dc1c1445d078df2d9"
719+
dependencies:
720+
decamelize "^1.1.0"
721+
map-obj "^1.0.0"
722+
723+
decamelize@^1.0.0, decamelize@^1.1.0, decamelize@^1.1.1:
720724
version "1.2.0"
721725
resolved "https://registry.yarnpkg.com/decamelize/-/decamelize-1.2.0.tgz#f6534d15148269b20352e7bee26f501f9a191290"
722726

@@ -822,7 +826,7 @@ errno@^0.1.4:
822826
dependencies:
823827
prr "~0.0.0"
824828

825-
error-ex@^1.2.0:
829+
error-ex@^1.2.0, error-ex@^1.3.1:
826830
version "1.3.1"
827831
resolved "https://registry.yarnpkg.com/error-ex/-/error-ex-1.3.1.tgz#f855a86ce61adc4e8621c3cda21e7a7612c3a8dc"
828832
dependencies:
@@ -1322,10 +1326,6 @@ get-caller-file@^1.0.1:
13221326
version "1.0.2"
13231327
resolved "https://registry.yarnpkg.com/get-caller-file/-/get-caller-file-1.0.2.tgz#f702e63127e7e231c160a80c1554acb70d5047e5"
13241328

1325-
get-stdin@^4.0.1:
1326-
version "4.0.1"
1327-
resolved "https://registry.yarnpkg.com/get-stdin/-/get-stdin-4.0.1.tgz#b968c6b0a04384324902e8bf1a5df32579a450fe"
1328-
13291329
get-stdin@^5.0.1:
13301330
version "5.0.1"
13311331
resolved "https://registry.yarnpkg.com/get-stdin/-/get-stdin-5.0.1.tgz#122e161591e21ff4c52530305693f20e6393a398"
@@ -1512,11 +1512,9 @@ imurmurhash@^0.1.4:
15121512
version "0.1.4"
15131513
resolved "https://registry.yarnpkg.com/imurmurhash/-/imurmurhash-0.1.4.tgz#9218b9b2b928a238b13dc4fb6b6d576f231453ea"
15141514

1515-
indent-string@^2.1.0:
1516-
version "2.1.0"
1517-
resolved "https://registry.yarnpkg.com/indent-string/-/indent-string-2.1.0.tgz#8e2d48348742121b4a8218b7a137e9a52049dc80"
1518-
dependencies:
1519-
repeating "^2.0.0"
1515+
indent-string@^3.0.0:
1516+
version "3.2.0"
1517+
resolved "https://registry.yarnpkg.com/indent-string/-/indent-string-3.2.0.tgz#4a5fd6d27cc332f37e5419a504dbb837105c9289"
15201518

15211519
inflight@^1.0.4:
15221520
version "1.0.6"
@@ -1738,6 +1736,10 @@ is-path-inside@^1.0.0:
17381736
dependencies:
17391737
path-is-inside "^1.0.1"
17401738

1739+
is-plain-obj@^1.1.0:
1740+
version "1.1.0"
1741+
resolved "https://registry.yarnpkg.com/is-plain-obj/-/is-plain-obj-1.1.0.tgz#71a50c8429dfca773c92a390a4a03b39fcd51d3e"
1742+
17411743
is-posix-bracket@^0.1.0:
17421744
version "0.1.1"
17431745
resolved "https://registry.yarnpkg.com/is-posix-bracket/-/is-posix-bracket-0.1.1.tgz#3334dc79774368e92f016e6fbc0a88f5cd6e6bc4"
@@ -2143,6 +2145,10 @@ jsesc@^1.3.0:
21432145
version "1.3.0"
21442146
resolved "https://registry.yarnpkg.com/jsesc/-/jsesc-1.3.0.tgz#46c3fec8c1892b12b0833db9bc7622176dbab34b"
21452147

2148+
json-parse-better-errors@^1.0.1:
2149+
version "1.0.1"
2150+
resolved "https://registry.yarnpkg.com/json-parse-better-errors/-/json-parse-better-errors-1.0.1.tgz#50183cd1b2d25275de069e9e71b467ac9eab973a"
2151+
21462152
json-schema@0.2.3:
21472153
version "0.2.3"
21482154
resolved "https://registry.yarnpkg.com/json-schema/-/json-schema-0.2.3.tgz#b480c892e59a2f05954ce727bd3f2a4e882f9e13"
@@ -2240,6 +2246,15 @@ load-json-file@^2.0.0:
22402246
pify "^2.0.0"
22412247
strip-bom "^3.0.0"
22422248

2249+
load-json-file@^4.0.0:
2250+
version "4.0.0"
2251+
resolved "https://registry.yarnpkg.com/load-json-file/-/load-json-file-4.0.0.tgz#2f5f45ab91e33216234fd53adab668eb4ec0993b"
2252+
dependencies:
2253+
graceful-fs "^4.1.2"
2254+
parse-json "^4.0.0"
2255+
pify "^3.0.0"
2256+
strip-bom "^3.0.0"
2257+
22432258
locate-path@^2.0.0:
22442259
version "2.0.0"
22452260
resolved "https://registry.yarnpkg.com/locate-path/-/locate-path-2.0.0.tgz#2b568b265eec944c6d9c0de9c3dbbbca0354cd8e"
@@ -2295,30 +2310,33 @@ makeerror@1.0.x:
22952310
dependencies:
22962311
tmpl "1.0.x"
22972312

2298-
map-obj@^1.0.0, map-obj@^1.0.1:
2313+
map-obj@^1.0.0:
22992314
version "1.0.1"
23002315
resolved "https://registry.yarnpkg.com/map-obj/-/map-obj-1.0.1.tgz#d933ceb9205d82bdcf4886f6742bdc2b4dea146d"
23012316

2317+
map-obj@^2.0.0:
2318+
version "2.0.0"
2319+
resolved "https://registry.yarnpkg.com/map-obj/-/map-obj-2.0.0.tgz#a65cd29087a92598b8791257a523e021222ac1f9"
2320+
23022321
mem@^1.1.0:
23032322
version "1.1.0"
23042323
resolved "https://registry.yarnpkg.com/mem/-/mem-1.1.0.tgz#5edd52b485ca1d900fe64895505399a0dfa45f76"
23052324
dependencies:
23062325
mimic-fn "^1.0.0"
23072326

2308-
meow@^3.7.0:
2309-
version "3.7.0"
2310-
resolved "https://registry.yarnpkg.com/meow/-/meow-3.7.0.tgz#72cb668b425228290abbfa856892587308a801fb"
2327+
meow@^4.0.0:
2328+
version "4.0.0"
2329+
resolved "https://registry.yarnpkg.com/meow/-/meow-4.0.0.tgz#fd5855dd008db5b92c552082db1c307cba20b29d"
23112330
dependencies:
2312-
camelcase-keys "^2.0.0"
2313-
decamelize "^1.1.2"
2331+
camelcase-keys "^4.0.0"
2332+
decamelize-keys "^1.0.0"
23142333
loud-rejection "^1.0.0"
2315-
map-obj "^1.0.1"
23162334
minimist "^1.1.3"
2335+
minimist-options "^3.0.1"
23172336
normalize-package-data "^2.3.4"
2318-
object-assign "^4.0.1"
2319-
read-pkg-up "^1.0.1"
2320-
redent "^1.0.0"
2321-
trim-newlines "^1.0.0"
2337+
read-pkg-up "^3.0.0"
2338+
redent "^2.0.0"
2339+
trim-newlines "^2.0.0"
23222340

23232341
merge@^1.1.3:
23242342
version "1.2.0"
@@ -2368,6 +2386,13 @@ minimatch@^3.0.2:
23682386
dependencies:
23692387
brace-expansion "^1.0.0"
23702388

2389+
minimist-options@^3.0.1:
2390+
version "3.0.2"
2391+
resolved "https://registry.yarnpkg.com/minimist-options/-/minimist-options-3.0.2.tgz#fba4c8191339e13ecf4d61beb03f070103f3d954"
2392+
dependencies:
2393+
arrify "^1.0.1"
2394+
is-plain-obj "^1.1.0"
2395+
23712396
minimist@0.0.8:
23722397
version "0.0.8"
23732398
resolved "https://registry.yarnpkg.com/minimist/-/minimist-0.0.8.tgz#857fcabfc3397d2625b8228262e86aa7a011b05d"
@@ -2609,6 +2634,13 @@ parse-json@^2.2.0:
26092634
dependencies:
26102635
error-ex "^1.2.0"
26112636

2637+
parse-json@^4.0.0:
2638+
version "4.0.0"
2639+
resolved "https://registry.yarnpkg.com/parse-json/-/parse-json-4.0.0.tgz#be35f5425be1f7f6c747184f98a788cb99477ee0"
2640+
dependencies:
2641+
error-ex "^1.3.1"
2642+
json-parse-better-errors "^1.0.1"
2643+
26122644
parse5@^1.5.1:
26132645
version "1.5.1"
26142646
resolved "https://registry.yarnpkg.com/parse5/-/parse5-1.5.1.tgz#9b7f3b0de32be78dc2401b17573ccaf0f6f59d94"
@@ -2653,6 +2685,12 @@ path-type@^2.0.0:
26532685
dependencies:
26542686
pify "^2.0.0"
26552687

2688+
path-type@^3.0.0:
2689+
version "3.0.0"
2690+
resolved "https://registry.yarnpkg.com/path-type/-/path-type-3.0.0.tgz#cef31dc8e0a1a3bb0d105c0cd97cf3bf47f4e36f"
2691+
dependencies:
2692+
pify "^3.0.0"
2693+
26562694
performance-now@^0.2.0:
26572695
version "0.2.0"
26582696
resolved "https://registry.yarnpkg.com/performance-now/-/performance-now-0.2.0.tgz#33ef30c5c77d4ea21c5a53869d91b56d8f2555e5"
@@ -2759,6 +2797,10 @@ qs@~6.4.0:
27592797
version "6.4.0"
27602798
resolved "https://registry.yarnpkg.com/qs/-/qs-6.4.0.tgz#13e26d28ad6b0ffaa91312cd3bf708ed351e7233"
27612799

2800+
quick-lru@^1.0.0:
2801+
version "1.1.0"
2802+
resolved "https://registry.yarnpkg.com/quick-lru/-/quick-lru-1.1.0.tgz#4360b17c61136ad38078397ff11416e186dcfbb8"
2803+
27622804
randomatic@^1.1.3:
27632805
version "1.1.7"
27642806
resolved "https://registry.yarnpkg.com/randomatic/-/randomatic-1.1.7.tgz#c7abe9cc8b87c0baa876b19fde83fd464797e38c"
@@ -2798,6 +2840,13 @@ read-pkg-up@^2.0.0:
27982840
find-up "^2.0.0"
27992841
read-pkg "^2.0.0"
28002842

2843+
read-pkg-up@^3.0.0:
2844+
version "3.0.0"
2845+
resolved "https://registry.yarnpkg.com/read-pkg-up/-/read-pkg-up-3.0.0.tgz#3ed496685dba0f8fe118d0691dc51f4a1ff96f07"
2846+
dependencies:
2847+
find-up "^2.0.0"
2848+
read-pkg "^3.0.0"
2849+
28012850
read-pkg@^1.0.0:
28022851
version "1.1.0"
28032852
resolved "https://registry.yarnpkg.com/read-pkg/-/read-pkg-1.1.0.tgz#f5ffaa5ecd29cb31c0474bca7d756b6bb29e3f28"
@@ -2814,6 +2863,14 @@ read-pkg@^2.0.0:
28142863
normalize-package-data "^2.3.2"
28152864
path-type "^2.0.0"
28162865

2866+
read-pkg@^3.0.0:
2867+
version "3.0.0"
2868+
resolved "https://registry.yarnpkg.com/read-pkg/-/read-pkg-3.0.0.tgz#9cbc686978fee65d16c00e2b19c237fcf6e38389"
2869+
dependencies:
2870+
load-json-file "^4.0.0"
2871+
normalize-package-data "^2.3.2"
2872+
path-type "^3.0.0"
2873+
28172874
readable-stream@^2.0.6, readable-stream@^2.1.4, readable-stream@^2.2.2:
28182875
version "2.3.3"
28192876
resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-2.3.3.tgz#368f2512d79f9d46fdfc71349ae7878bbc1eb95c"
@@ -2840,12 +2897,12 @@ rechoir@^0.6.2:
28402897
dependencies:
28412898
resolve "^1.1.6"
28422899

2843-
redent@^1.0.0:
2844-
version "1.0.0"
2845-
resolved "https://registry.yarnpkg.com/redent/-/redent-1.0.0.tgz#cf916ab1fd5f1f16dfb20822dd6ec7f730c2afde"
2900+
redent@^2.0.0:
2901+
version "2.0.0"
2902+
resolved "https://registry.yarnpkg.com/redent/-/redent-2.0.0.tgz#c1b2007b42d57eb1389079b3c8333639d5e1ccaa"
28462903
dependencies:
2847-
indent-string "^2.1.0"
2848-
strip-indent "^1.0.1"
2904+
indent-string "^3.0.0"
2905+
strip-indent "^2.0.0"
28492906

28502907
regenerator-runtime@^0.10.0:
28512908
version "0.10.5"
@@ -3236,11 +3293,9 @@ strip-eof@^1.0.0:
32363293
version "1.0.0"
32373294
resolved "https://registry.yarnpkg.com/strip-eof/-/strip-eof-1.0.0.tgz#bb43ff5598a6eb05d89b59fcd129c983313606bf"
32383295

3239-
strip-indent@^1.0.1:
3240-
version "1.0.1"
3241-
resolved "https://registry.yarnpkg.com/strip-indent/-/strip-indent-1.0.1.tgz#0c7962a6adefa7bbd4ac366460a638552ae1a0a2"
3242-
dependencies:
3243-
get-stdin "^4.0.1"
3296+
strip-indent@^2.0.0:
3297+
version "2.0.0"
3298+
resolved "https://registry.yarnpkg.com/strip-indent/-/strip-indent-2.0.0.tgz#5ef8db295d01e6ed6cbf7aab96998d7822527b68"
32443299

32453300
strip-json-comments@~2.0.1:
32463301
version "2.0.1"
@@ -3354,9 +3409,9 @@ tr46@~0.0.3:
33543409
version "0.0.3"
33553410
resolved "https://registry.yarnpkg.com/tr46/-/tr46-0.0.3.tgz#8184fd347dac9cdc185992f3a6622e14b9d9ab6a"
33563411

3357-
trim-newlines@^1.0.0:
3358-
version "1.0.0"
3359-
resolved "https://registry.yarnpkg.com/trim-newlines/-/trim-newlines-1.0.0.tgz#5887966bb582a4503a41eb524f7d35011815a613"
3412+
trim-newlines@^2.0.0:
3413+
version "2.0.0"
3414+
resolved "https://registry.yarnpkg.com/trim-newlines/-/trim-newlines-2.0.0.tgz#b403d0b91be50c331dfc4b82eeceb22c3de16d20"
33603415

33613416
trim-right@^1.0.1:
33623417
version "1.0.1"

0 commit comments

Comments
 (0)