Skip to content

Commit e0ccd4b

Browse files
committed
fixes for the latest alembic
1 parent de12509 commit e0ccd4b

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

sqlalchemy_iris/alembic.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import logging
2+
import re
23

34
from typing import Optional
45
from typing import Any
@@ -67,12 +68,17 @@ def compare_server_default(
6768
):
6869
return False
6970

70-
return super().compare_server_default(
71-
inspector_column,
72-
metadata_column,
73-
rendered_metadata_default,
74-
rendered_inspector_default,
75-
)
71+
if rendered_metadata_default is not None:
72+
rendered_metadata_default = re.sub(
73+
r"[\(\) \"\']", "", rendered_metadata_default
74+
)
75+
76+
if rendered_inspector_default is not None:
77+
rendered_inspector_default = re.sub(
78+
r"[\(\) \"\']", "", rendered_inspector_default
79+
)
80+
81+
return rendered_inspector_default != rendered_metadata_default
7682

7783
def alter_column(
7884
self,
@@ -178,10 +184,10 @@ def visit_rename_column(element: ColumnName, compiler: IRISDDLCompiler, **kw) ->
178184
format_column_name(compiler, element.newname),
179185
)
180186

187+
181188
@compiles(DropColumn, "iris")
182189
def visit_drop_column(element: DropColumn, compiler: IRISDDLCompiler, **kw) -> str:
183190
return "%s %s CASCADE" % (
184191
alter_table(compiler, element.table_name, element.schema),
185192
drop_column(compiler, element.column.name, **kw),
186193
)
187-

tests/test_alembic.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def tables(self, connection):
7070
self.meta.drop_all(connection)
7171

7272
def test_drop_col_with_fk(self, ops_context, connection, tables):
73-
ops_context.drop_column("round_trip_table", "oid_fk", self.meta.schema)
73+
ops_context.drop_column("round_trip_table", "oid_fk", schema=self.meta.schema)
7474
insp = inspect(connection)
7575
eq_(insp.get_foreign_keys("round_trip_table", schema=self.meta.schema), [])
7676

0 commit comments

Comments
 (0)