Skip to content
This repository was archived by the owner on Oct 19, 2021. It is now read-only.

Commit b00d244

Browse files
rezak-otmanimarijohannessen
authored andcommitted
fix(NumberInput): handle case when input is invalid, resolves #436 (#836)
* fix(NumberInput): handle case when input is invalid, resolves #436 * fix(NumberInput): handle case when input is invalid, resolves #436
1 parent a15e5b8 commit b00d244

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

src/components/NumberInput/NumberInput-test.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,13 @@ describe('NumberInput', () => {
123123
let numberInput = wrapper.find('input');
124124
expect(numberInput.prop('value')).toEqual(5);
125125
});
126+
127+
it('should set invalidText when value is empty string', () => {
128+
wrapper.setProps({ value: '' });
129+
const invalidText = wrapper.find('.bx--form-requirement');
130+
expect(invalidText.length).toEqual(1);
131+
expect(invalidText.text()).toEqual('invalid text');
132+
});
126133
});
127134
});
128135

src/components/NumberInput/NumberInput.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ export default class NumberInput extends Component {
146146

147147
const inputWrapperProps = {};
148148
let error = null;
149-
if (invalid) {
149+
if (invalid || this.state.value === '') {
150150
inputWrapperProps['data-invalid'] = true;
151151
error = <div className="bx--form-requirement">{invalidText}</div>;
152152
}

0 commit comments

Comments
 (0)