Skip to content

fix: use 'close' for modal tooltip text #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

Akshat55
Copy link
Contributor

@Akshat55 Akshat55 commented May 7, 2025

Match modal closeLabel text to React

Changelog

Changed

  • Close modal --> Close

Signed-off-by: Akshat Patel <38994122+Akshat55@users.noreply.github.com>
@Akshat55 Akshat55 requested a review from a team as a code owner May 7, 2025 00:14
Copy link

netlify bot commented May 7, 2025

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 87eebe3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/681aa5cb1df56400089c88a9
😎 Deploy Preview https://deploy-preview-3141--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 7, 2025

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit f75f623
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/681ab4e03d92540008a5cc6d
😎 Deploy Preview https://deploy-preview-3141--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Akshat55 Akshat55 merged commit ee4fdb0 into carbon-design-system:master May 7, 2025
4 checks passed
@Akshat55 Akshat55 deleted the modal-label branch May 7, 2025 01:19
Copy link

github-actions bot commented May 7, 2025

🎉 This PR is included in version 5.57.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant