Skip to content

Commit 4dcb72f

Browse files
authored
Merge pull request #2674 from Akshat55/number-value-bind
fix: Update value after change event is emitted
2 parents d139343 + fc5c569 commit 4dcb72f

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/number-input/number.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export class NumberChange {
6262
<input
6363
type="number"
6464
[id]="id"
65-
[attr.value]="value"
65+
[value]="value"
6666
[attr.min]="min"
6767
[attr.max]="max"
6868
[attr.step]="step"
@@ -71,7 +71,7 @@ export class NumberChange {
7171
[attr.aria-label]="ariaLabel"
7272
[attr.data-invalid]="invalid ? invalid : null"
7373
[placeholder]="placeholder"
74-
(input)="onNumberInputChange($event)"/>
74+
(change)="onNumberInputChange($event)"/>
7575
<svg
7676
*ngIf="!skeleton && !warn && invalid"
7777
cdsIcon="warning--filled"

src/number-input/number.stories.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ const Template: Story<NumberComponent> = (args) => ({
2323
[min]="min"
2424
[max]="max"
2525
[step]="step"
26-
[precision]="precision"
2726
[invalid]="invalid"
2827
[invalidText]="invalidText"
2928
[warn]="warn"
@@ -42,7 +41,6 @@ Basic.args = {
4241
min: 0,
4342
max: 100,
4443
step: 1,
45-
precision: 0,
4644
invalid: false,
4745
disabled: false
4846
};

0 commit comments

Comments
 (0)