chore: minor cleanups

Author: dahal

src/components/modals/index.ts

@@ -2,11 +2,11 @@
 
 import { createPushModal } from "pushmodal";
 import { ShareClassModal } from "./share-class-modal";
+import { ShareDataRoomModal } from "./share-dataroom-modal";
+import { ShareUpdateModal } from "./share-update-modal";
 import { SingleStakeholdersModal } from "./stakeholder/single-stake-holder-modal";
 import { TeamMemberModal } from "./team-member/team-member-modal";
 import { WipModal } from "./wip-modal";
-import { ShareUpdateModal } from "./share-update-modal";
-import { ShareDataRoomModal } from "./share-dataroom-modal";
 
 export const { pushModal, popModal, ModalProvider } = createPushModal({
   modals: {
@@ -18,4 +18,3 @@ export const { pushModal, popModal, ModalProvider } = createPushModal({
     ShareDataRoomModal,
   },
 });
-

src/components/modals/stakeholder/single-stake-holder-form.tsx

@@ -129,7 +129,7 @@ export const SingleStakeholderForm = () => {
               name="currentRelationship"
               render={({ field }) => (
                 <FormItem>
-                  <FormLabel>Association</FormLabel>
+                  <FormLabel>Group</FormLabel>
                   <Select onValueChange={field.onChange}>
                     <FormControl>
                       <SelectTrigger className="w-full">

src/components/ui/badge.tsx

@@ -14,9 +14,8 @@ const badgeVariants = cva(
         secondary:
           "border-transparent bg-secondary text-secondary-foreground hover:bg-secondary/80",
         warning: "border-transparent bg-yellow-50 text-yellow-800",
-        success: "border-transparent bg-teal-50 text-teal-800",
-        destructive:
-          "border-transparent bg-destructive text-destructive-foreground hover:bg-destructive/80",
+        success: "border-transparent bg-green-50 text-green-800",
+        destructive: "border-transparent bg-red-50 text-red-800",
         outline: "text-foreground",
       },
     },

src/components/update/change-update-visibility-alert-dialog.tsx

@@ -98,8 +98,8 @@ export function ChangeUpdateVisibilityAlertDialog({
           </AlertDialogTitle>
           <AlertDialogDescription>
             {isPublic
-              ? "Making update private prevents users to view."
-              : "Sharing the update allows public users to view"}
+              ? "Making it private prevents public users from accessing it."
+              : "Publicly sharing this update allows public users to view it, it may also be indexed by search engines."}
           </AlertDialogDescription>
         </AlertDialogHeader>
         <AlertDialogFooter>

src/components/update/update-table.tsx

@@ -50,7 +50,7 @@ const getUpdateStatus = (status: string) => {
     case "PUBLIC":
       return <Badge variant="success">Public</Badge>;
     case "PRIVATE":
-      return <Badge variant="outline">Private</Badge>;
+      return <Badge variant="destructive">Private</Badge>;
   }
 };
 
@@ -83,22 +83,6 @@ const UpdateActions = (row: { original: Update[number] }) => {
           </DropdownMenuItem>
         )}
 
-        <DropdownMenuItem
-          asChild
-          onClick={() => {
-            pushModal("ShareUpdateModal", {
-              update: {
-                id: updateId,
-                publicId: updatePublicId,
-              },
-            });
-          }}
-        >
-          <div className="relative hover:bg-gray-100 flex cursor-default select-none items-center rounded-sm px-2 py-1.5 text-sm outline-none transition-colors focus:bg-accent focus:text-accent-foreground data-[disabled]:pointer-events-none data-[disabled]:opacity-50">
-            Share this update
-          </div>
-        </DropdownMenuItem>
-
         {status !== "DRAFT" && (
           <DropdownMenuItem asChild>
             <ChangeUpdateVisibilityAlertDialog
@@ -114,6 +98,22 @@ const UpdateActions = (row: { original: Update[number] }) => {
             />
           </DropdownMenuItem>
         )}
+
+        <DropdownMenuItem
+          asChild
+          onClick={() => {
+            pushModal("ShareUpdateModal", {
+              update: {
+                id: updateId,
+                publicId: updatePublicId,
+              },
+            });
+          }}
+        >
+          <div className="relative hover:bg-gray-100 flex cursor-default select-none items-center rounded-sm px-2 py-1.5 text-sm outline-none transition-colors focus:bg-accent focus:text-accent-foreground data-[disabled]:pointer-events-none data-[disabled]:opacity-50">
+            Share this update
+          </div>
+        </DropdownMenuItem>
       </DropdownMenuContent>
     </DropdownMenu>
   );