more clippy suggestions

Author: dwrensha

capnp/src/schema.rs

@@ -157,6 +157,10 @@ impl FieldList {
         self.fields.len() as u16
     }
 
+    pub fn is_empty(&self) -> bool {
+        self.len() == 0
+    }
+
     pub fn get(self, index: u16) -> Field {
         Field {
             proto: self.fields.get(index as u32),
@@ -337,13 +341,13 @@ impl EnumerantList {
     }
 }
 
-impl<'a> IndexMove<u16, Enumerant> for EnumerantList {
+impl IndexMove<u16, Enumerant> for EnumerantList {
     fn index_move(&self, index: u16) -> Enumerant {
         self.get(index)
     }
 }
 
-impl<'a> ::core::iter::IntoIterator for EnumerantList {
+impl ::core::iter::IntoIterator for EnumerantList {
     type Item = Enumerant;
     type IntoIter = ShortListIter<Self, Self::Item>;
 
@@ -415,13 +419,13 @@ impl AnnotationList {
     }
 }
 
-impl<'a> IndexMove<u32, Annotation> for AnnotationList {
+impl IndexMove<u32, Annotation> for AnnotationList {
     fn index_move(&self, index: u32) -> Annotation {
         self.get(index)
     }
 }
 
-impl<'a> ::core::iter::IntoIterator for AnnotationList {
+impl ::core::iter::IntoIterator for AnnotationList {
     type Item = Annotation;
     type IntoIter = ListIter<Self, Self::Item>;
 

capnp/src/serialize/no_alloc_buffer_segments.rs

@@ -115,7 +115,7 @@ impl<'b> NoAllocBufferSegments<&'b [u8]> {
     /// ALIGNMENT: If the "unaligned" feature is enabled, then there are no alignment requirements on `buffer`.
     /// Otherwise, `buffer` must be 8-byte aligned (attempts to read the message will trigger errors).
     pub fn from_slice(slice: &mut &'b [u8], options: ReaderOptions) -> Result<Self> {
-        let segment_table_info = read_segment_table(&*slice, options)?;
+        let segment_table_info = read_segment_table(slice, options)?;
 
         let message_length = segment_table_info.segment_table_length_bytes
             + segment_table_info.total_segments_length_bytes;

capnp/src/struct_list.rs

@@ -68,10 +68,7 @@ where
     T: crate::traits::OwnedStruct,
 {
     fn clone(&self) -> Reader<'a, T> {
-        Reader {
-            marker: self.marker,
-            reader: self.reader,
-        }
+        *self
     }
 }
 impl<'a, T> Copy for Reader<'a, T> where T: crate::traits::OwnedStruct {}