iOS - app crashes when plugin stop is called

[ygyg70]

Describe the bug
App crashes when plugin stop is called
The crash report + a fix proposed by AI are included with this pull request:
pull request with crash report

To Reproduce
Steps to reproduce the behavior:

1. Start camera preview
2. Stop camera preview

Expected behavior
Camera preview stop should never cause the app to crash

Smartphone (please complete the following information):

• Device: iPhone13,1
• OS: iPhone OS 18.3.1

[ryaa]

@ygyg70 Please provide a repository or a sample app (for example, based on the example-app) that demonstrates the problem. Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed.

[ygyg70]

I was only able to reproduce with one specific phone, of a test user.
With that phone it consistently crashed if I stopped the preview before the camera stared streaming.
The fix was tested on that phone.
I had a single old crash report from another phone that was used for testing, but was not able to reproduce with that one.
No other real/test/debug devices had the issue
Spent few hours trying to reproduce automating edge cases usage with no success

Is there a way to certify the fix without reproducing, based on code review and best practices?

[ryaa]

@ygyg70 Thanks for your work on this!
I’ve reviewed your changes and can confirm that they address several crash-prone patterns in the original implementation by:

• Eliminating force unwraps (!)
• Safely handling missing or uninitialized properties
• Removing orientation observers when they’re no longer needed
• Releasing strong references to views during teardown

Since your PR had merge conflicts, I created a follow-up PR with all your changes carried over, along with some dependency updates: #392

I’ve tested it with the example-app and one of the production apps I maintain, and everything appears to be working as expected.

Let me know if you have any questions or feedback!