-
Notifications
You must be signed in to change notification settings - Fork 86
fix(android): safe area handling for Android 15+ #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes safe area handling for Android banner ads by restricting the window insets listener to only apply on Android 15+ (API level 35). This prevents issues that were introduced in a previous commit that affected earlier Android versions.
- Added Android version check to conditionally apply safe area handling
- Wrapped existing safe area code in Build.VERSION.SDK_INT check for VANILLA_ICE_CREAM (Android 15)
- Added necessary import for Build class
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
I would favorate #376 since it came first and handles more stuff? |
|
That said I have nothing against this one, but I would really update the tests so we do not revert them by error. |
|
can you please rebase to check if the tests are still running? |
|
@distante ready, could we launch the workflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hello @distante, all the checks were executed successfully. 🚀 |
|
Im waiting for this merge, really it will fix a serious issue |
|
Thanks @luisbytes, Just a notice, for a relase we need to ping @rdlabo. I do not have release credentials. |
|
Sorry for the wait. I've released it as 7.2.0! https://github.com/capacitor-community/admob/releases/tag/v7.2.0 |
@distante This PR fixes an issue #362 generated in the prerelease version due to this commit fa4c1b5.
To avoid affecting previous versions, as discussed in the issue, I've added validation to only apply the safe area on Android 15+.
Please can we merge these changes and generate a new prerelease version?