Skip to content

Check failure details don't show in 'pebble checks' when failures==threshold #634

@tonyandrewmeyer

Description

@tonyandrewmeyer

When the failure count is exactly the threshold, pebble checks doesn't provide information about the failure.

$ PEBBLE=/tmp go run ./cmd/pebble checks
Check  Level  Startup  Status  Failures  Change
chk1   -      enabled  up      0/3       12
$ PEBBLE=/tmp go run ./cmd/pebble checks
Check  Level  Startup  Status  Failures  Change
chk1   -      enabled  up      1/3       12 (exit status 2; ls: cannot access '/t... run "pebble tasks 12" for more)
$ PEBBLE=/tmp go run ./cmd/pebble checks
Check  Level  Startup  Status  Failures  Change
chk1   -      enabled  up      2/3       12 (exit status 2; ls: cannot access '/t... run "pebble tasks 12" for more)
$ PEBBLE=/tmp go run ./cmd/pebble checks
Check  Level  Startup  Status  Failures  Change
chk1   -      enabled  down    3/3       13
$ PEBBLE=/tmp go run ./cmd/pebble checks
Check  Level  Startup  Status  Failures  Change
chk1   -      enabled  down    4/3       13 (exit status 2; ls: cannot access '/t... run "pebble tasks 13" for more)

@benhoyt pointed out that it's happening because it's switched to the new change ID (13) but there are no failures on that change yet (they're still on 12).

It would be nice if we could improve this somehow.

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureA feature requestsmall itemA small item, for some value of "small"

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions