-
Notifications
You must be signed in to change notification settings - Fork 737
update lint/action.yml #3870 #3873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @rico33631! You're on the right track, but a few things need to change :)
Signed-off-by: rico <rico33631@gmail.com>
|
Hey, @rico33631! Your previous commit was good. Now there are two empty lines at the end of the file :) So if you go back to the previous commit, that will be perfect. |
Signed-off-by: rico <rico33631@gmail.com>
|
@rico33631 let me know if you've signed the CLA using your GitHub username. The system sometimes has some issues and does not see that you signed, so maybe it's an issue on our end. |
|
yes @andrei-toterman, I have signed the CLA using my GitHub username |
|
@rico33631 since your PR came from an external repository, it cannot fully run our CI, for security reasons. I have taken your commits and put them on a branch in this repository, while of course maintaining the authorship in your name. Could you please open a new PR using that branch by going here https://github.com/canonical/multipass/compare/ci-flutter-lint?expand=0? |
|
Hi @andrei-toterman, I tried to open the PR as requested, but I'm getting an error saying "Validation failed: must be a collaborator." |
|
Oof. Apologies for all of those complications. Unfortunately I don't have the permissions to allow you to do that. I'll open up the PR and give you credit for it. Thank you again for your contribution! It is highly appreciated! And again sorry for this! |
|
No problem @andrei-toterman! Youre welcome and actually thank you for being so patient!! |
issue #3870
This PR updates the linting workflow to include steps for initializing submodules, verifying Flutter installation, and checking Flutter code formatting.