Skip to content

Conversation

@rico33631
Copy link
Contributor

issue #3870

This PR updates the linting workflow to include steps for initializing submodules, verifying Flutter installation, and checking Flutter code formatting.

Copy link
Contributor

@andrei-toterman andrei-toterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rico33631! You're on the right track, but a few things need to change :)

Signed-off-by: rico <rico33631@gmail.com>
@andrei-toterman
Copy link
Contributor

Hey, @rico33631! Your previous commit was good. Now there are two empty lines at the end of the file :) So if you go back to the previous commit, that will be perfect.
Also, you'll have to sign the Contributor License Agreement to have the PR merged, which you can find here https://ubuntu.com/legal/contributors/agreement.

Signed-off-by: rico <rico33631@gmail.com>
@andrei-toterman
Copy link
Contributor

@rico33631 let me know if you've signed the CLA using your GitHub username. The system sometimes has some issues and does not see that you signed, so maybe it's an issue on our end.

@rico33631
Copy link
Contributor Author

yes @andrei-toterman, I have signed the CLA using my GitHub username

@jibel jibel requested a review from sharder996 January 16, 2025 15:37
@andrei-toterman
Copy link
Contributor

@rico33631 since your PR came from an external repository, it cannot fully run our CI, for security reasons. I have taken your commits and put them on a branch in this repository, while of course maintaining the authorship in your name. Could you please open a new PR using that branch by going here https://github.com/canonical/multipass/compare/ci-flutter-lint?expand=0?

@rico33631
Copy link
Contributor Author

Hi @andrei-toterman, I tried to open the PR as requested, but I'm getting an error saying "Validation failed: must be a collaborator."

@andrei-toterman
Copy link
Contributor

Oof. Apologies for all of those complications. Unfortunately I don't have the permissions to allow you to do that. I'll open up the PR and give you credit for it. Thank you again for your contribution! It is highly appreciated! And again sorry for this!

@rico33631
Copy link
Contributor Author

No problem @andrei-toterman! Youre welcome and actually thank you for being so patient!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants