fixes #8 adds warnings if you have params that are not understood

Author: justinbmeyer

package.json

@@ -52,6 +52,7 @@
   },
   "devDependencies": {
     "can-define": "^2.0.3",
+    "can-test-helpers": "^1.1.2",
     "jshint": "^2.9.1",
     "steal": "^1.6.2",
     "steal-qunit": "^1.0.1",

src/serializers/basic-query-test.js

@@ -4,6 +4,7 @@ var canReflect = require("can-reflect");
 var logicTypes = require("../types/and-or-not");
 var is = require("../types/comparisons");
 var makeMaybe = require("../types/make-maybe");
+var testHelpers = require("can-test-helpers");
 
 QUnit.module("can-query-logic/serializers/basic-query");
 
@@ -147,6 +148,33 @@ QUnit.test("auto-convert or schema into maybe type", function(){
     }, "serialized");
 });
 
+
+testHelpers.dev.devOnlyTest("warn if query properties are not defined (#8)", function() {
+	QUnit.expect(3);
+
+	var message = "can-query-logic: Ignoring keys: start, end.";
+	var finishErrorCheck = testHelpers.dev.willWarn(message, function(actualMessage, success) {
+		QUnit.equal(actualMessage, message, "Warning is expected message");
+		QUnit.ok(success);
+	});
+
+
+    var query = {
+        filter: {
+            name: {
+                first: "justin"
+            }
+        },
+        start: 0,
+        end: 1
+    };
+
+    var converter = makeBasicQueryConvert(EmptySchema);
+
+    converter.hydrate(query);
+    QUnit.equal(finishErrorCheck(), 1);
+});
+
 /*
 QUnit.skip("nested properties within ors", function(){
     var query = {

src/serializers/basic-query.js

@@ -7,9 +7,9 @@ var Serializer = require("../serializer");
 var is = require("../types/comparisons");
 var makeMaybe = require("../types/make-maybe");
 var makeEnum = require("../types/make-enum");
+var logDev = require("can-log/dev/dev");
 
 var setTypeSymbol = canSymbol.for("can.SetType");
-var comparisonSetTypeSymbol = canSymbol.for("can.ComparisonSetType");
 var schemaSymbol = canSymbol.for("can.getSchema");
 
 var defaultQuery = new BasicQuery({});
@@ -245,7 +245,7 @@ module.exports = function(schema) {
             if(canReflect.size(filter) !== 0) {
                 res.filter= filter;
             }
-            
+
             if(!set.isEqual(basicQuery.page, defaultQuery.page)) {
                 // we always provide the start, even if it's 0
                 res.page = {
@@ -273,6 +273,18 @@ module.exports = function(schema) {
 
     return {
         hydrate: function(data){
+
+            //!steal-remove-start
+            var AcceptedFields = makeEnum(function(){},["filter","sort","page"]);
+            var diff = set.difference(new AcceptedFields(Object.keys(data)), AcceptedFields.UNIVERSAL);
+            if(diff.values && diff.values.length) {
+    			logDev.warn(
+    				"can-query-logic: Ignoring keys: " + diff.values.join(", ") + "."
+    			);
+    		}
+    		//!steal-remove-end
+
+
             var filter = canReflect.serialize(data.filter);
 
             // this mutates