Skip to content

Commit a5fe5be

Browse files
ci- cleanup lint samples
The lint sample should only run the lint checks for the samples Either, make no sense we run for all of them. We can ensure all plugins by just running project-v4 and project-v4-with-deploy-image which has further code scafold. By last, see that the `make tests` are called in the prow already.
1 parent e93492b commit a5fe5be

File tree

1 file changed

+10
-30
lines changed

1 file changed

+10
-30
lines changed

.github/workflows/lint-sample.yml

Lines changed: 10 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
1-
# Copyright 2023 The Caramello-io Authors.
2-
3-
name: Sample Testdata Tests
1+
name: Lint Samples
42

53
on:
64
push:
5+
paths-ignore:
6+
- '**/*.md'
77
pull_request:
8+
paths-ignore:
9+
- '**/*.md'
810

911
jobs:
10-
test:
11-
name: "Testdata - make test"
12+
lint-samples:
1213
runs-on: ubuntu-latest
1314
if: (github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository)
1415
steps:
@@ -18,36 +19,15 @@ jobs:
1819
uses: actions/setup-go@v5
1920
with:
2021
go-version: '~1.22'
21-
- name: Remove pre-installed kustomize
22-
run: sudo rm -f /usr/local/bin/kustomize
23-
- name: Run make test for project-v4-with-deploy-image
24-
run: cd testdata/project-v4-with-deploy-image && go mod tidy && make all && make test
25-
- name: Run make test for project-v4-multigroup-with-deploy-image
26-
run: cd testdata/project-v4-multigroup-with-deploy-image && go mod tidy && make all && make test
27-
28-
lint:
29-
name: "Testdata - Lint"
30-
runs-on: ubuntu-latest
31-
# Pull requests from the same repository won't trigger this checks as they were already triggered by the push
32-
if: (github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository)
33-
steps:
34-
- name: Setup Go
35-
uses: actions/setup-go@v5
36-
with:
37-
go-version: '~1.22'
38-
- name: Clone the code
39-
uses: actions/checkout@v4
4022
- name: Run linter
4123
uses: golangci/golangci-lint-action@v6
4224
with:
43-
version: v1.57
44-
working-directory: testdata/project-v4-with-deploy-image
25+
version: v1.59
26+
working-directory: testdata/project-v4
4527
args: --config .golangci.yml ./...
46-
skip-cache: true # first lint action will handle
4728
- name: Run linter
4829
uses: golangci/golangci-lint-action@v6
4930
with:
50-
version: v1.57
51-
working-directory: testdata/project-v4-multigroup-with-deploy-image
31+
version: v1.59
32+
working-directory: testdata/project-v4-with-deploy-image
5233
args: --config .golangci.yml ./...
53-
skip-cache: true # first lint action will handle

0 commit comments

Comments
 (0)