Skip to content

Commit 7e02efb

Browse files
authored
Merge pull request kubernetes-sigs#4118 from camilamacedo86/fix-e2e-deploy-image
🌱 ci: fix GitHub action to test make test-e2e for deploy-image
2 parents 3570efc + 9de4d9a commit 7e02efb

File tree

1 file changed

+21
-6
lines changed

1 file changed

+21
-6
lines changed

.github/workflows/test-e2e-samples.yml

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,32 @@ jobs:
4848
run: |
4949
make test-e2e
5050
51+
- name: Teardown kind cluster
52+
run: kind delete cluster
53+
54+
- name: Create kind cluster
55+
run: kind create cluster
56+
5157
- name: Prepare project-v4-with-deploy-image
5258
run: |
5359
KUSTOMIZATION_FILE_PATH="testdata/project-v4-with-deploy-image/config/default/kustomization.yaml"
5460
sed -i '25s/^#//' $KUSTOMIZATION_FILE_PATH
5561
sed -i '51s/^#//' $KUSTOMIZATION_FILE_PATH
62+
# Uncomment only ValidatingWebhookConfiguration
63+
# from cert-manager replaces
64+
sed -i '55,70s/^#//' $KUSTOMIZATION_FILE_PATH
65+
sed -i '55,70s/^#//' $KUSTOMIZATION_FILE_PATH
66+
sed -i '79,101s/^#//' $KUSTOMIZATION_FILE_PATH
67+
sed -i '110,151s/^#//' $KUSTOMIZATION_FILE_PATH
68+
# Comment the injection for MutatingWebhookConfiguration
69+
# Fixme: We should not scaffold or it should be commented
70+
# by default when only validation webhooks are scaffolded
71+
WEBHOOK_INJECTION_FILE_PATH="testdata/project-v4-with-deploy-image/config/default/webhookcainjection_patch.yaml"
72+
sed -i '3,11s/^/#/' $WEBHOOK_INJECTION_FILE_PATH
5673
cd testdata/project-v4-with-deploy-image/
5774
go mod tidy
5875
59-
# Fixme: The e2e tests for deploy image are failing and we
60-
# need to fix in a follow up
61-
# - name: Testing make test-e2e for project-v4-with-deploy-image
62-
# working-directory: testdata/project-v4-with-deploy-image
63-
# run: |
64-
# make test-e2e
76+
- name: Testing make test-e2e for project-v4-with-deploy-image
77+
working-directory: testdata/project-v4-with-deploy-image
78+
run: |
79+
make test-e2e

0 commit comments

Comments
 (0)