From f1903c4b34e7108f687fe8610222269ae509173c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oskar=20Kwas=CC=81niewski?= Date: Mon, 24 Jun 2024 13:02:48 +0200 Subject: [PATCH] fix: remove unnecessary diff after upstreaming changes --- .../Libraries/LinkingIOS/React-RCTLinking.podspec | 2 -- .../Libraries/NativeAnimation/React-RCTAnimation.podspec | 2 -- .../react/renderer/graphics/React-graphics.podspec | 2 -- .../react-native/sdks/hermes-engine/hermes-engine.podspec | 4 ++-- .../sdks/hermes-engine/utils/build-hermes-xcode.sh | 3 --- 5 files changed, 2 insertions(+), 11 deletions(-) diff --git a/packages/react-native/Libraries/LinkingIOS/React-RCTLinking.podspec b/packages/react-native/Libraries/LinkingIOS/React-RCTLinking.podspec index 3951fb9c67654c..a8260d34e90434 100644 --- a/packages/react-native/Libraries/LinkingIOS/React-RCTLinking.podspec +++ b/packages/react-native/Libraries/LinkingIOS/React-RCTLinking.podspec @@ -45,8 +45,6 @@ Pod::Spec.new do |s| "HEADER_SEARCH_PATHS" => header_search_paths.join(' ') } s.framework = "UIKit" - - s.framework = "UIKit" s.dependency "React-Core/RCTLinkingHeaders", version s.dependency "ReactCommon/turbomodule/core", version diff --git a/packages/react-native/Libraries/NativeAnimation/React-RCTAnimation.podspec b/packages/react-native/Libraries/NativeAnimation/React-RCTAnimation.podspec index bc23ec29c28160..39ebfdb41c50b9 100644 --- a/packages/react-native/Libraries/NativeAnimation/React-RCTAnimation.podspec +++ b/packages/react-native/Libraries/NativeAnimation/React-RCTAnimation.podspec @@ -44,8 +44,6 @@ Pod::Spec.new do |s| "HEADER_SEARCH_PATHS" => header_search_paths.join(" ") } s.framework = ["UIKit", "QuartzCore"] - - s.framework = ["UIKit", "QuartzCore"] s.dependency "RCT-Folly", folly_version s.dependency "RCTTypeSafety" diff --git a/packages/react-native/ReactCommon/react/renderer/graphics/React-graphics.podspec b/packages/react-native/ReactCommon/react/renderer/graphics/React-graphics.podspec index 32bec4887bdae8..e9b0cd49cfa6f4 100644 --- a/packages/react-native/ReactCommon/react/renderer/graphics/React-graphics.podspec +++ b/packages/react-native/ReactCommon/react/renderer/graphics/React-graphics.podspec @@ -55,8 +55,6 @@ Pod::Spec.new do |s| header_search_paths = header_search_paths + ["\"$(PODS_TARGET_SRCROOT)/platform/ios\""] end - s.framework = "UIKit" - s.pod_target_xcconfig = { "USE_HEADERMAP" => "NO", "HEADER_SEARCH_PATHS" => header_search_paths.join(" "), "DEFINES_MODULE" => "YES", diff --git a/packages/react-native/sdks/hermes-engine/hermes-engine.podspec b/packages/react-native/sdks/hermes-engine/hermes-engine.podspec index cdfc4b50de949d..fccaa4d83f8d74 100644 --- a/packages/react-native/sdks/hermes-engine/hermes-engine.podspec +++ b/packages/react-native/sdks/hermes-engine/hermes-engine.podspec @@ -12,8 +12,7 @@ react_native_path = File.join(__dir__, "..", "..") package = JSON.parse(File.read(File.join(react_native_path, "package.json"))) version = package['version'] -# Temporaily build from source until visionOS supports prebuilt binaries -source_type = HermesEngineSourceType::BUILD_FROM_GITHUB_MAIN # hermes_source_type(version, react_native_path) +source_type = hermes_source_type(version, react_native_path) source = podspec_source(source_type, version, react_native_path) Pod::Spec.new do |spec| @@ -139,6 +138,7 @@ Pod::Spec.new do |spec| :name => '[RN] [2] Build Hermes', :input_files => ["#{hermesc_path}/ImportHermesc.cmake"], :output_files => [ + "${PODS_ROOT}/hermes-engine/build/iphonesimulator/API/hermes/hermes.framework/hermes", "${PODS_ROOT}/hermes-engine/build/xrsimulator/API/hermes/hermes.framework/hermes", ], :script => <<-EOS diff --git a/packages/react-native/sdks/hermes-engine/utils/build-hermes-xcode.sh b/packages/react-native/sdks/hermes-engine/utils/build-hermes-xcode.sh index b4e834875a18c3..0fa473e9c11fca 100755 --- a/packages/react-native/sdks/hermes-engine/utils/build-hermes-xcode.sh +++ b/packages/react-native/sdks/hermes-engine/utils/build-hermes-xcode.sh @@ -31,9 +31,6 @@ function get_deployment_target { elif [[ $1 == "xrsimulator" || $1 == "xros" ]]; then echo "${XROS_DEPLOYMENT_TARGET}" return - elif [[ $1 == "xrsimulator" || $1 == "xros" ]]; then - echo ${XROS_DEPLOYMENT_TARGET} - return fi echo "${IPHONEOS_DEPLOYMENT_TARGET}"