chore: improve eslint rules and fix issues

Author: satya164

eslint.config.mjs

@@ -1,10 +1,28 @@
-// eslint-disable-next-line import-x/extensions,import-x/no-unresolved
 import { defineConfig, globalIgnores } from 'eslint/config';
-import { recommended, vitest } from 'eslint-config-satya164';
+import { recommended, vitest, typechecked } from 'eslint-config-satya164';
 
 export default defineConfig(
   recommended,
   vitest,
+  typechecked,
+
+  {
+    languageOptions: {
+      parserOptions: {
+        project: true,
+        tsconfigRootDir: import.meta.dirname,
+      },
+    },
+
+    rules: {
+      '@typescript-eslint/no-unsafe-argument': 'off',
+      '@typescript-eslint/no-unsafe-assignment': 'off',
+      '@typescript-eslint/no-unsafe-call': 'off',
+      '@typescript-eslint/no-unsafe-member-access': 'off',
+      '@typescript-eslint/no-unnecessary-condition': 'off',
+      '@typescript-eslint/strict-boolean-expressions': 'off',
+    },
+  },
 
   globalIgnores([
     '**/.next/',

package.json

@@ -30,10 +30,10 @@
     "commitlint": "^17.0.2",
     "concurrently": "^7.2.2",
     "eslint": "^9.26.0",
-    "eslint-config-satya164": "^5.0.3",
+    "eslint-config-satya164": "^5.1.1",
     "globals": "^16.0.0",
     "prettier": "^3.5.3",
-    "typescript": "^5.2.2"
+    "typescript": "^5.8.3"
   },
   "commitlint": {
     "extends": [

packages/create-react-native-library/bin/create-react-native-library

@@ -1,4 +1,3 @@
 #!/usr/bin/env node
 
-// eslint-disable-next-line import/no-commonjs
 require('../lib/index');

packages/create-react-native-library/src/exampleApp/generateExampleApp.ts

@@ -117,6 +117,9 @@ export default async function generateExampleApp({
         'blank',
       ];
       break;
+    case 'none': {
+      // Do nothing
+    }
   }
 
   await spawn('npx', args, {
@@ -193,15 +196,18 @@ export default async function generateExampleApp({
 
   if (config.project.moduleConfig === 'nitro-modules') {
     const packagesToAddNitro = {
-      'react-native-nitro-modules': `^${config.versions.nitroModules}`,
+      'react-native-nitro-modules': `^${config.versions.nitro || 'latest'}`,
     };
+
     Object.assign(dependencies, packagesToAddNitro);
   }
 
   Object.assign(devDependencies, PACKAGES_TO_ADD_DEV);
 
   if (config.example === 'expo') {
-    const sdkVersion = dependencies.expo.split('.')[0].replace(/[^\d]/, '');
+    const sdkVersion: string = dependencies.expo
+      .split('.')[0]
+      .replace(/[^\d]/, '');
 
     let bundledNativeModules: Record<string, string>;
 
@@ -213,11 +219,12 @@ export default async function generateExampleApp({
             (res) => {
               let data = '';
 
-              res.on('data', (chunk) => (data += chunk));
+              res.on('data', (chunk: string) => (data += chunk));
               res.on('end', () => {
                 try {
                   resolve(JSON.parse(data));
                 } catch (e) {
+                  // eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors
                   reject(e);
                 }
               });

packages/create-react-native-library/src/index.ts

@@ -38,8 +38,7 @@ type Args = Partial<Answers> & {
   [key: string]: unknown;
 };
 
-// eslint-disable-next-line @typescript-eslint/no-unused-expressions
-yargs
+void yargs
   .command('$0 [name]', 'create a react native library', acceptedArgs, create)
   .demandCommand()
   .recommendCommands()
@@ -82,9 +81,7 @@ async function create(_argv: Args) {
   const config = generateTemplateConfiguration({
     versions: {
       bob: bobVersion,
-      nitroModules: nitroModulesVersion,
-      // Nitro codegen's version is always the same as nitro modules version.
-      nitroCodegen: nitroModulesVersion,
+      nitro: nitroModulesVersion,
     },
     basename: path.basename(answers.name ?? answers.directory),
     answers,

packages/create-react-native-library/src/input.ts

@@ -276,7 +276,9 @@ export async function createQuestions({
         try {
           const username = await githubUsername(answers.authorEmail);
 
-          return `https://github.com/${username}`;
+          if (username) {
+            return `https://github.com/${username}`;
+          }
         } catch (e) {
           // Ignore error
         }
@@ -378,6 +380,7 @@ export function createMetadata(answers: Partial<PromptAnswers>) {
   ][];
 
   const libraryMetadata = Object.fromEntries(
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
     (Object.entries(answers) as AnswerEntries).filter(
       ([answer]) => !ignoredAnswers.includes(answer)
     )

packages/create-react-native-library/src/template.ts

@@ -5,8 +5,7 @@ import type { Answers, ExampleApp, ProjectType } from './input';
 
 export type TemplateVersions = {
   bob: string;
-  nitroModules?: string;
-  nitroCodegen?: string;
+  nitro: string | undefined;
 };
 
 export type ModuleConfig =
@@ -126,7 +125,7 @@ export function generateTemplateConfiguration({
             basename
           : // Otherwise, convert it to PascalCase and remove any non-alphanumeric characters
             `${project.charAt(0).toUpperCase()}${project
-              .replace(/[^a-z0-9](\w)/g, (_, $1) => $1.toUpperCase())
+              .replace(/[^a-z0-9](\w)/g, (_, $1: string) => $1.toUpperCase())
               .slice(1)}`,
       package: pack,
       package_dir: pack.replace(/\./g, '/'),
@@ -154,7 +153,8 @@ function getModuleConfig(projectType: ProjectType): ModuleConfig {
       return 'nitro-modules';
     case 'turbo-module':
       return 'turbo-modules';
-    default:
+    case 'fabric-view':
+    case 'library':
       return null;
   }
 }
@@ -163,7 +163,9 @@ function getViewConfig(projectType: ProjectType): ViewConfig {
   switch (projectType) {
     case 'fabric-view':
       return 'fabric-view';
-    default:
+    case 'nitro-module':
+    case 'turbo-module':
+    case 'library':
       return null;
   }
 }

packages/create-react-native-library/src/utils/local.ts

@@ -10,7 +10,7 @@ type PackageJson = {
 export async function addNitroDependencyToLocalLibrary(
   config: TemplateConfiguration
 ): Promise<boolean> {
-  if (config.versions.nitroModules === undefined) {
+  if (config.versions.nitro === undefined) {
     return false;
   }
 
@@ -22,7 +22,7 @@ export async function addNitroDependencyToLocalLibrary(
   const appPackageJson: PackageJson = await fs.readJson(appPackageJsonPath);
   const dependencies = appPackageJson['dependencies'] ?? {};
 
-  dependencies['react-native-nitro-modules'] = config.versions.nitroModules;
+  dependencies['react-native-nitro-modules'] = config.versions.nitro;
 
   appPackageJson['dependencies'] = dependencies;
   await fs.writeJson(appPackageJsonPath, appPackageJson, {

packages/create-react-native-library/src/utils/prompt.ts

@@ -58,9 +58,7 @@ export async function prompt<
 ): Promise<PromptAnswers & Argv> {
   const interactive =
     options?.interactive ??
-    Boolean(
-      process.stdout.isTTY && process.env.TERM !== 'dumb' && !process.env.CI
-    );
+    (process.stdout.isTTY && process.env.TERM !== 'dumb' && !process.env.CI);
 
   const onCancel = () => {
     // Exit the CLI on Ctrl+C
@@ -182,7 +180,7 @@ export async function prompt<
     if (missingQuestions.length) {
       onError(
         `Missing values for options: ${missingQuestions
-          .map(kleur.blue)
+          .map((q) => kleur.blue(q))
           .join(', ')}`
       );
     }
@@ -196,6 +194,7 @@ export async function prompt<
 
   validate(result, questions, onError);
 
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
   return result as PromptAnswers & Argv;
 }
 

packages/create-react-native-library/src/utils/resolveNpmPackageVersion.ts

@@ -12,7 +12,9 @@ export async function resolveNpmPackageVersion(
 
     result = await Promise.race([
       new Promise<string>((resolve) => {
-        setTimeout(() => resolve(fallback), timeout);
+        setTimeout(() => {
+          resolve(fallback);
+        }, timeout);
       }),
       promise,
     ]);

packages/create-react-native-library/src/utils/sortObjectKeys.ts

@@ -1,8 +1,10 @@
 export default function sortObjectKeys<T extends Record<string, unknown>>(
   obj: T
 ): T {
+  // eslint-disable-next-line @typescript-eslint/require-array-sort-compare
   return (Object.keys(obj) as (keyof T)[]).sort().reduce((acc, key) => {
     acc[key] = obj[key];
     return acc;
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
   }, {} as T);
 }

packages/create-react-native-library/src/utils/spawn.ts

@@ -8,12 +8,12 @@ export const spawn = async (...args: Parameters<typeof crossSpawn>) => {
     let stderr = '';
 
     child.stdout?.setEncoding('utf8');
-    child.stdout?.on('data', (data) => {
+    child.stdout?.on('data', (data: string) => {
       stdout += data;
     });
 
     child.stderr?.setEncoding('utf8');
-    child.stderr?.on('data', (data) => {
+    child.stderr?.on('data', (data: string) => {
       stderr += data;
     });
 

packages/create-react-native-library/templates/common/$package.json

@@ -104,7 +104,7 @@
 <% if (example !== 'expo') { -%>
     "turbo": "^1.10.7",
 <% } -%>
-    "typescript": "^5.2.2"
+    "typescript": "^5.8.3"
   },
   "peerDependencies": {
     "react": "*",

packages/react-native-builder-bob/babel-preset.js

@@ -11,9 +11,11 @@ const browserslist = require('browserslist');
  */
 module.exports = function (api, options, cwd) {
   const opt = (name) =>
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-return
     options[name] !== undefined
       ? options[name]
-      : api.caller((caller) => (caller != null ? caller[name] : undefined));
+      : // eslint-disable-next-line @typescript-eslint/no-unsafe-return
+        api.caller((caller) => (caller != null ? caller[name] : undefined));
 
   const supportsStaticESM = opt('supportsStaticESM');
   const rewriteImportExtensions = opt('rewriteImportExtensions');

packages/react-native-builder-bob/bin/bob

@@ -1,4 +1,3 @@
 #!/usr/bin/env node
 
-// eslint-disable-next-line import/no-commonjs
 require('../lib/index');

packages/react-native-builder-bob/metro-config.js

@@ -14,4 +14,5 @@ const { withMetroConfig } = require('react-native-monorepo-config');
  * @returns {import('metro-config').MetroConfig} Metro configuration
  */
 exports.getConfig = (baseConfig, { root, project }) =>
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-return
   withMetroConfig(baseConfig, { root, dirname: project });

packages/react-native-builder-bob/src/__tests__/init.test.ts

@@ -1,4 +1,4 @@
-import { afterEach, beforeEach, expect, test, vi, type Mock } from 'vitest';
+import { afterEach, beforeEach, expect, test, vi } from 'vitest';
 import { readFile } from 'fs-extra';
 import mockFs from 'mock-fs';
 import { stdin } from 'mock-stdin';
@@ -32,6 +32,7 @@ const waitFor = async (callback: () => void) => {
       } catch (error) {
         if (timeout <= 0) {
           clearInterval(intervalId);
+          // eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors
           reject(error);
         }
 
@@ -64,13 +65,15 @@ afterEach(() => {
 });
 
 test('initializes the configuration', async () => {
-  vi.spyOn(process.stdout, 'write').mockImplementation(() => true);
+  const writeMock = vi
+    .spyOn(process.stdout, 'write')
+    .mockImplementation(() => true);
 
   process.chdir(root);
 
   const run = async () => {
     await waitFor(() => {
-      const lastCall = (process.stdout.write as Mock).mock.lastCall;
+      const lastCall = writeMock.mock.lastCall;
 
       if (lastCall == null) {
         throw new Error('No output');
@@ -81,44 +84,44 @@ test('initializes the configuration', async () => {
       }
     });
 
-    await waitFor(() =>
-      expect(process.stdout.write).toHaveBeenLastCalledWith(
+    await waitFor(() => {
+      expect(writeMock).toHaveBeenLastCalledWith(
         expect.stringMatching('Where are your source files?')
-      )
-    );
+      );
+    });
 
     io?.send(enter);
 
-    await waitFor(() =>
-      expect(process.stdout.write).toHaveBeenLastCalledWith(
+    await waitFor(() => {
+      expect(writeMock).toHaveBeenLastCalledWith(
         expect.stringMatching('Where do you want to generate the output files?')
-      )
-    );
+      );
+    });
 
     io?.send(enter);
 
-    await waitFor(() =>
-      expect(process.stdout.write).toHaveBeenLastCalledWith(
+    await waitFor(() => {
+      expect(writeMock).toHaveBeenLastCalledWith(
         expect.stringMatching('Which targets do you want to build?')
-      )
-    );
+      );
+    });
 
     io?.send(enter);
 
-    await waitFor(() =>
-      expect(process.stdout.write).toHaveBeenLastCalledWith(
+    await waitFor(() => {
+      expect(writeMock).toHaveBeenLastCalledWith(
         expect.stringMatching(
           "You have enabled 'typescript' compilation, but we couldn't find a 'tsconfig.json' in project root"
         )
-      )
-    );
+      );
+    });
 
     io?.send(enter);
   };
 
   await Promise.all([run(), init()]);
 
-  expect(process.stdout.write).toHaveBeenLastCalledWith(
+  expect(writeMock).toHaveBeenLastCalledWith(
     expect.stringMatching('configured successfully!')
   );