fix: add additional check for codegenNativeComponent

satya164 · satya164 · commit cc933964f138 · 2025-05-05T12:08:16.000+02:00
see #625 (comment)
diff --git a/packages/react-native-builder-bob/src/__fixtures__/project/MyNativeComponent.js b/packages/react-native-builder-bob/src/__fixtures__/project/MyNativeComponent.js
@@ -0,0 +1,2 @@
+export default codegenNativeComponent<NativeProps>('Test');
+export default codegenNativeComponent<NativeProps>('Test');
diff --git a/packages/react-native-builder-bob/src/__fixtures__/project/MyNativeComponent.jsx b/packages/react-native-builder-bob/src/__fixtures__/project/MyNativeComponent.jsx
@@ -0,0 +1 @@
+export default codegenNativeComponent<NativeProps>('Test');
diff --git a/packages/react-native-builder-bob/src/__fixtures__/project/MyNativeComponent.ts b/packages/react-native-builder-bob/src/__fixtures__/project/MyNativeComponent.ts
@@ -0,0 +1 @@
+export default codegenNativeComponent<NativeProps>('Test');
diff --git a/packages/react-native-builder-bob/src/__fixtures__/project/MyNativeComponent.tsx b/packages/react-native-builder-bob/src/__fixtures__/project/MyNativeComponent.tsx
@@ -0,0 +1 @@
+export default codegenNativeComponent<NativeProps>('Test');
diff --git a/packages/react-native-builder-bob/src/__fixtures__/project/code/$exports-output.ts b/packages/react-native-builder-bob/src/__fixtures__/project/code/$exports-output.ts
@@ -13,12 +13,12 @@ export type { A } from "./a";
 export const foo = "foo";
 const bar = "bar";
 export { bar };
-export * as NativeLibA from "./NativeMyLib";
-export * as NativeLibB from "../NativeMyLib";
-export * as NativeLibC from "./NativeMyLib.ts";
-export * as NativeLibD from "../NativeMyLib.ts";
-export * as NativeLibE from "./NativeMyLib.tsx";
-export * as NativeLibF from "../NativeMyLib.tsx";
+export * as NativeLibA from "./NativeMyLib.mjs";
+export * as NativeLibB from "../NativeMyLib.mjs";
+export * as NativeLibC from "./NativeMyLib.mjs";
+export * as NativeLibD from "../NativeMyLib.mjs";
+export * as NativeLibE from "./NativeMyLib.mjs";
+export * as NativeLibF from "../NativeMyLib.mjs";
 export * as NativeLibG from "./NativeMyLib.js";
 export * as NativeLibH from "../NativeMyLib.js";
 export * as NativeLibI from "./NativeMyLib.jsx";
diff --git a/packages/react-native-builder-bob/src/__fixtures__/project/code/$imports-output.ts b/packages/react-native-builder-bob/src/__fixtures__/project/code/$imports-output.ts
@@ -12,12 +12,12 @@ import { a as a1 } from "./a.mjs";
 import * as b1 from "./b.mjs";
 import something, { c as c1 } from "./c.mjs";
 import type { A } from "./a";
-import "./NativeMyLib";
-import "../NativeMyLib";
-import "./NativeMyLib.ts";
-import "../NativeMyLib.ts";
-import "./NativeMyLib.tsx";
-import "../NativeMyLib.tsx";
+import "./NativeMyLib.mjs";
+import "../NativeMyLib.mjs";
+import "./NativeMyLib.mjs";
+import "../NativeMyLib.mjs";
+import "./NativeMyLib.mjs";
+import "../NativeMyLib.mjs";
 import "./NativeMyLib.js";
 import "../NativeMyLib.js";
 import "./NativeMyLib.jsx";
diff --git a/packages/react-native-builder-bob/src/__fixtures__/project/code/MyNativeComponent.js b/packages/react-native-builder-bob/src/__fixtures__/project/code/MyNativeComponent.js
@@ -0,0 +1 @@
+export default codegenNativeComponent<NativeProps>('Test');
diff --git a/packages/react-native-builder-bob/src/__fixtures__/project/code/MyNativeComponent.jsx b/packages/react-native-builder-bob/src/__fixtures__/project/code/MyNativeComponent.jsx
@@ -0,0 +1 @@
+export default codegenNativeComponent<NativeProps>('Test');
diff --git a/packages/react-native-builder-bob/src/__fixtures__/project/code/MyNativeComponent.ts b/packages/react-native-builder-bob/src/__fixtures__/project/code/MyNativeComponent.ts
@@ -0,0 +1 @@
+export default codegenNativeComponent<NativeProps>('Test');
diff --git a/packages/react-native-builder-bob/src/__fixtures__/project/code/MyNativeComponent.tsx b/packages/react-native-builder-bob/src/__fixtures__/project/code/MyNativeComponent.tsx
@@ -0,0 +1 @@
+export default codegenNativeComponent<NativeProps>('Test');
diff --git a/packages/react-native-builder-bob/src/utils/isCodegenSpec.ts b/packages/react-native-builder-bob/src/utils/isCodegenSpec.ts
@@ -1,5 +1,18 @@
-export const isCodegenSpec = (filepath: string) => {
-  return /(?:^|[\\/])(?:Native\w+|(\w+)NativeComponent)\.[jt]sx?$/i.test(
-    filepath
-  );
-};
+import fs from 'fs-extra';
+
+export function isCodegenSpec(filepath: string): boolean {
+  const looksLikeCodgenSpec =
+    /(?:^|[\\/])(?:(\w+)NativeComponent)\.[jt]sx?$/i.test(filepath);
+
+  if (looksLikeCodgenSpec) {
+    // This is used in the babel plugin so needs to be synchronous
+    const content = fs.readFileSync(filepath, 'utf8');
+
+    // Regex taken from https://github.com/facebook/react-native/blob/271232d85654cee32322b1c8a3a39ef647ad02e2/packages/react-native-babel-preset/src/configs/main.js#L78C24-L78C47
+    if (/\bcodegenNativeComponent</.test(content)) {
+      return true;
+    }
+  }
+
+  return false;
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+export default codegenNativeComponent<NativeProps>('Test');`
	`2`	`+export default codegenNativeComponent<NativeProps>('Test');`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export default codegenNativeComponent<NativeProps>('Test');`