Skip to content

Commit 148fda0

Browse files
authored
fix: podspec file indentation (#530)
<!-- Please provide enough information so that others can review your pull request. --> <!-- Keep pull requests small and focused on a single change. --> ### Summary <!-- What existing problem does the pull request solve? Can you solve the issue with a different approach? --> After #358 identation become shifted which makes code hard to read and could lead to bugs. For example I was placing package dependencies inside `if/else` block, right after `s.dependency "React-Core"` see | before | after | |--------|--------| | <img width="1624" alt="image" src="https://github.com/callstack/react-native-builder-bob/assets/1577804/65a6b479-3e76-4170-b874-b5635b6a5401"> | <img width="1624" alt="image" src="https://github.com/callstack/react-native-builder-bob/assets/1577804/5e3862e7-e6d9-48da-9efd-5c3e5f611749"> | ### Test plan <!-- List the steps with which we can test this change. Provide screenshots if this changes anything visual. --> Purely aesthetic changes, so nothing to break
1 parent aa4d723 commit 148fda0

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

packages/create-react-native-library/templates/native-common/{%- project.identifier %}.podspec

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -27,24 +27,24 @@ Pod::Spec.new do |s|
2727
if respond_to?(:install_modules_dependencies, true)
2828
install_modules_dependencies(s)
2929
else
30-
s.dependency "React-Core"
30+
s.dependency "React-Core"
3131
32-
# Don't install the dependencies when we run `pod install` in the old architecture.
33-
if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
34-
s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
35-
s.pod_target_xcconfig = {
36-
"HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\"",
37-
"OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
38-
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
39-
}
32+
# Don't install the dependencies when we run `pod install` in the old architecture.
33+
if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
34+
s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
35+
s.pod_target_xcconfig = {
36+
"HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\"",
37+
"OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
38+
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
39+
}
4040
<% if (project.view) { -%>
41-
s.dependency "React-RCTFabric"
41+
s.dependency "React-RCTFabric"
4242
<% } -%>
43-
s.dependency "React-Codegen"
44-
s.dependency "RCT-Folly"
45-
s.dependency "RCTRequired"
46-
s.dependency "RCTTypeSafety"
47-
s.dependency "ReactCommon/turbomodule/core"
48-
end
49-
end
43+
s.dependency "React-Codegen"
44+
s.dependency "RCT-Folly"
45+
s.dependency "RCTRequired"
46+
s.dependency "RCTTypeSafety"
47+
s.dependency "ReactCommon/turbomodule/core"
48+
end
49+
end
5050
end

0 commit comments

Comments
 (0)