Merge pull request #67 from cake-contrib/feature/test-improvement

Add missing tests for IIssueExtension

Author: pascalberger

src/Cake.Issues.Reporting.Generic.Tests/IIssueExtensionTests.cs

@@ -105,5 +105,105 @@ public void Should_Return_Null_If_File_Is_Not_Set()
                 result.ShouldBeNull();
             }
         }
+
+        public sealed class TheFileDirectoryExtension
+        {
+            [Fact]
+            public void Should_Throw_If_Issue_Is_Null()
+            {
+                // Given
+                IIssue issue = null;
+
+                // When
+                var result = Record.Exception(() => issue.FileDirectory());
+
+                // Then
+                result.IsArgumentNullException("issue");
+            }
+
+            [Fact]
+            public void Should_Return_Full_Path()
+            {
+                // Given
+                var filePath = @"src\Cake.Issues.Reporting.Generic.Tests\Foo.cs";
+                var issue =
+                    IssueBuilder
+                        .NewIssue("Message Foo", "ProviderType Foo", "ProviderName Foo")
+                        .InFile(filePath)
+                        .Create();
+
+                // When
+                var result = issue.FileDirectory();
+
+                // Then
+                result.ShouldBe(@"src/Cake.Issues.Reporting.Generic.Tests");
+            }
+
+            [Fact]
+            public void Should_Return_Null_If_File_Is_Not_Set()
+            {
+                // Given
+                var issue =
+                    IssueBuilder
+                        .NewIssue("Message Foo", "ProviderType Foo", "ProviderName Foo")
+                        .Create();
+
+                // When
+                var result = issue.FileDirectory();
+
+                // Then
+                result.ShouldBeNull();
+            }
+        }
+
+        public sealed class TheFileNameExtension
+        {
+            [Fact]
+            public void Should_Throw_If_Issue_Is_Null()
+            {
+                // Given
+                IIssue issue = null;
+
+                // When
+                var result = Record.Exception(() => issue.FileName());
+
+                // Then
+                result.IsArgumentNullException("issue");
+            }
+
+            [Fact]
+            public void Should_Return_Full_Path()
+            {
+                // Given
+                var filePath = @"src\Cake.Issues.Reporting.Generic.Tests\Foo.cs";
+                var issue =
+                    IssueBuilder
+                        .NewIssue("Message Foo", "ProviderType Foo", "ProviderName Foo")
+                        .InFile(filePath)
+                        .Create();
+
+                // When
+                var result = issue.FileName();
+
+                // Then
+                result.ShouldBe("Foo.cs");
+            }
+
+            [Fact]
+            public void Should_Return_Null_If_File_Is_Not_Set()
+            {
+                // Given
+                var issue =
+                    IssueBuilder
+                        .NewIssue("Message Foo", "ProviderType Foo", "ProviderName Foo")
+                        .Create();
+
+                // When
+                var result = issue.FileName();
+
+                // Then
+                result.ShouldBeNull();
+            }
+        }
     }
 }

src/Cake.Issues.Reporting.Generic/IIssueExtension.cs

@@ -38,6 +38,8 @@ public static string FilePath(this IIssue issue)
         /// <returns>Directory of the file affected by the issue.</returns>
         public static string FileDirectory(this IIssue issue)
         {
+            issue.NotNull(nameof(issue));
+
             return issue.AffectedFileRelativePath?.GetDirectory().FullPath;
         }
 
@@ -48,6 +50,8 @@ public static string FileDirectory(this IIssue issue)
         /// <returns>Name of the file affected by the issue.</returns>
         public static string FileName(this IIssue issue)
         {
+            issue.NotNull(nameof(issue));
+
             return issue.AffectedFileRelativePath?.GetFilename().ToString();
         }
     }