(GH-278) Add support for column information (#330)

* (GH-278) Add column information to HtmlDiagnostic template

* (GH-278) Add column information to HtmlDxDataGrid template

Author: pascalberger

src/Cake.Issues.Reporting.Generic.Tests/ExpandoObjectExtensionsTests.cs

@@ -41,7 +41,7 @@ public void Should_Give_Correct_Result()
                 var result = expandoObject.SerializeToJsonString();
 
                 // Then
-                result.ShouldBe("{\"ProviderType\":\"providerType\",\"ProviderName\":\"providerName\",\"Run\":null,\"Priority\":null,\"PriorityName\":null,\"ProjectPath\":null,\"ProjectName\":null,\"FilePath\":null,\"FileDirectory\":null,\"FileName\":null,\"FileLink\":null,\"Line\":null,\"EndLine\":null,\"Location\":\"\",\"Rule\":null,\"RuleUrl\":null,\"MessageText\":\"message\"}");
+                result.ShouldBe("{\"ProviderType\":\"providerType\",\"ProviderName\":\"providerName\",\"Run\":null,\"Priority\":null,\"PriorityName\":null,\"ProjectPath\":null,\"ProjectName\":null,\"FilePath\":null,\"FileDirectory\":null,\"FileName\":null,\"FileLink\":null,\"Line\":null,\"EndLine\":null,\"Column\":null,\"EndColumn\":null,\"Location\":\"\",\"Rule\":null,\"RuleUrl\":null,\"MessageText\":\"message\"}");
             }
         }
 
@@ -81,7 +81,7 @@ public void Should_Give_Correct_Result()
                 var result = expandoObjects.SerializeToJsonString();
 
                 // Then
-                result.ShouldBe("[{\"ProviderType\":\"providerType1\",\"ProviderName\":\"providerName1\",\"Run\":null,\"Priority\":null,\"PriorityName\":null,\"ProjectPath\":null,\"ProjectName\":null,\"FilePath\":null,\"FileDirectory\":null,\"FileName\":null,\"FileLink\":null,\"Line\":null,\"EndLine\":null,\"Location\":\"\",\"Rule\":null,\"RuleUrl\":null,\"MessageText\":\"message1\"},{\"ProviderType\":\"providerType1\",\"ProviderName\":\"providerName1\",\"Run\":null,\"Priority\":null,\"PriorityName\":null,\"ProjectPath\":null,\"ProjectName\":null,\"FilePath\":null,\"FileDirectory\":null,\"FileName\":null,\"FileLink\":null,\"Line\":null,\"EndLine\":null,\"Location\":\"\",\"Rule\":null,\"RuleUrl\":null,\"MessageText\":\"message1\"}]");
+                result.ShouldBe("[{\"ProviderType\":\"providerType1\",\"ProviderName\":\"providerName1\",\"Run\":null,\"Priority\":null,\"PriorityName\":null,\"ProjectPath\":null,\"ProjectName\":null,\"FilePath\":null,\"FileDirectory\":null,\"FileName\":null,\"FileLink\":null,\"Line\":null,\"EndLine\":null,\"Column\":null,\"EndColumn\":null,\"Location\":\"\",\"Rule\":null,\"RuleUrl\":null,\"MessageText\":\"message1\"},{\"ProviderType\":\"providerType1\",\"ProviderName\":\"providerName1\",\"Run\":null,\"Priority\":null,\"PriorityName\":null,\"ProjectPath\":null,\"ProjectName\":null,\"FilePath\":null,\"FileDirectory\":null,\"FileName\":null,\"FileLink\":null,\"Line\":null,\"EndLine\":null,\"Column\":null,\"EndColumn\":null,\"Location\":\"\",\"Rule\":null,\"RuleUrl\":null,\"MessageText\":\"message1\"}]");
             }
         }
     }

src/Cake.Issues.Reporting.Generic.Tests/IIssueExtensionsTests.cs

@@ -446,6 +446,84 @@ public void Should_Not_Set_EndLine_If_Flag_Is_Not_Set()
                 result.IsRuntimeBinderException("'System.Dynamic.ExpandoObject' does not contain a definition for 'EndLine'");
             }
 
+            [Fact]
+            public void Should_Set_Column_If_Flag_Is_Set()
+            {
+                // Given
+                var filePath = @"src\Cake.Issues.Reporting.Generic.Tests\Foo.cs";
+                var line = 23;
+                var endLine = 42;
+                var column = 5;
+                var endColumn = 10;
+                var issue =
+                    IssueBuilder
+                        .NewIssue("Message Foo", "ProviderType Foo", "ProviderName Foo")
+                        .InFile(filePath, line, endLine, column, endColumn)
+                        .Create();
+
+                // When
+                dynamic result = issue.GetExpandoObject(addColumn: true);
+
+                // Then
+                Assert.Equal(result.Column, column);
+            }
+
+            [Fact]
+            public void Should_Not_Set_Column_If_Flag_Is_Not_Set()
+            {
+                // Given
+                var issue =
+                    IssueBuilder
+                        .NewIssue("Message Foo", "ProviderType Foo", "ProviderName Foo")
+                        .Create();
+
+                // When
+                dynamic expando = issue.GetExpandoObject(addColumn: false);
+                var result = Record.Exception(() => expando.Column);
+
+                // Then
+                result.IsRuntimeBinderException("'System.Dynamic.ExpandoObject' does not contain a definition for 'Column'");
+            }
+
+            [Fact]
+            public void Should_Set_EndColumn_If_Flag_Is_Set()
+            {
+                // Given
+                var filePath = @"src\Cake.Issues.Reporting.Generic.Tests\Foo.cs";
+                var line = 23;
+                var endLine = 42;
+                var column = 5;
+                var endColumn = 10;
+                var issue =
+                    IssueBuilder
+                        .NewIssue("Message Foo", "ProviderType Foo", "ProviderName Foo")
+                        .InFile(filePath, line, endLine, column, endColumn)
+                        .Create();
+
+                // When
+                dynamic result = issue.GetExpandoObject(addEndColumn: true);
+
+                // Then
+                Assert.Equal(result.EndColumn, endColumn);
+            }
+
+            [Fact]
+            public void Should_Not_Set_EndColumn_If_Flag_Is_Not_Set()
+            {
+                // Given
+                var issue =
+                    IssueBuilder
+                        .NewIssue("Message Foo", "ProviderType Foo", "ProviderName Foo")
+                        .Create();
+
+                // When
+                dynamic expando = issue.GetExpandoObject(addEndColumn: false);
+                var result = Record.Exception(() => expando.EndColumn);
+
+                // Then
+                result.IsRuntimeBinderException("'System.Dynamic.ExpandoObject' does not contain a definition for 'EndColumn'");
+            }
+
             [Fact]
             public void Should_Set_Location_If_Flag_Is_Set()
             {