Skip to content
This repository was archived by the owner on Apr 6, 2024. It is now read-only.

Commit 773a391

Browse files
authored
Merge pull request #308 from cake-contrib/dependabot/nuget/src/Cake.Issues-0.9.0-beta0004
Bump Cake.Issues from 0.9.0-beta0002 to 0.9.0-beta0004 in /src
2 parents f73c6fd + 4cbf435 commit 773a391

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

src/Cake.Issues.Reporting.Generic.Tests/Cake.Issues.Reporting.Generic.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
3131
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
3232
<PackageReference Include="Cake.Testing" Version="0.33.0" />
33-
<PackageReference Include="Cake.Issues.Testing" Version="0.9.0-beta0002" />
33+
<PackageReference Include="Cake.Issues.Testing" Version="0.9.0-beta0004" />
3434
<PackageReference Include="HtmlAgilityPack" Version="1.11.24" />
3535
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0">
3636
<PrivateAssets>all</PrivateAssets>

src/Cake.Issues.Reporting.Generic/Cake.Issues.Reporting.Generic.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
<PackageReference Include="Gazorator" Version="0.5.2" />
2828
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
2929
<PackageReference Include="Cake.Core" Version="0.33.0" />
30-
<PackageReference Include="Cake.Issues" Version="0.9.0-beta0002" />
31-
<PackageReference Include="Cake.Issues.Reporting" Version="0.9.0-beta0001" />
30+
<PackageReference Include="Cake.Issues" Version="0.9.0-beta0004" />
31+
<PackageReference Include="Cake.Issues.Reporting" Version="0.9.0-beta0002" />
3232
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers">
3333
<PrivateAssets>all</PrivateAssets>
3434
<Version>3.0.0</Version>

src/Cake.Issues.Reporting.Generic/IIssueExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,9 @@ public static ExpandoObject GetExpandoObject(
141141
fallbackToTextMessageIfMarkdownMessageNotAvailable ? issue.Message(IssueCommentFormat.Markdown) : issue.MessageMarkdown;
142142
}
143143

144-
if (fileLinkSettings != null && !string.IsNullOrEmpty(fileLinkSettings.FileLinkPattern))
144+
if (fileLinkSettings != null)
145145
{
146-
result.FileLink = fileLinkSettings.FileLinkPattern.ReplaceIssuePattern(issue);
146+
result.FileLink = fileLinkSettings.GetFileLink(issue);
147147
}
148148

149149
if (additionalValues != null)

src/Cake.Issues.Reporting.Generic/Templates/DxDataGrid.cshtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
ColumnSortOrder messageSortOrder = ViewBagHelper.ValueOrDefault(ViewBag.MessageSortOder, ColumnSortOrder.Ascending);
4747
var groupedColumns = ViewBagHelper.ValueOrDefault(ViewBag.GroupedColumns, new List<ReportColumn> { ReportColumn.ProviderName });
4848
var sortedColumns = ViewBagHelper.ValueOrDefault(ViewBag.SortedColumns, new List<ReportColumn> { ReportColumn.PriorityName, ReportColumn.ProjectName, ReportColumn.FileDirectory, ReportColumn.FileName, ReportColumn.Line });
49-
FileLinkSettings fileLinkSettings = ViewBagHelper.ValueOrDefault(ViewBag.FileLinkSettings, new FileLinkSettings());
49+
FileLinkSettings fileLinkSettings = ViewBagHelper.ValueOrDefault<FileLinkSettings>(ViewBag.FileLinkSettings, null);
5050
IdeIntegrationSettings ideIntegrationSettings = ViewBagHelper.ValueOrDefault<IdeIntegrationSettings>(ViewBag.IdeIntegrationSettings, null);
5151
List<HtmlDxDataGridColumnDescription> additionalColumns = ViewBagHelper.ValueOrDefault(ViewBag.AdditionalColumns, new List<HtmlDxDataGridColumnDescription>());
5252
string jQueryLocation = ViewBagHelper.ValueOrDefault(ViewBag.JQueryLocation, "https://ajax.aspnetcdn.com/ajax/jquery/").Trim();
@@ -417,7 +417,7 @@
417417
@:sortIndex: @sortedColumns.IndexOf(ReportColumn.Line),
418418
@:sortOrder: "@lineSortOrder.ToShortString()",
419419
}
420-
@if (fileLinkSettings != null && !string.IsNullOrWhiteSpace(fileLinkSettings.FileLinkPattern))
420+
@if (fileLinkSettings != null)
421421
{
422422
<text>
423423
cellTemplate: function (container, options) {

0 commit comments

Comments
 (0)