Skip to content

Commit 8254720

Browse files
pascalbergerpascalberger
committed
Merge branch 'release/5.0.0'
2 parents 32bad20 + b057aa6 commit 8254720

File tree

96 files changed

+3319
-3930
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

96 files changed

+3319
-3930
lines changed

‎.appveyor.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@ install:
1111
- ps: mkdir $env:DOTNET_INSTALL_DIR -Force | Out-Null
1212
- ps: Invoke-WebRequest -Uri "https://dotnet.microsoft.com/download/dotnet/scripts/v1/dotnet-install.ps1" -OutFile "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1"
1313
- ps: '& "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1" -Version 5.0.408 -InstallDir $env:DOTNET_INSTALL_DIR'
14-
- ps: '& "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1" -Version 6.0.411 -InstallDir $env:DOTNET_INSTALL_DIR'
15-
- ps: '& "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1" -Version 7.0.305 -InstallDir $env:DOTNET_INSTALL_DIR'
16-
- ps: '& "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1" -Version 8.0.100 -InstallDir $env:DOTNET_INSTALL_DIR'
14+
- ps: '& "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1" -Version 8.0.404 -InstallDir $env:DOTNET_INSTALL_DIR'
15+
- ps: '& "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1" -Version 9.0.100 -InstallDir $env:DOTNET_INSTALL_DIR'
1716
- ps: $env:Path = "$env:DOTNET_INSTALL_DIR;$env:Path"
1817
- ps: dotnet --info
1918
- ps: Install-Product node 20

‎.github/workflows/build.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,8 @@ jobs:
1616
# .NET 5 required for GitVersion
1717
dotnet-version: |
1818
5.x
19-
6.x
20-
7.x
2119
8.x
20+
9.x
2221
- name: Build
2322
run: .\build.ps1
2423
shell: powershell
@@ -27,9 +26,9 @@ jobs:
2726
with:
2827
name: NuGet Package
2928
path: ./BuildArtifacts/Packages/NuGet/
30-
# Integration Tests Script Runner Windows (.NET Core tool)
31-
Test_Windows_DotNetCoreTool:
32-
name: Integration Tests Script Runner Windows (.NET Core tool)
29+
# Integration Tests Script Runner Windows (.NET tool)
30+
Test_Windows_DotNetTool:
31+
name: Integration Tests Script Runner Windows (.NET tool)
3332
needs: Build
3433
runs-on: windows-2019
3534
steps:
@@ -47,13 +46,13 @@ jobs:
4746
uses: actions/setup-dotnet@3e891b0cb619bf60e2c25674b222b8940e2c1c25 # v4
4847
with:
4948
dotnet-version: |
50-
6.x
49+
8.x
5150
- name: Run integration tests
5251
run: ./build.ps1 --verbosity=diagnostic
5352
working-directory: ./tests/script-runner/
5453
shell: powershell
5554
- name: Publish generated reports as build artifact
5655
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4
5756
with:
58-
name: Integration Tests Script Runner Windows (.NET Core tool)
57+
name: Integration Tests Script Runner Windows (.NET tool)
5958
path: ./tests/script-runner/BuildArtifacts/output/

‎Cake.Frosting.Issues.Recipe/.editorconfig

Lines changed: 231 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,231 @@
1+
root = true
2+
# Remove the line below if you want to inherit .editorconfig settings from higher directories
3+
4+
# C# files
5+
[*.cs]
6+
7+
#### Core EditorConfig Options ####
8+
9+
# Indentation and spacing
10+
indent_size = 4
11+
indent_style = space
12+
tab_width = 4
13+
14+
# New line preferences
15+
end_of_line = crlf
16+
insert_final_newline = false
17+
18+
#### .NET Coding Conventions ####
19+
20+
# Organize usings
21+
dotnet_separate_import_directive_groups = false
22+
dotnet_sort_system_directives_first = true
23+
file_header_template =
24+
25+
# this. and Me. preferences
26+
dotnet_style_qualification_for_event = true
27+
dotnet_style_qualification_for_field = true
28+
dotnet_style_qualification_for_method = true
29+
dotnet_style_qualification_for_property = true
30+
31+
# Language keywords vs BCL types preferences
32+
dotnet_style_predefined_type_for_locals_parameters_members = true
33+
dotnet_style_predefined_type_for_member_access = true
34+
35+
# Parentheses preferences
36+
dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity
37+
dotnet_style_parentheses_in_other_binary_operators = always_for_clarity
38+
dotnet_style_parentheses_in_other_operators = never_if_unnecessary
39+
dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity
40+
41+
# Modifier preferences
42+
dotnet_style_require_accessibility_modifiers = for_non_interface_members
43+
44+
# Expression-level preferences
45+
dotnet_style_coalesce_expression = true
46+
dotnet_style_collection_initializer = true
47+
dotnet_style_explicit_tuple_names = true
48+
dotnet_style_namespace_match_folder = false # Everything is in the same namespace
49+
dotnet_style_null_propagation = true
50+
dotnet_style_object_initializer = true
51+
dotnet_style_operator_placement_when_wrapping = beginning_of_line
52+
dotnet_style_prefer_auto_properties = true
53+
dotnet_style_prefer_compound_assignment = true
54+
dotnet_style_prefer_conditional_expression_over_assignment = true
55+
dotnet_style_prefer_conditional_expression_over_return = true
56+
dotnet_style_prefer_foreach_explicit_cast_in_source = when_strongly_typed
57+
dotnet_style_prefer_inferred_anonymous_type_member_names = true
58+
dotnet_style_prefer_inferred_tuple_names = true
59+
dotnet_style_prefer_is_null_check_over_reference_equality_method = true
60+
dotnet_style_prefer_simplified_boolean_expressions = true
61+
dotnet_style_prefer_simplified_interpolation = true
62+
63+
# Field preferences
64+
dotnet_style_readonly_field = true
65+
66+
# Parameter preferences
67+
dotnet_code_quality_unused_parameters = all
68+
69+
# Suppression preferences
70+
dotnet_remove_unnecessary_suppression_exclusions = 0
71+
72+
# New line preferences
73+
dotnet_style_allow_multiple_blank_lines_experimental = true
74+
dotnet_style_allow_statement_immediately_after_block_experimental = true
75+
76+
#### C# Coding Conventions ####
77+
78+
# var preferences
79+
csharp_style_var_elsewhere = true:warning
80+
csharp_style_var_for_built_in_types = true:warning
81+
csharp_style_var_when_type_is_apparent = true:warning
82+
83+
# Expression-bodied members
84+
csharp_style_expression_bodied_accessors = true
85+
csharp_style_expression_bodied_constructors = false
86+
csharp_style_expression_bodied_indexers = true
87+
csharp_style_expression_bodied_lambdas = true
88+
csharp_style_expression_bodied_local_functions = true
89+
csharp_style_expression_bodied_methods = true
90+
csharp_style_expression_bodied_operators = true
91+
csharp_style_expression_bodied_properties = true
92+
93+
# Pattern matching preferences
94+
csharp_style_pattern_matching_over_as_with_null_check = true
95+
csharp_style_pattern_matching_over_is_with_cast_check = true
96+
csharp_style_prefer_extended_property_pattern = true
97+
csharp_style_prefer_not_pattern = true
98+
csharp_style_prefer_pattern_matching = true
99+
csharp_style_prefer_switch_expression = true
100+
101+
# Null-checking preferences
102+
csharp_style_conditional_delegate_call = true
103+
104+
# Modifier preferences
105+
csharp_prefer_static_local_function = true
106+
csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async
107+
csharp_style_prefer_readonly_struct = true
108+
109+
# Code-block preferences
110+
csharp_prefer_braces = true
111+
csharp_prefer_simple_using_statement = false
112+
csharp_style_namespace_declarations = file_scoped
113+
csharp_style_prefer_method_group_conversion = true
114+
csharp_style_prefer_top_level_statements = true
115+
116+
# Expression-level preferences
117+
csharp_prefer_simple_default_expression = true
118+
csharp_style_deconstructed_variable_declaration = true
119+
csharp_style_implicit_object_creation_when_type_is_apparent = true
120+
csharp_style_inlined_variable_declaration = true
121+
csharp_style_prefer_index_operator = true
122+
csharp_style_prefer_local_over_anonymous_function = true
123+
csharp_style_prefer_null_check_over_type_check = true
124+
csharp_style_prefer_range_operator = true
125+
csharp_style_prefer_tuple_swap = true
126+
csharp_style_prefer_utf8_string_literals = true
127+
csharp_style_throw_expression = true
128+
csharp_style_unused_value_assignment_preference = discard_variable
129+
csharp_style_unused_value_expression_statement_preference = discard_variable
130+
131+
# 'using' directive preferences
132+
csharp_using_directive_placement = inside_namespace:error
133+
134+
# New line preferences
135+
csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = true
136+
csharp_style_allow_blank_lines_between_consecutive_braces_experimental = true
137+
csharp_style_allow_embedded_statements_on_same_line_experimental = true
138+
139+
#### C# Formatting Rules ####
140+
141+
# New line preferences
142+
csharp_new_line_before_catch = true
143+
csharp_new_line_before_else = true
144+
csharp_new_line_before_finally = true
145+
csharp_new_line_before_members_in_anonymous_types = true
146+
csharp_new_line_before_members_in_object_initializers = true
147+
csharp_new_line_before_open_brace = all
148+
csharp_new_line_between_query_expression_clauses = true
149+
150+
# Indentation preferences
151+
csharp_indent_block_contents = true
152+
csharp_indent_braces = false
153+
csharp_indent_case_contents = true
154+
csharp_indent_case_contents_when_block = true
155+
csharp_indent_labels = no_change
156+
csharp_indent_switch_labels = true
157+
158+
# Space preferences
159+
csharp_space_after_cast = false
160+
csharp_space_after_colon_in_inheritance_clause = true
161+
csharp_space_after_comma = true
162+
csharp_space_after_dot = false
163+
csharp_space_after_keywords_in_control_flow_statements = true
164+
csharp_space_after_semicolon_in_for_statement = true
165+
csharp_space_around_binary_operators = before_and_after
166+
csharp_space_around_declaration_statements = false
167+
csharp_space_before_colon_in_inheritance_clause = true
168+
csharp_space_before_comma = false
169+
csharp_space_before_dot = false
170+
csharp_space_before_open_square_brackets = false
171+
csharp_space_before_semicolon_in_for_statement = false
172+
csharp_space_between_empty_square_brackets = false
173+
csharp_space_between_method_call_empty_parameter_list_parentheses = false
174+
csharp_space_between_method_call_name_and_opening_parenthesis = false
175+
csharp_space_between_method_call_parameter_list_parentheses = false
176+
csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
177+
csharp_space_between_method_declaration_name_and_open_parenthesis = false
178+
csharp_space_between_method_declaration_parameter_list_parentheses = false
179+
csharp_space_between_parentheses = false
180+
csharp_space_between_square_brackets = false
181+
182+
# Wrapping preferences
183+
csharp_preserve_single_line_blocks = true
184+
csharp_preserve_single_line_statements = true
185+
186+
#### Naming styles ####
187+
188+
# Naming rules
189+
190+
dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
191+
dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
192+
dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
193+
194+
dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
195+
dotnet_naming_rule.types_should_be_pascal_case.symbols = types
196+
dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
197+
198+
dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
199+
dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
200+
dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
201+
202+
# Symbol specifications
203+
204+
dotnet_naming_symbols.interface.applicable_kinds = interface
205+
dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
206+
dotnet_naming_symbols.interface.required_modifiers =
207+
208+
dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
209+
dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
210+
dotnet_naming_symbols.types.required_modifiers =
211+
212+
dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
213+
dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
214+
dotnet_naming_symbols.non_field_members.required_modifiers =
215+
216+
# Naming styles
217+
218+
dotnet_naming_style.pascal_case.required_prefix =
219+
dotnet_naming_style.pascal_case.required_suffix =
220+
dotnet_naming_style.pascal_case.word_separator =
221+
dotnet_naming_style.pascal_case.capitalization = pascal_case
222+
223+
dotnet_naming_style.begins_with_i.required_prefix = I
224+
dotnet_naming_style.begins_with_i.required_suffix =
225+
dotnet_naming_style.begins_with_i.word_separator =
226+
dotnet_naming_style.begins_with_i.capitalization = pascal_case
227+
228+
#### Analyzer configuration ####
229+
230+
# Escalate 'Style' / IDE diagnostics to warnings to have them enabled in CLI builds
231+
dotnet_analyzer_diagnostic.category-Style.severity = warning

‎Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe.Tests/Cake.Frosting.Issues.Recipe.Tests.csproj

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
4+
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
55
<LangVersion>latest</LangVersion>
66
<GenerateDocumentationFile>true</GenerateDocumentationFile>
77
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
@@ -17,15 +17,15 @@
1717
</PropertyGroup>
1818

1919
<ItemGroup>
20-
<PackageReference Include="Cake.Frosting" Version="4.0.0" />
21-
<PackageReference Include="Cake.Issues.Testing" Version="4.12.0" />
22-
<PackageReference Include="Cake.Testing" Version="4.0.0" />
23-
<PackageReference Include="Cake.Testing.Xunit" Version="4.0.0" />
24-
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0">
20+
<PackageReference Include="Cake.Frosting" Version="5.0.0" />
21+
<PackageReference Include="Cake.Issues.Testing" Version="5.0.0" />
22+
<PackageReference Include="Cake.Testing" Version="5.0.0" />
23+
<PackageReference Include="Cake.Testing.Xunit" Version="5.0.0" />
24+
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="9.0.0">
2525
<PrivateAssets>all</PrivateAssets>
2626
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2727
</PackageReference>
28-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
28+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
2929
<PackageReference Include="xunit" Version="2.9.2" />
3030
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
3131
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>

‎Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe.Tests/FakeIssueProvider2.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
/// </summary>
99
internal class FakeIssueProvider2 : FakeIssueProvider
1010
{
11-
private readonly List<IIssue> issues = [];
1211

1312
/// <summary>
1413
/// Initializes a new instance of the <see cref="FakeIssueProvider2"/> class.

‎Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe.Tests/PullRequestSystems/PullRequestStatusCalculatorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ public void Should_Handle_Issue_Provider_With_Different_Type_But_Same_Run()
337337
// Then
338338
result.Count().ShouldBe(2);
339339

340-
result.ShouldContain(x =>
340+
result.ShouldContain(x =>
341341
x.Name == "Issues-Fake Issue Provider (Run 1)" &&
342342
x.Genre == "Cake.Issues.Recipe" &&
343343
x.State == PullRequestStatusState.Failed &&
@@ -512,7 +512,7 @@ public void Should_Consider_Build_Identifier()
512512
};
513513
var shouldSetPullRequestStatus = true;
514514
var shouldSetSeparatePullRequestStatusForEachIssueProviderAndRun = false;
515-
string buildIdentifier = "Build Identifier";
515+
var buildIdentifier = "Build Identifier";
516516

517517
// When
518518
var result =

‎Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe.sln

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Cake.Frosting.Issues.Recipe
77
EndProject
88
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Cake.Frosting.Issues.Recipe.Tests", "Cake.Frosting.Issues.Recipe.Tests\Cake.Frosting.Issues.Recipe.Tests.csproj", "{946A333A-2713-4D77-93EE-342573E1F63E}"
99
EndProject
10+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{3066ECA1-27E1-4F33-93F4-78E4E20A6A94}"
11+
ProjectSection(SolutionItems) = preProject
12+
.editorconfig = .editorconfig
13+
EndProjectSection
14+
EndProject
1015
Global
1116
GlobalSection(SolutionConfigurationPlatforms) = preSolution
1217
Debug|Any CPU = Debug|Any CPU

0 commit comments

Comments
 (0)