Skip to content

Commit c1e56de

Browse files
committed
deleting terraform docs automation and small edits
1 parent d38fdf0 commit c1e56de

File tree

2 files changed

+8
-37
lines changed

2 files changed

+8
-37
lines changed

.github/workflows/terraform-validation.yml

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -29,34 +29,4 @@ jobs:
2929
- name: Run terraform tflint
3030
run: |
3131
tflint --chdir=terraform/ --recursive
32-
33-
- name: Document cloud infrastructure remote state in README
34-
uses: terraform-docs/gh-actions@v1.3.0
35-
with:
36-
working-dir: ./terraform/s3-remote-state
37-
- name: Document cloud infrastructure in mkdocs
38-
uses: terraform-docs/gh-actions@v1.3.0
39-
with:
40-
working-dir: ./terraform/aws/modules/infra
41-
output-file: ../../../../docs/code/terraform-local-setup.md
42-
- name: Document Snowflake account infrastructure in mkdocs
43-
uses: terraform-docs/gh-actions@v1.3.0
44-
with:
45-
working-dir: ./terraform/snowflake/modules/elt
46-
output-file: ../../../../docs/infra/snowflake.md
47-
# This shouldn't be necessary but the terraform-docs action has a bug
48-
# preventing it from git-adding files outside of 'working-dir'.
49-
# See: https://github.com/terraform-docs/gh-actions/pull/108
50-
- name: Commit any files changed by terraform-docs
51-
run: |
52-
git add docs/code/terraform-local-setup.md
53-
git add docs/infra/snowflake.md
54-
# Run git commit if changed files are detected
55-
if git status --porcelain | grep -q '[AM ][AM ]\s\+\S\+'; then
56-
git config --global user.name 'github-actions[bot]'
57-
git config --global user.email 'github-actions[bot]@users.noreply.github.com'
58-
set -x
59-
git commit -m "Automated terraform-docs commit"
60-
git push
61-
set +x
6232
fi

docs/code/local-setup.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ Much of the software in this project is written in Python.
1111
It is usually worthwhile to install Python packages into a virtual environment,
1212
which allows them to be isolated from those in other projects which might have different version constraints.
1313

14-
Most of our team uses [Anaconda](https://docs.anaconda.com/anaconda/install/).
15-
Another popular solution for managing Python environments is [Anaconda/Miniconda](https://docs.conda.io/en/latest/miniconda.html).
16-
A third option is to use [`pyenv`](https://github.com/pyenv/pyenv).
14+
Some of our team uses [Anaconda](https://docs.anaconda.com/anaconda/install/) for managing Python environments.
15+
Another popular and lighter-weight solution is [Miniconda](https://docs.conda.io/en/latest/miniconda.html).
16+
A third option is [`pyenv`](https://github.com/pyenv/pyenv).
1717
Pyenv is lighter weight, but is Python-only, whereas conda allows you to install packages from other language ecosystems.
1818

1919
Here are instructions for setting up a Python environment using Miniconda:
@@ -34,7 +34,7 @@ Here are instructions for setting up a Python environment using Miniconda:
3434

3535
Python dependencies are specified using [`poetry`](https://python-poetry.org/).
3636

37-
To install them, open a terminal and ensure you are working in the (`data-infrastructure`) root folder with your `infra` environment activated, then enter the following:
37+
To install them, open a terminal and ensure you are working in the `data-infrastructure` root folder with your `infra` environment activated, then enter the following:
3838

3939
```bash
4040
poetry install --with dev --no-root
@@ -53,8 +53,6 @@ First, install Homebrew
5353

5454
```bash
5555
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
56-
57-
export PATH=/opt/homebrew/bin:/opt/homebrew/sbin:$PATH
5856
```
5957

6058
Then install the go dependencies:
@@ -130,6 +128,9 @@ in a YAML file. Run the following command to create the necessary folder and fil
130128
mkdir ~/.dbt && touch ~/.dbt/profiles.yml
131129
```
132130

131+
!!! note
132+
This will only work on posix-y systems. Windows users will have a different command.
133+
133134
Instructions for writing a `profiles.yml` are documented
134135
[here](https://docs.getdbt.com/docs/get-started/connection-profiles),
135136
there are specific instructions for Snowflake
@@ -216,7 +217,7 @@ This project uses [pre-commit](https://pre-commit.com/) to lint, format,
216217
and generally enforce code quality. These checks are run on every commit,
217218
as well as in CI.
218219

219-
To set up your pre-commit environment locally run the following in the data-infrastructure repo root folder:
220+
To set up your pre-commit environment locally run the following in the `data-infrastructure` repo root folder:
220221

221222
```bash
222223
pre-commit install

0 commit comments

Comments
 (0)