Latest JSON parser updates have caused bugs

[tonis2]

My GLTF parser doesent work anymore, on C3 0.7.4

Parsing the duck gltf, seen here , throws this error ERROR: 'No method 'available' could be found on target' at json.c3:36

Failing code example

import std::io;
import std::collections::object;
import std::encoding::json;

fn void main()
{
  File? file = file::open("test/duck.gltf", "r");
  defer file.close()!!;

  Object*? gltfJson = json::parse(mem, &file);
  defer gltfJson!!.free();
}

[lerno]

Ok, that's bad. Did you get a backtrace on that one?

[tonis2]

Yep, this issue is fixed on latest, I found another bug, but I'm almost ready with a pull request to fix it.

[tonis2]

I need to re-open this, to ask some advice before making pull-request.

For me, it seems that this parts of the JSON parser updates
https://github.com/c3lang/c3c/blob/master/lib/std/encoding/json.c3#L31-L36

Doesen't really do anything else, it just passes some tests that sudison wanted to pass.

It parses the tokens, that are leftover, from actual JSON Object parsing.

So for example this test
https://github.com/c3lang/c3c/blob/master/test/unit/stdlib/encoding/json.c3#L312

And this test
https://github.com/c3lang/c3c/blob/master/test/unit/stdlib/encoding/json.c3#L224

Both only run on data, that's after the JSON, but don't really detect those things when they happen in the JSON file itself.

Maybe I just don't get it, but I don't see how it's useful code.

My issue with this new loop, is that, I was using the std lib JSON parser to parse GLTF files and GLB files,
GLB files are like binary versions of the JSON file, and they sometimes have some weird bytes after the core JSON data.
That's just how the exporters created them, blender ..etc.

But this change breaks GLB file parsing, and I don't seem to be able to fix it, without removing this loop that I showd on top, and removing 2 tests that relay on this loop.

@lerno what do you think, how to proceed here.

[lerno]

Yes, I am tempted to agree with that. Being anal about json parsing just makes the parser less useful. There are two approaches:

1. Remove those additional tests.
2. Retain them, but only when requesting a "strict" JSON parsing.

[tonis2]

I would just remove this part, and the tests related to it
https://github.com/c3lang/c3c/blob/master/lib/std/encoding/json.c3#L31-L36

I think removing is better, cause the usecase is so low, but it complicates understanding the code, when someone new reads how JSON parser works.

Should I make a pull request for removing the part ?