Skip to content

Commit 3ec8f76

Browse files
committed
clean up and use wac fork
1 parent 4f04066 commit 3ec8f76

File tree

4 files changed

+8
-35
lines changed

4 files changed

+8
-35
lines changed

Cargo.lock

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/core/src/abi.rs

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ def_instruction! {
322322
id: TypeId,
323323
} : [1] => [*size as usize],
324324

325-
/// Pops an array and an address off the stack, passes each element to a block
325+
/// Pops an array and an address off the stack, passes each element to a block storing it
326326
FixedSizeListLowerBlock {
327327
element: &'a Type,
328328
size: u32,
@@ -1766,38 +1766,15 @@ impl<'a, B: Bindgen> Generator<'a, B> {
17661766

17671767
TypeDefKind::Unknown => unreachable!(),
17681768
TypeDefKind::FixedSizeList(element, size) => {
1769-
// let increment = self.bindgen.sizes().size(ty);
1770-
// let mut position = offset;
1771-
// let resultvar = self.stack[0];
1772-
// for _ in 0..*size {
1773-
// // push index
1774-
// self.stack.push("", );
1775-
// self.write_to_memory(ty, addr.clone(), position);
1776-
// position = position + increment;
1777-
// }
1778-
// @@@@
1779-
// self.emit(&FixedSizeListLower {
1780-
// elements: ty,
1781-
// size: *size,
1782-
// id,
1783-
// });
1784-
17851769
// resembles write_list_to_memory
17861770
self.push_block();
17871771
self.emit(&IterElem { element });
17881772
self.emit(&IterBasePointer);
17891773
let elem_addr = self.stack.pop().unwrap();
17901774
self.write_to_memory(element, elem_addr, Default::default());
17911775
self.finish_block(0);
1792-
// let target = self.stack.pop().unwrap();
17931776
self.stack.push(addr);
17941777
self.emit(&FixedSizeListLowerBlock { element, size: *size, id });
1795-
1796-
// for idx in 0..*size {
1797-
// //self.write_fields_to_memory(tuple.types.iter(), addr, offset);
1798-
// self.emit(&FixedSizeListLowerElement { elements: ty, idx, });
1799-
// self.write_to_memory(ty, addr.clone(), offset + (field_offset));
1800-
// }
18011778
}
18021779
},
18031780
}

crates/rust/src/bindgen.rs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -799,16 +799,9 @@ impl Bindgen for FunctionBindgen<'_, '_> {
799799

800800
Instruction::FixedSizeListLowerBlock { element, size: _, id: _ } => {
801801
let body = self.blocks.pop().unwrap();
802-
// let tmp = self.tmp();
803802
let vec = operands[0].clone();
804-
//format!("vec{tmp}");
805-
// self.push_str(&format!(
806-
// "let {vec} = {operand0};\n",
807-
// operand0 = operands[0]
808-
// ));
809-
let size = self.r#gen.sizes.size(element);
810803
let target = operands[1].clone();
811-
// let align = self.r#gen.sizes.align(element);
804+
let size = self.r#gen.sizes.size(element);
812805
self.push_str(&format!("for (i, e) in {vec}.into_iter().enumerate() {{\n",));
813806
self.push_str(&format!(
814807
"let base = {target}.add(i * {});\n",

crates/test/Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ regex = "1.11.1"
2424
serde = { workspace = true }
2525
toml = "0.8.20"
2626
wasi-preview1-component-adapter-provider = "30.0.2"
27-
wac-parser = { path = "../../../wac/crates/wac-parser" }
28-
wac-types = { path = "../../../wac/crates/wac-types" }
29-
wac-graph = { path = "../../../wac/crates/wac-graph" }
27+
wac-parser = { git = "https://github.com/cpetig/wac", branch = "fixed-size-lists" }
28+
wac-types = { git = "https://github.com/cpetig/wac", branch = "fixed-size-lists" }
29+
wac-graph = { git = "https://github.com/cpetig/wac", branch = "fixed-size-lists" }
3030
indexmap = { workspace = true }
3131
wasm-encoder = { workspace = true }
3232
wasmparser = { workspace = true, features = ["features"] }

0 commit comments

Comments
 (0)