Skip to content

Commit b943666

Browse files
authored
Update nightly in CI (#9501)
* Update nightly in CI This commit updates nightly again in CI after failing to do so in #9496. This fixes an issue in our release CI where CMake was misconfigured when cross-compiling and creating `aarch64-pc-windows-msvc` artifacts. prtest:full * Try installing ninja * Also install Ninja on Linux
1 parent c255a85 commit b943666

File tree

9 files changed

+31
-6
lines changed

9 files changed

+31
-6
lines changed
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
name: 'Install ninja'
2+
description: 'Install ninja'
3+
4+
runs:
5+
using: composite
6+
steps:
7+
- name: Install ninja (macOS)
8+
run: brew install ninja
9+
if: runner.os == 'macOS'
10+
shell: bash
11+
- name: Install ninja (Windows)
12+
run: choco install ninja
13+
if: runner.os == 'Windows'
14+
shell: bash
15+
- name: Install ninja (Linux)
16+
run: sudo apt-get update && sudo apt-get install -y ninja-build
17+
if: runner.os == 'Linux'
18+
shell: bash

.github/actions/install-rust/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ runs:
2828
elif [ "${{ inputs.toolchain }}" = "msrv" ]; then
2929
echo "version=1.$msrv.0" >> "$GITHUB_OUTPUT"
3030
elif [ "${{ inputs.toolchain }}" = "wasmtime-ci-pinned-nightly" ]; then
31-
echo "version=nightly-2024-10-02" >> "$GITHUB_OUTPUT"
31+
echo "version=nightly-2024-10-22" >> "$GITHUB_OUTPUT"
3232
else
3333
echo "version=${{ inputs.toolchain }}" >> "$GITHUB_OUTPUT"
3434
fi

.github/workflows/main.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1088,6 +1088,7 @@ jobs:
10881088
with:
10891089
submodules: true
10901090

1091+
- uses: ./.github/actions/install-ninja
10911092
- uses: ./.github/actions/install-rust
10921093
with:
10931094
toolchain: ${{ matrix.rust }}

ci/build-release-artifacts.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ cargo build --release $flags --target $target -p wasmtime-cli $bin_flags --featu
4545
mkdir -p target/c-api-build
4646
cd target/c-api-build
4747
cmake \
48+
-G Ninja \
4849
../../crates/c-api \
4950
$cmake_flags \
5051
-DCMAKE_BUILD_TYPE=Release \

ci/docker/aarch64-linux/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM ubuntu:16.04
22

3-
RUN apt-get update -y && apt-get install -y gcc gcc-aarch64-linux-gnu ca-certificates curl make git
3+
RUN apt-get update -y && apt-get install -y gcc gcc-aarch64-linux-gnu ca-certificates curl make git ninja-build
44
RUN git config --global --add safe.directory '*'
55

66
# The CMake in Ubuntu 16.04 was a bit too old for us to use so download one from

ci/docker/riscv64gc-linux/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM ubuntu:22.04
22

3-
RUN apt-get update -y && apt-get install -y gcc gcc-riscv64-linux-gnu ca-certificates cmake git
3+
RUN apt-get update -y && apt-get install -y gcc gcc-riscv64-linux-gnu ca-certificates cmake git ninja-build
44
RUN git config --global --add safe.directory '*'
55

66
ENV CARGO_TARGET_RISCV64GC_UNKNOWN_LINUX_GNU_LINKER=riscv64-linux-gnu-gcc

ci/docker/s390x-linux/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM ubuntu:16.04
22

3-
RUN apt-get update -y && apt-get install -y gcc gcc-s390x-linux-gnu ca-certificates curl make git
3+
RUN apt-get update -y && apt-get install -y gcc gcc-s390x-linux-gnu ca-certificates curl make git ninja-build
44
RUN git config --global --add safe.directory '*'
55

66
# The CMake in Ubuntu 16.04 was a bit too old for us to use so download one from

ci/docker/x86_64-linux/Dockerfile

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
FROM almalinux:8
22

3-
RUN dnf install -y git gcc make cmake git
3+
RUN dnf install -y git gcc make cmake git unzip
44
RUN git config --global --add safe.directory '*'
5+
6+
WORKDIR /usr/local/bin
7+
RUN curl -LO https://github.com/ninja-build/ninja/releases/download/v1.12.1/ninja-linux.zip
8+
RUN unzip ./ninja-linux
9+
WORKDIR /

ci/docker/x86_64-musl/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ RUN apk add libgcc
66
# Use something glibc-based for the actual compile because the Rust toolchain
77
# we're using is glibc-based in CI.
88
FROM ubuntu:24.04
9-
RUN apt-get update -y && apt-get install -y cmake musl-tools git
9+
RUN apt-get update -y && apt-get install -y cmake musl-tools git ninja-build
1010
COPY --from=libgcc_s_src /usr/lib/libgcc_s.so.1 /usr/lib/x86_64-linux-musl
1111
RUN git config --global --add safe.directory '*'
1212

0 commit comments

Comments
 (0)