Add avx feature flag (#10846)

* Add support for avx feature flag

* Require vaddps/vaddpd use the AVX feature flag.

Author: jlb6740

cranelift/assembler-x64/meta/src/dsl/features.rs

@@ -69,6 +69,7 @@ pub enum Feature {
     bmi1,
     lzcnt,
     popcnt,
+    avx,
 }
 
 /// List all CPU features.
@@ -88,6 +89,7 @@ pub const ALL_FEATURES: &[Feature] = &[
     Feature::bmi1,
     Feature::lzcnt,
     Feature::popcnt,
+    Feature::avx,
 ];
 
 impl fmt::Display for Feature {

cranelift/assembler-x64/meta/src/instructions/add.rs

@@ -78,7 +78,7 @@ pub fn list() -> Vec<Inst> {
         inst("phaddw", fmt("A", [rw(xmm1), r(align(xmm_m128))]), rex([0x66, 0x0F, 0x38, 0x01]).r(), _64b | compat | ssse3),
         inst("phaddd", fmt("A", [rw(xmm1), r(align(xmm_m128))]), rex([0x66, 0x0F, 0x38, 0x02]).r(), _64b | compat | ssse3),
         // Vex instructions
-        inst("vaddps", fmt("B", [w(xmm1), r(xmm2), r(xmm_m128)]), vex(0x58).length(_128).mmmmm(_OF), _64b | compat | sse2),
-        inst("vaddpd", fmt("B", [w(xmm1), r(xmm2), r(xmm_m128)]), vex(0x58).length(_128).pp(_66).mmmmm(_OF), _64b | compat | sse2)
+        inst("vaddps", fmt("B", [w(xmm1), r(xmm2), r(xmm_m128)]), vex(0x58).length(_128).mmmmm(_OF), _64b | compat | avx),
+        inst("vaddpd", fmt("B", [w(xmm1), r(xmm2), r(xmm_m128)]), vex(0x58).length(_128).pp(_66).mmmmm(_OF), _64b | compat | avx)
     ]
 }

cranelift/codegen/src/isa/x64/inst/mod.rs

@@ -187,6 +187,7 @@ impl Inst {
                         bmi1 => features.push(InstructionSet::BMI1),
                         lzcnt => features.push(InstructionSet::Lzcnt),
                         popcnt => features.push(InstructionSet::Popcnt),
+                        avx => features.push(InstructionSet::AVX),
                     }
                 }
                 features