Move PropsWithChildren to shared ErrorBoundaryProps type (#152)

Author: Jonghyeon Ko

src/ErrorBoundary.ts

@@ -3,9 +3,7 @@ import {
   createElement,
   ErrorInfo,
   isValidElement,
-  PropsWithChildren,
   PropsWithRef,
-  ReactElement,
 } from "react";
 import { ErrorBoundaryContext } from "./ErrorBoundaryContext";
 import { ErrorBoundaryProps, FallbackProps } from "./types";
@@ -18,7 +16,7 @@ const initialState: ErrorBoundaryState = {
 };
 
 export class ErrorBoundary extends Component<
-  PropsWithRef<PropsWithChildren<ErrorBoundaryProps>>,
+  PropsWithRef<ErrorBoundaryProps>,
   ErrorBoundaryState
 > {
   constructor(props: ErrorBoundaryProps) {

src/types.ts

@@ -2,6 +2,7 @@ import {
   Component,
   ComponentType,
   FunctionComponent,
+  PropsWithChildren,
   ReactElement,
   ReactNode,
 } from "react";
@@ -13,15 +14,15 @@ export type FallbackProps = {
   resetErrorBoundary: (...args: any[]) => void;
 };
 
-type ErrorBoundarySharedProps = {
+type ErrorBoundarySharedProps = PropsWithChildren<{
   onError?: (error: Error, info: { componentStack: string }) => void;
   onReset?: (
     details:
       | { reason: "imperative-api"; args: any[] }
       | { reason: "keys"; prev: any[] | undefined; next: any[] | undefined }
   ) => void;
   resetKeys?: any[];
-};
+}>;
 
 export type ErrorBoundaryPropsWithComponent = ErrorBoundarySharedProps & {
   fallback?: never;