Merge pull request #186 from bugsnag/releases/v1.9.0

Release v1.9.0

Author: richardelms

.buildkite/pipeline.full.yml

@@ -7,10 +7,10 @@ steps:
     commands:
       - buildkite-agent pipeline upload .buildkite/unity.2020.full.yml
 
-  - label: 'Append Unity 2021 Full Pipeline'
-    timeout_in_minutes: 2
-    commands:
-      - buildkite-agent pipeline upload .buildkite/unity.2021.full.yml
+  # - label: 'Append Unity 2021 Full Pipeline'
+  #   timeout_in_minutes: 2
+  #   commands:
+  #     - buildkite-agent pipeline upload .buildkite/unity.2021.full.yml
 
   - label: 'Append Unity 2022 Full Pipeline'
     timeout_in_minutes: 2

.buildkite/pipeline.yml

@@ -3,9 +3,16 @@ aliases:
   - &2020 "2020.3.48f1"
 
 agents:
-  queue: macos-14
+  queue: macos-14-isolated
 
 steps:
+  - label: Verify code formatting
+    timeout_in_minutes: 5
+    env:
+      UNITY_PERFORMANCE_VERSION: *2021
+    commands:
+      - rake code:verify
+
   - label: Build released library artifact
     timeout_in_minutes: 10
     key: build-artifacts
@@ -20,20 +27,25 @@ steps:
       automatic:
         - exit_status: '*'
           limit: 1
+    agents:
+      queue: macos-14-isolated
+    concurrency: 1
+    concurrency_group: "unity-license-server"
+    concurrency_method: eager
 
   - label: Build size impact reporting
     depends_on: build-artifacts
     timeout_in_minutes: 10
     env:
       UNITY_PERFORMANCE_VERSION: *2021
     plugins:
-      'artifacts#v1.9.0':
+      artifacts#v1.9.0:
         download:
           - upm-package.zip
     commands:
-      features/scripts/do_size_test.sh
+      - features/scripts/do_size_test.sh
 
-  - label: 'Append Unity 2021 Basic Pipeline'
+  - label: Append Unity 2021 Basic Pipeline
     agents:
       queue: macos
     timeout_in_minutes: 2
@@ -44,4 +56,5 @@ steps:
     agents:
       queue: macos
     timeout_in_minutes: 2
-    command: sh -c .buildkite/pipeline_trigger.sh
+    commands:
+      - sh -c .buildkite/pipeline_trigger.sh

.buildkite/unity.2020.full.yml

@@ -2,7 +2,7 @@ aliases:
   - &2020 "2020.3.48f1"
 
 agents:
-  queue: macos-14
+  queue: macos-14-isolated
 
 steps:
   - group: ":hammer: Build Unity 2020 Test Fixtures"
@@ -125,6 +125,8 @@ steps:
   - group: ":test_tube: E2E Tests Unity 2020"
     steps:
       - label: Run MacOS e2e tests for Unity 2020
+        agents:
+          queue: macos-14-isolated
         timeout_in_minutes: 30
         depends_on: build-macos-fixture-2020
         env:

.buildkite/unity.2021.full.yml

@@ -2,7 +2,7 @@ aliases:
   - &2021 "2021.3.45f1"
 
 agents:
-  queue: macos-14
+  queue: macos-14-isolated
 
 steps:
   - group: ":hammer: Build Unity 2021 Test Fixtures"
@@ -95,6 +95,8 @@ steps:
               limit: 1
 
       - label: ':ios: Build iOS DEV test fixture for Unity 2021'
+        agents:
+          queue: macos-14-isolated
         timeout_in_minutes: 10
         key: build-ios-dev-fixture-2021
         depends_on: generate-dev-fixture-project-2021
@@ -119,6 +121,8 @@ steps:
   - group: ":test_tube: E2E Tests Unity 2021"
     steps:
       - label: Run WebGL DEV e2e tests for Unity 2021
+        agents:
+          queue: macos-14-isolated
         timeout_in_minutes: 20
         depends_on: build-webgl-dev-fixture-2021
         env:
@@ -181,6 +185,8 @@ steps:
               limit: 1
 
       - label: Run MacOS DEV e2e tests for Unity 2021
+        agents:
+          queue: macos-14-isolated
         timeout_in_minutes: 30
         depends_on: build-macos-dev-fixture-2021
         env:

.buildkite/unity.2021.yml

@@ -2,7 +2,7 @@ aliases:
   - &2021 "2021.3.45f1"
 
 agents:
-  queue: macos-14
+  queue: macos-14-isolated
 
 steps:
   - group: ":hammer: Build Unity 2021 Test Fixtures"
@@ -71,6 +71,11 @@ steps:
           automatic:
             - exit_status: '*'
               limit: 1
+        agents:
+          queue: macos-14-isolated
+        concurrency: 1
+        concurrency_group: "unity-license-server"
+        concurrency_method: eager
 
       - label: ':android: Build Android test fixture for Unity 2021'
         timeout_in_minutes: 10
@@ -93,6 +98,11 @@ steps:
           automatic:
             - exit_status: '*'
               limit: 1
+        agents:
+          queue: macos-14-isolated
+        concurrency: 1
+        concurrency_group: "unity-license-server"
+        concurrency_method: eager
 
       - label: ':ios: Generate Xcode project - Unity 2021'
         timeout_in_minutes: 10
@@ -141,6 +151,8 @@ steps:
   - group: ":test_tube: E2E Tests Unity 2021"
     steps:
       - label: Run WebGL e2e tests for Unity 2021
+        agents:
+          queue: macos-14-isolated
         timeout_in_minutes: 20
         depends_on: build-webgl-fixture-2021
         env:
@@ -185,6 +197,8 @@ steps:
           - features/scripts/run-windows-ci-tests.sh release
 
       - label: Run MacOS e2e tests for Unity 2021
+        agents:
+          queue: macos-14-isolated
         timeout_in_minutes: 30
         depends_on: build-macos-fixture-2021
         env:

.buildkite/unity.2022.full.yml

@@ -1,8 +1,8 @@
 aliases:
-  - &2022 "2022.3.57f1"
+  - &2022 "2022.3.61f1"
 
 agents:
-  queue: macos-14
+  queue: macos-14-isolated
 
 steps:
   - group: ":hammer: Build Unity 2022 Test Fixtures"
@@ -121,6 +121,8 @@ steps:
   - group: ":test_tube: E2E Tests Unity 2022"
     steps:
       - label: Run MacOS e2e tests for Unity 2022
+        agents:
+          queue: macos-14-isolated
         timeout_in_minutes: 30
         depends_on: build-macos-fixture-2022
         env:

.buildkite/unity.6000.full.yml

@@ -1,8 +1,8 @@
 aliases:
-  - &6000 "6000.0.36f1"
+  - &6000 "6000.0.47f1"
 
 agents:
-  queue: macos-14
+  queue: macos-14-isolated
 
 steps:
   - group: ":hammer: Build Unity 6000 Test Fixtures"
@@ -121,6 +121,8 @@ steps:
   - group: ":test_tube: E2E Tests Unity 6000"
     steps:
       - label: Run MacOS e2e tests for Unity 6000
+        agents:
+          queue: macos-14-isolated
         timeout_in_minutes: 30
         depends_on: build-macos-fixture-6000
         env:

.github/ISSUE_TEMPLATE/A.md

@@ -7,8 +7,8 @@ labels: ''
 assignees: ''
 
 ---
-Please checkout our [documentation](https://docs.bugsnag.com/performance/unity/) for guides, references and tutorials.
+Please check out our [documentation](https://docs.bugsnag.com/performance/unity/) for guides, references and tutorials.
 
-If you have questions about your integration please contact us at [support@bugsnag.com](mailto:support@bugsnag.com).
+If you have questions about your integration, please contact us at [support@bugsnag.com](mailto:support@bugsnag.com).
 
-Alternatively, view additional options at [support.md](../SUPPORT.md).
+Alternatively, view additional options at [SUPPORT.md](../SUPPORT.md).

.github/ISSUE_TEMPLATE/bug_report.md

@@ -7,7 +7,7 @@ assignees: ''
 
 ---
 
-<!-- Before raising, please check if somebody else has already reported your issue. -->
+<!-- Before raising, please check whether somebody else has already reported your issue. -->
 
 ### Describe the bug
 A clear and concise description of what the bug is.
@@ -24,7 +24,7 @@ A clear and concise description of what the bug is.
 * Unity version:
 * iOS/Android/macOS/Windows/browser version:
 * simulator/emulator or physical device:
-* Initializing bugSnag performance via a Unity GameObject or in code?:
+* Initializing BugSnag Performance via a Unity GameObject or in code?:
 * Player Settings:
     * Scripting backend (Mono or IL2CPP):
     * API compatibility level for .NET:
@@ -53,4 +53,4 @@ A clear and concise description of what the bug is.
 ```
 
 ```
-</details>
+</details>

.github/ISSUE_TEMPLATE/feature_request.md

@@ -7,7 +7,7 @@ assignees: ''
 
 ---
 
-<!-- Before creating, please check if somebody else has already reported your feature request. -->
+<!-- Before creating, please check whether somebody else has already reported your feature request. -->
 
 ### Description
 <!-- Is your feature request related to a problem? Please describe.

.github/support.md renamed to .github/SUPPORT.md

@@ -1,7 +1,7 @@
 ## Are you having trouble getting started?
-If you haven't already, please checkout our [documentation](https://docs.bugsnag.com/performance/unity/) for guides, references and tutorials.
+If you haven't already, please check out our [documentation](https://docs.bugsnag.com/performance/unity/) for guides, references and tutorials.
 
-Or, if you wish you can [contact us directly](mailto:support@bugsnag.com) for assistance on integrating BugSnag into your application, troubleshooting an issue or a question about our supported features.
+Or, if you wish, you can [contact us directly](mailto:support@bugsnag.com) for assistance on integrating BugSnag into your application, troubleshooting an issue, or if you have a question about our supported features.
 
 When contacting support, please include as much information as necessary, including:
 
@@ -14,15 +14,15 @@ When contacting support, please include as much information as necessary, includ
 * Unity version:
 * iOS/Android/macOS/Windows/browser version:
 * simulator/emulator or physical device:
-* Initializing BugSnag performance via a Unity GameObject or in code?:
+* Initializing BugSnag Performance via a Unity GameObject or in code?:
 * Player Settings:
     * Scripting backend (Mono or IL2CPP):
     * API compatibility level for .NET:
     * Stack Trace level for all error types (None/ScriptOnly/Full):
 
 ## Bug or Feature Requests
-If you would like to raise a bug or feature request please do so by creating a [New Issue](https://github.com/bugsnag/bugsnag-unity-performance/issues/new/choose) and selecting bug or feature.
+If you would like to raise a bug or feature request, please do so by creating a [New Issue](https://github.com/bugsnag/bugsnag-unity-performance/issues/new/choose) and selecting bug or feature.
 Please note: we cannot promise that we will fulfil all requests
 
 ## Pull Requests
-If you have made a fix and would like to raise a pull request, please read our [CONTRIBUTING.md](../CONTRIBUTING.md) file before creating the pull request.
+If you have made a fix and would like to raise a pull request, please read our [CONTRIBUTING.md](../CONTRIBUTING.md) file before creating the pull request.

BugsnagPerformance/Assets/BugsnagPerformance/Editor/BugsnagPerformanceEditor.cs

@@ -105,16 +105,36 @@ private void DrawSettingsEditorWindow()
         DrawIntPropertyWithDefault(so, "AttributeArrayLengthLimit", "AttributeArrayLengthLimit", PerformanceConfiguration.DEFAULT_ATTRIBUTE_ARRAY_LENGTH_LIMIT);
         DrawIntPropertyWithDefault(so, "AttributeCountLimit", "AttributeCountLimit", PerformanceConfiguration.DEFAULT_ATTRIBUTE_COUNT_LIMIT);
         DrawIntPropertyWithDefault(so, "AttributeStringValueLimit", "AttributeStringValueLimit", PerformanceConfiguration.DEFAULT_ATTRIBUTE_STRING_VALUE_LIMIT);
-        EditorGUILayout.PropertyField(so.FindProperty("AutoInstrumentRendering"));
         EditorGUILayout.PropertyField(so.FindProperty("AutoInstrumentAppStart"));
         EditorGUILayout.PropertyField(so.FindProperty("Endpoint"));
         EditorGUILayout.PropertyField(so.FindProperty("ServiceName"));
         EditorGUILayout.PropertyField(so.FindProperty("TracePropagationUrls"));
+        DrawEnabledMetricsDropdown(so, settings);
         EditorGUI.indentLevel--;
         so.ApplyModifiedProperties();
         EditorUtility.SetDirty(settings);
     }
 
+    private void DrawEnabledMetricsDropdown(SerializedObject so, BugsnagPerformanceSettingsObject settings)
+    {
+        var style = new GUIStyle(GUI.skin.GetStyle("foldout"));
+        style.margin = new RectOffset(2, 0, 0, 0);
+        _showEnabledMetrics = EditorGUILayout.Foldout(_showEnabledMetrics, "Enabled Metrics", true, style);
+
+        if (_showEnabledMetrics)
+        {
+            EditorGUI.indentLevel += 2;
+            var enabledMetricsProp = so.FindProperty("EnabledMetrics");
+            var renderingProp = enabledMetricsProp.FindPropertyRelative("Rendering");
+            EditorGUILayout.PropertyField(renderingProp, new GUIContent("Rendering"));
+            renderingProp = enabledMetricsProp.FindPropertyRelative("CPU");
+            EditorGUILayout.PropertyField(renderingProp, new GUIContent("CPU"));
+            renderingProp = enabledMetricsProp.FindPropertyRelative("Memory");
+            EditorGUILayout.PropertyField(renderingProp, new GUIContent("Memory"));
+            EditorGUI.indentLevel -= 2;
+        }
+    }
+
     private void DrawIntPropertyWithDefault(SerializedObject so, string propertyName, string label, int defaultValue)
     {
         var property = so.FindProperty(propertyName);

BugsnagPerformance/Assets/BugsnagPerformance/Editor/PlayerSettingsCompat.cs

@@ -3,44 +3,44 @@
 using UnityEditor.Build;
 #endif
 
-    internal static class BugsnagPlayerSettingsCompat
+internal static class BugsnagPlayerSettingsCompat
+{
+    // Get Scripting Backend
+    public static ScriptingImplementation GetScriptingBackend(BuildTargetGroup buildTargetGroup)
     {
-        // Get Scripting Backend
-        public static ScriptingImplementation GetScriptingBackend(BuildTargetGroup buildTargetGroup)
-        {
 #if UNITY_2021_2_OR_NEWER
-            return PlayerSettings.GetScriptingBackend(NamedBuildTarget.FromBuildTargetGroup(buildTargetGroup));
+        return PlayerSettings.GetScriptingBackend(NamedBuildTarget.FromBuildTargetGroup(buildTargetGroup));
 #else
             return PlayerSettings.GetScriptingBackend(buildTargetGroup);
 #endif
-        }
+    }
 
-        public static string GetApplicationIdentifier(BuildTargetGroup buildTargetGroup)
-        {
+    public static string GetApplicationIdentifier(BuildTargetGroup buildTargetGroup)
+    {
 #if UNITY_2021_2_OR_NEWER
-            return PlayerSettings.GetApplicationIdentifier(NamedBuildTarget.FromBuildTargetGroup(buildTargetGroup));
+        return PlayerSettings.GetApplicationIdentifier(NamedBuildTarget.FromBuildTargetGroup(buildTargetGroup));
 #else
             return PlayerSettings.GetApplicationIdentifier(buildTargetGroup);
 #endif
-        }
+    }
 
-        // Get Scripting Define Symbols
-        public static string GetScriptingDefineSymbols(BuildTargetGroup buildTargetGroup)
-        {
+    // Get Scripting Define Symbols
+    public static string GetScriptingDefineSymbols(BuildTargetGroup buildTargetGroup)
+    {
 #if UNITY_2021_2_OR_NEWER
-            return PlayerSettings.GetScriptingDefineSymbols(NamedBuildTarget.FromBuildTargetGroup(buildTargetGroup));
+        return PlayerSettings.GetScriptingDefineSymbols(NamedBuildTarget.FromBuildTargetGroup(buildTargetGroup));
 #else
             return PlayerSettings.GetScriptingDefineSymbolsForGroup(buildTargetGroup);
 #endif
-        }
+    }
 
-        // Set Scripting Define Symbols
-        public static void SetScriptingDefineSymbols(BuildTargetGroup buildTargetGroup, string defineSymbols)
-        {
+    // Set Scripting Define Symbols
+    public static void SetScriptingDefineSymbols(BuildTargetGroup buildTargetGroup, string defineSymbols)
+    {
 #if UNITY_2021_2_OR_NEWER
-            PlayerSettings.SetScriptingDefineSymbols(NamedBuildTarget.FromBuildTargetGroup(buildTargetGroup), defineSymbols);
+        PlayerSettings.SetScriptingDefineSymbols(NamedBuildTarget.FromBuildTargetGroup(buildTargetGroup), defineSymbols);
 #else
             PlayerSettings.SetScriptingDefineSymbolsForGroup(buildTargetGroup, defineSymbols);
 #endif
-        }
     }
+}