Skip to content

Commit fde4f23

Browse files
twometrestevetwometresteve
authored
Merge pull request #127 from bugsnag/next
Release v2.2.1
2 parents 8e9f8ae + f0f0698 commit fde4f23

28 files changed

+314
-333
lines changed

‎.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 4 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -1,84 +1,15 @@
11
## Goal
22

3-
<!-- What is the intent of this change?
4-
e.g. "When initializing the Bugsnag client, it is currently difficult to (...)
5-
this change simplifies the process by (...)"
6-
7-
"Improves the performance of data filtering"
8-
9-
"Adds additional test coverage to multi-threaded use of Configuration
10-
objects"
11-
-->
12-
13-
<!-- For new features, include design documentation:
3+
<!-- Why is this change necessary? -->
144

155
## Design
166

17-
Why was this approach to the goal used?
18-
19-
-->
7+
<!-- Why was this approach used? -->
208

219
## Changeset
2210

23-
<!-- What structures or properties or functions were:
24-
25-
### Added
26-
27-
### Removed
28-
29-
### Changed
30-
31-
-->
11+
<!-- What changed? -->
3212

3313
## Tests
3414

35-
<!-- How was this change tested? What manual and automated tests were
36-
run/added? -->
37-
38-
## Discussion
39-
40-
### Alternative Approaches
41-
42-
<!-- What other approaches were considered or discussed? -->
43-
44-
### Outstanding Questions
45-
46-
<!-- Are there any parts of the design or the implementation which seem
47-
less than ideal and that could require additional discussion?
48-
List here: -->
49-
50-
### Linked issues
51-
52-
<!--
53-
54-
Fixes #
55-
Related to #
56-
57-
-->
58-
59-
## Review
60-
61-
<!-- When submitting for review, consider the points for self-review and the
62-
criteria which will be used for secondary review -->
63-
64-
For the submitter, initial self-review:
65-
66-
- [ ] Commented on code changes inline explain the reasoning behind the approach
67-
- [ ] Reviewed the test cases added for completeness and possible points for discussion
68-
- [ ] A changelog entry was added for the goal of this pull request
69-
- [ ] Check the scope of the changeset - is everything in the diff required for the pull request?
70-
- This pull request is ready for:
71-
- [ ] Initial review of the intended approach, not yet feature complete
72-
- [ ] Structural review of the classes, functions, and properties modified
73-
- [ ] Final review
74-
75-
For the pull request reviewer(s), this changeset has been reviewed for:
76-
77-
- [ ] Consistency across platforms for structures or concepts added or modified
78-
- [ ] Consistency between the changeset and the goal stated above
79-
- [ ] Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
80-
- [ ] Usage friction - is the proposed change in usage cumbersome or complicated?
81-
- [ ] Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
82-
- [ ] Concurrency concerns - if components are accessed asynchronously, what issues will arise
83-
- [ ] Thoroughness of added tests and any missing edge cases
84-
- [ ] Idiomatic use of the language
15+
<!-- How was it tested? -->

‎Bugsnag.sln

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
Microsoft Visual Studio Solution File, Format Version 12.00
3-
# Visual Studio 15
4-
VisualStudioVersion = 15.0.27130.2036
3+
# Visual Studio Version 16
4+
VisualStudioVersion = 16.0.29209.62
55
MinimumVisualStudioVersion = 10.0.40219.1
66
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Bugsnag", "src\Bugsnag\Bugsnag.csproj", "{6786F339-353C-413B-9165-422ED8D9EDF5}"
77
EndProject
@@ -27,12 +27,17 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
2727
ProjectSection(SolutionItems) = preProject
2828
appveyor.yml = appveyor.yml
2929
build.cake = build.cake
30+
CHANGELOG.md = CHANGELOG.md
31+
CONTRIBUTING.md = CONTRIBUTING.md
3032
src\Directory.build.props = src\Directory.build.props
33+
LICENSE.txt = LICENSE.txt
34+
README.md = README.md
35+
UPGRADING.md = UPGRADING.md
3136
EndProjectSection
3237
EndProject
3338
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Bugsnag.AspNet.WebApi.Tests", "tests\Bugsnag.AspNet.WebApi.Tests\Bugsnag.AspNet.WebApi.Tests.csproj", "{584E892B-5A65-4484-9F0E-CD58EFDA75BD}"
3439
EndProject
35-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Bugsnag.AspNet.Core.Tests", "tests\Bugsnag.AspNet.Core.Tests\Bugsnag.AspNet.Core.Tests.csproj", "{C86A5E8F-5402-49D8-BDD3-0C96D89B6E2E}"
40+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Bugsnag.AspNet.Core.Tests", "tests\Bugsnag.AspNet.Core.Tests\Bugsnag.AspNet.Core.Tests.csproj", "{C86A5E8F-5402-49D8-BDD3-0C96D89B6E2E}"
3641
EndProject
3742
Global
3843
GlobalSection(SolutionConfigurationPlatforms) = preSolution

‎CHANGELOG.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,17 @@
11
Changelog
22
=========
33

4-
## Unreleased
4+
## 2.2.1 (2019-05-14)
5+
6+
### Bug fixes
7+
8+
* Handle any exceptions raised when reading files for code segments.
9+
| [twometresteve](https://github.com/twometresteve)
10+
| [#123](https://github.com/bugsnag/bugsnag-dotnet/pull/123)
11+
12+
* Account for process termination behavior when handling UnobservedTaskExceptions.
13+
| [twometresteve](https://github.com/twometresteve)
14+
| [#125](https://github.com/bugsnag/bugsnag-dotnet/pull/125)
515

616
## 2.2.0 (2018-07-19)
717

‎LICENSE.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Copyright (c) 2018 Bugsnag
1+
Copyright (c) 2020 Bugsnag
22

33
Permission is hereby granted, free of charge, to any person obtaining
44
a copy of this software and associated documentation files (the

‎examples/aspnet35/Bugsnag.Sample.AspNet35.csproj

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,14 @@
3939
<WarningLevel>4</WarningLevel>
4040
</PropertyGroup>
4141
<ItemGroup>
42-
<Reference Include="Bugsnag, Version=2.0.2.0, Culture=neutral, processorArchitecture=MSIL">
43-
<HintPath>packages\Bugsnag.2.0.2\lib\net35\Bugsnag.dll</HintPath>
42+
<Reference Include="Bugsnag, Version=2.2.0.0, Culture=neutral, processorArchitecture=MSIL">
43+
<HintPath>packages\Bugsnag.2.2.0\lib\net35\Bugsnag.dll</HintPath>
4444
</Reference>
45-
<Reference Include="Bugsnag.AspNet, Version=2.0.2.0, Culture=neutral, processorArchitecture=MSIL">
46-
<HintPath>packages\Bugsnag.AspNet.2.0.2\lib\net35\Bugsnag.AspNet.dll</HintPath>
45+
<Reference Include="Bugsnag.AspNet, Version=2.2.0.0, Culture=neutral, processorArchitecture=MSIL">
46+
<HintPath>packages\Bugsnag.AspNet.2.2.0\lib\net35\Bugsnag.AspNet.dll</HintPath>
4747
</Reference>
48-
<Reference Include="Bugsnag.ConfigurationSection, Version=2.0.2.0, Culture=neutral, processorArchitecture=MSIL">
49-
<HintPath>packages\Bugsnag.ConfigurationSection.2.0.2\lib\net35\Bugsnag.ConfigurationSection.dll</HintPath>
48+
<Reference Include="Bugsnag.ConfigurationSection, Version=2.2.0.0, Culture=neutral, processorArchitecture=MSIL">
49+
<HintPath>packages\Bugsnag.ConfigurationSection.2.2.0\lib\net35\Bugsnag.ConfigurationSection.dll</HintPath>
5050
</Reference>
5151
<Reference Include="System" />
5252
<Reference Include="System.Data" />

‎examples/aspnet35/packages.config

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
3-
<package id="Bugsnag" version="2.0.2" targetFramework="net35" />
4-
<package id="Bugsnag.AspNet" version="2.0.2" targetFramework="net35" />
5-
<package id="Bugsnag.ConfigurationSection" version="2.0.2" targetFramework="net35" />
3+
<package id="Bugsnag" version="2.2.0" targetFramework="net35" />
4+
<package id="Bugsnag.AspNet" version="2.2.0" targetFramework="net35" />
5+
<package id="Bugsnag.ConfigurationSection" version="2.2.0" targetFramework="net35" />
66
</packages>

‎examples/aspnet45-mvc-webapi/aspnet45-mvc-webapi.csproj

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,20 +46,20 @@
4646
<WarningLevel>4</WarningLevel>
4747
</PropertyGroup>
4848
<ItemGroup>
49-
<Reference Include="Bugsnag, Version=2.0.2.0, Culture=neutral, processorArchitecture=MSIL">
50-
<HintPath>packages\Bugsnag.2.0.2\lib\net45\Bugsnag.dll</HintPath>
49+
<Reference Include="Bugsnag, Version=2.2.0.0, Culture=neutral, processorArchitecture=MSIL">
50+
<HintPath>packages\Bugsnag.2.2.0\lib\net45\Bugsnag.dll</HintPath>
5151
</Reference>
52-
<Reference Include="Bugsnag.AspNet, Version=2.0.2.0, Culture=neutral, processorArchitecture=MSIL">
53-
<HintPath>packages\Bugsnag.AspNet.2.0.2\lib\net45\Bugsnag.AspNet.dll</HintPath>
52+
<Reference Include="Bugsnag.AspNet, Version=2.2.0.0, Culture=neutral, processorArchitecture=MSIL">
53+
<HintPath>packages\Bugsnag.AspNet.2.2.0\lib\net45\Bugsnag.AspNet.dll</HintPath>
5454
</Reference>
55-
<Reference Include="Bugsnag.AspNet.Mvc, Version=2.0.2.0, Culture=neutral, processorArchitecture=MSIL">
56-
<HintPath>packages\Bugsnag.AspNet.Mvc.2.0.2\lib\net45\Bugsnag.AspNet.Mvc.dll</HintPath>
55+
<Reference Include="Bugsnag.AspNet.Mvc, Version=2.2.0.0, Culture=neutral, processorArchitecture=MSIL">
56+
<HintPath>packages\Bugsnag.AspNet.Mvc.2.2.0\lib\net45\Bugsnag.AspNet.Mvc.dll</HintPath>
5757
</Reference>
58-
<Reference Include="Bugsnag.AspNet.WebApi, Version=2.0.2.0, Culture=neutral, processorArchitecture=MSIL">
59-
<HintPath>packages\Bugsnag.AspNet.WebApi.2.0.2\lib\net45\Bugsnag.AspNet.WebApi.dll</HintPath>
58+
<Reference Include="Bugsnag.AspNet.WebApi, Version=2.2.0.0, Culture=neutral, processorArchitecture=MSIL">
59+
<HintPath>packages\Bugsnag.AspNet.WebApi.2.2.0\lib\net45\Bugsnag.AspNet.WebApi.dll</HintPath>
6060
</Reference>
61-
<Reference Include="Bugsnag.ConfigurationSection, Version=2.0.2.0, Culture=neutral, processorArchitecture=MSIL">
62-
<HintPath>packages\Bugsnag.ConfigurationSection.2.0.2\lib\net45\Bugsnag.ConfigurationSection.dll</HintPath>
61+
<Reference Include="Bugsnag.ConfigurationSection, Version=2.2.0.0, Culture=neutral, processorArchitecture=MSIL">
62+
<HintPath>packages\Bugsnag.ConfigurationSection.2.2.0\lib\net45\Bugsnag.ConfigurationSection.dll</HintPath>
6363
</Reference>
6464
<Reference Include="Microsoft.CodeDom.Providers.DotNetCompilerPlatform, Version=1.0.7.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
6565
<HintPath>packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.1.0.7\lib\net45\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.dll</HintPath>

‎examples/aspnet45-mvc-webapi/packages.config

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
<?xml version="1.0" encoding="utf-8"?>
1+
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
33
<package id="Antlr" version="3.4.1.9004" targetFramework="net45" />
44
<package id="bootstrap" version="3.0.0" targetFramework="net45" />
5-
<package id="Bugsnag" version="2.0.2" targetFramework="net45" />
6-
<package id="Bugsnag.AspNet" version="2.0.2" targetFramework="net45" />
7-
<package id="Bugsnag.AspNet.Mvc" version="2.0.2" targetFramework="net45" />
8-
<package id="Bugsnag.AspNet.WebApi" version="2.0.2" targetFramework="net45" />
9-
<package id="Bugsnag.ConfigurationSection" version="2.0.2" targetFramework="net45" />
5+
<package id="Bugsnag" version="2.2.0" targetFramework="net45" />
6+
<package id="Bugsnag.AspNet" version="2.2.0" targetFramework="net45" />
7+
<package id="Bugsnag.AspNet.Mvc" version="2.2.0" targetFramework="net45" />
8+
<package id="Bugsnag.AspNet.WebApi" version="2.2.0" targetFramework="net45" />
9+
<package id="Bugsnag.ConfigurationSection" version="2.2.0" targetFramework="net45" />
1010
<package id="jQuery" version="1.10.2" targetFramework="net45" />
1111
<package id="Microsoft.ApplicationInsights" version="2.2.0" targetFramework="net45" />
1212
<package id="Microsoft.ApplicationInsights.Agent.Intercept" version="2.0.6" targetFramework="net45" />

‎examples/aspnetcore11-mvc/Controllers/HomeController.cs

Lines changed: 46 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,55 @@
1-
using System;
1+
using System;
22
using System.Collections.Generic;
3-
using System.Linq;
4-
using System.Threading.Tasks;
53
using Microsoft.AspNetCore.Mvc;
64
using Bugsnag;
75

86
namespace aspnetcore11_mvc.Controllers
97
{
10-
public class HomeController : Controller
8+
public class HomeController : Controller
9+
{
10+
private readonly IClient _client;
11+
private Dictionary<string, string> _messageLookup = new Dictionary<string, string>()
1112
{
12-
private readonly IClient _client;
13-
14-
public HomeController(IClient client)
15-
{
16-
_client = client;
17-
}
18-
19-
public IActionResult Index()
20-
{
21-
return View();
22-
}
23-
24-
public IActionResult About()
25-
{
26-
_client.Breadcrumbs.Leave("Here comes the exception...");
27-
throw new NotImplementedException();
28-
}
29-
30-
public IActionResult Contact()
31-
{
32-
ViewData["Message"] = "Your contact page.";
33-
34-
return View();
35-
}
36-
37-
public IActionResult Error()
38-
{
39-
return View();
40-
}
13+
{
14+
"Contact", "Contact page"
15+
}
16+
};
17+
18+
public HomeController(IClient client)
19+
{
20+
_client = client;
21+
22+
}
23+
24+
public IActionResult Index()
25+
{
26+
return View();
27+
}
28+
29+
public IActionResult About()
30+
{
31+
_client.Breadcrumbs.Leave("Here comes the exception...");
32+
throw new NotImplementedException();
33+
}
34+
35+
public IActionResult Contact()
36+
{
37+
try
38+
{
39+
ViewData["Message"] = _messageLookup["Cotnact"];
40+
}
41+
catch (Exception e)
42+
{
43+
_client.Notify(e);
44+
ViewData["Message"] = "Your contact page.";
45+
}
46+
47+
return View();
48+
}
49+
50+
public IActionResult Error()
51+
{
52+
return View();
4153
}
54+
}
4255
}

‎examples/aspnetcore11-mvc/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ services.AddBugsnag(config => {
1919
});
2020
```
2121

22-
From within Visual Studio you can compile and start the website.
22+
From within Visual Studio you can compile and start the website. Once the index page loads:
23+
- Navigating to About will invoke an unhandled exception
24+
- Navigating to Contact will invoke a handled exception
2325

2426
### Steps taken to install Bugsnag
2527

0 commit comments

Comments
 (0)