Skip to content

Commit 88f7a19

Browse files
committed
rename Parser methods
1 parent 5ef1777 commit 88f7a19

File tree

8 files changed

+15
-14
lines changed

8 files changed

+15
-14
lines changed

pkg/handlers/loop/handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,12 @@ func (h *Handler) Name() string {
3434

3535
func (h *Handler) Init(p handlers.Parser) error {
3636
var err error
37-
h.Nested[0], err = p.Next()
37+
h.Nested[0], err = p.NextHandler()
3838
if err != nil {
3939
return err
4040
}
4141

42-
h.Nested[1], err = p.Next()
42+
h.Nested[1], err = p.NextHandler()
4343
if err != nil {
4444
return err
4545
}

pkg/handlers/notify/handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func (h *Handler) Init(p handlers.Parser) error {
3939
return err
4040
}
4141

42-
h.Nested, err = p.Next()
42+
h.Nested, err = p.NextHandler()
4343
if err != nil {
4444
return err
4545
}

pkg/handlers/parser.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
package handlers
22

33
type Parser interface {
4-
All() ([]Handler, error)
5-
Next() (Handler, error)
4+
RestHandlers() ([]Handler, error)
5+
NextHandler() (Handler, error)
6+
NextValue() (string, error)
67
RestValues() ([]string, error)
78
NextRaw() (string, error)
89
FQDN() string

pkg/handlers/parser/parser.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func (p *Parser) FQDN() string {
5151
return p.fqdn
5252
}
5353

54-
func (p *Parser) Next() (handlers.Handler, error) {
54+
func (p *Parser) NextHandler() (handlers.Handler, error) {
5555
if p.cur >= p.maxLabel {
5656
return nil, handlers.ErrEOF
5757
}
@@ -103,10 +103,10 @@ func (p *Parser) RestValues() ([]string, error) {
103103
}
104104
}
105105

106-
func (p *Parser) All() ([]handlers.Handler, error) {
106+
func (p *Parser) RestHandlers() ([]handlers.Handler, error) {
107107
var out []handlers.Handler
108108
for {
109-
h, err := p.Next()
109+
h, err := p.NextHandler()
110110
if h == nil {
111111
return out, nil
112112
}

pkg/handlers/parser/parser_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ func TestParser(t *testing.T) {
223223

224224
for _, tc := range cases {
225225
t.Run(tc.in, func(t *testing.T) {
226-
hndlrs, err := parser.NewParser(tc.in, "").All()
226+
hndlrs, err := parser.NewParser(tc.in, "").RestHandlers()
227227
require.NoError(t, err)
228228
require.EqualValues(t, tc.handlers, hndlrs)
229229
})

pkg/handlers/random/handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,12 @@ func (h *Handler) Name() string {
3535

3636
func (h *Handler) Init(p handlers.Parser) error {
3737
var err error
38-
h.Nested[0], err = p.Next()
38+
h.Nested[0], err = p.NextHandler()
3939
if err != nil {
4040
return err
4141
}
4242

43-
h.Nested[1], err = p.Next()
43+
h.Nested[1], err = p.NextHandler()
4444
if err != nil {
4545
return err
4646
}

pkg/handlers/sticky/handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,12 @@ func (h *Handler) Name() string {
3434

3535
func (h *Handler) Init(p handlers.Parser) error {
3636
var err error
37-
h.Nested[0], err = p.Next()
37+
h.Nested[0], err = p.NextHandler()
3838
if err != nil {
3939
return err
4040
}
4141

42-
h.Nested[1], err = p.Next()
42+
h.Nested[1], err = p.NextHandler()
4343
if err != nil {
4444
return err
4545
}

pkg/nssrv/handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func (s *NSSrv) handleRequest(zone string, req *dns.Msg, logger *log.Logger) *dn
4848
return item.Value().(*cachedHandler), nil
4949
}
5050

51-
h, err := parser.NewParser(question.Name, zone).Next()
51+
h, err := parser.NewParser(question.Name, zone).NextHandler()
5252
if err != nil {
5353
if err != handlers.ErrEOF {
5454
return nil, err

0 commit comments

Comments
 (0)