Skip to content

Commit 7500951

Browse files
authored
chore: reduce info log verbosity in all services (#2170)
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
1 parent 41d5a0f commit 7500951

File tree

6 files changed

+2
-23
lines changed

6 files changed

+2
-23
lines changed

manifests/bucketeer/charts/batch/templates/cronjob.yaml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,8 @@ spec:
6565
rm -f ${RESPONSE}
6666
END_TIME=$(date +%s)
6767
DURATION=$((END_TIME - START_TIME))
68-
# API returns empty {} on success, or error details on failure
69-
if [ "${RES}" = "200" ]; then
70-
# Success - use DEBUG to avoid verbose logs
71-
echo '{"severity":"DEBUG","message":"'${JOB_NAME}' job completed successfully","job":"'${JOB_NAME}'","jobId":"'${JOB_ID}'","statusCode":'${RES}',"durationSeconds":'${DURATION}'}'
72-
else
68+
# Only log on failure - success is silent
69+
if [ "${RES}" != "200" ]; then
7370
# Failure - log as ERROR with response details for debugging
7471
BODY_ESCAPED=$(echo "${BODY}" | sed 's/\\/\\\\/g; s/"/\\"/g' | tr '\n\r\t' ' ')
7572
echo '{"severity":"ERROR","message":"'${JOB_NAME}' job failed","job":"'${JOB_NAME}'","jobId":"'${JOB_ID}'","statusCode":'${RES}',"durationSeconds":'${DURATION}',"responseBody":"'${BODY_ESCAPED}'"}'

pkg/api/cmd/server.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,6 @@ func (s *server) Run(ctx context.Context, metrics metrics.Metrics, logger *zap.L
566566

567567
defer func() {
568568
shutdownStartTime := time.Now()
569-
logger.Info("Starting graceful shutdown sequence")
570569

571570
// Wait for K8s endpoint propagation
572571
// This prevents "context deadline exceeded" errors during high traffic.

pkg/batch/cmd/server/server.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,6 @@ func (s *server) Run(ctx context.Context, metrics metrics.Metrics, logger *zap.L
631631

632632
defer func() {
633633
shutdownStartTime := time.Now()
634-
logger.Info("Starting graceful shutdown sequence")
635634

636635
// Wait for K8s endpoint propagation
637636
// This prevents "context deadline exceeded" errors during high traffic.

pkg/rpc/server.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -139,27 +139,18 @@ func (s *Server) Run() {
139139
}
140140

141141
func (s *Server) Stop(timeout time.Duration) {
142-
shutdownStart := time.Now()
143-
s.logger.Info("Starting server graceful shutdown",
144-
zap.String("server", s.name),
145-
zap.Duration("timeout", timeout))
146-
147142
// Shutdown order is critical:
148143
// 1. HTTP server first (drains REST/gRPC-Gateway requests)
149144
// 2. gRPC server second (only pure gRPC connections remain)
150145
//
151146
// This ensures HTTP requests that call s.rpcServer.ServeHTTP() can complete
152147
// before we stop the underlying gRPC server.
153148
if s.httpServer != nil {
154-
s.logger.Info("Starting HTTP server graceful shutdown")
155-
156149
ctx, cancel := context.WithTimeout(context.Background(), timeout)
157150
defer cancel()
158151

159152
if err := s.httpServer.Shutdown(ctx); err != nil {
160153
s.logger.Error("HTTP server failed to shut down gracefully", zap.Error(err))
161-
} else {
162-
s.logger.Info("HTTP server shutdown completed gracefully")
163154
}
164155
}
165156

@@ -168,13 +159,8 @@ func (s *Server) Stop(timeout time.Duration) {
168159
// - HTTP-served connections were already drained in step 1
169160
// - Pure gRPC clients have retry logic and Envoy connection draining to handle this
170161
if s.rpcServer != nil {
171-
s.logger.Info("Stopping gRPC server")
172162
s.rpcServer.Stop()
173163
}
174-
175-
s.logger.Info("Server shutdown completed",
176-
zap.String("server", s.name),
177-
zap.Duration("total_duration", time.Since(shutdownStart)))
178164
}
179165

180166
func (s *Server) setupRPC() {

pkg/subscriber/cmd/server/server.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,6 @@ func (s *server) Run(ctx context.Context, metrics metrics.Metrics, logger *zap.L
362362

363363
defer func() {
364364
shutdownStartTime := time.Now()
365-
logger.Info("Starting graceful shutdown sequence")
366365

367366
// Mark as unhealthy so readiness probes fail
368367
// This ensures Kubernetes readiness probe fails on next check,

pkg/web/cmd/server/server.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -860,7 +860,6 @@ func (s *server) Run(ctx context.Context, metrics metrics.Metrics, logger *zap.L
860860

861861
defer func() {
862862
shutdownStartTime := time.Now()
863-
logger.Info("Starting graceful shutdown sequence")
864863

865864
// Wait for K8s endpoint propagation
866865
// This prevents "context deadline exceeded" errors during high traffic.

0 commit comments

Comments
 (0)