update: prevent duplicate orders by checking if payment is in transit before restoring quote

Author: vegimcarkaxhija

Model/Method/AbstractMethod.php

@@ -834,8 +834,8 @@ public function order(InfoInterface $payment, $amount)
 
         if (!(isset($response[0]->RequiredAction->Type) && $response[0]->RequiredAction->Type === 'Redirect')) {
             $this->setPaymentInTransit($payment, false);
+            $this->helper->setRestoreQuoteLastOrder($order->getId());
         }
-        $this->helper->setRestoreQuoteLastOrder($order->getId());
 
         $this->eventManager->dispatch('buckaroo_order_after', ['order' => $order]);
 

Observer/RestoreQuote.php

@@ -22,6 +22,7 @@
 namespace Buckaroo\Magento2\Observer;
 
 use Buckaroo\Magento2\Helper\Data;
+use Buckaroo\Magento2\Model\Method\AbstractMethod;
 use Magento\Checkout\Model\Session;
 use Buckaroo\Magento2\Model\Service\Order;
 use Buckaroo\Magento2\Model\Method\Payconiq;
@@ -154,6 +155,11 @@ private function processShippingAddress($quote)
      */
     private function shouldRestoreQuote($lastRealOrder, $payment)
     {
+        if ($payment->getAdditionalInformation(AbstractMethod::BUCKAROO_PAYMENT_IN_TRANSIT) === true) {
+            $this->helper->addDebug(__METHOD__ . '|Payment in transit, not restoring quote to prevent duplicate orders');
+            return false;
+        }
+
         return (
             ($this->helper->getRestoreQuoteLastOrder() &&
                 ($lastRealOrder->getData('state') === 'new') &&