fixed bug when the list of games scrolled to beginning after installing the game

Author: btimofeev

CHANGELOG.md

@@ -1,10 +1,12 @@
 # Changelog
 
-## [Next] - 2021-?-?
+## [0.8.4] - 2021-?-?
 ### Changed
 - update INSTEAD 3.3.3
 ### Fixed
-- overlapping buttons
+- fixed a bug when the list of games scrolled to the beginning after installing the game
+- fixed overlapping buttons in the about game screen
+- fixed clipping of text with large font
 
 ## [0.8.3] - 2020-11-05
 ### Added

app/src/main/kotlin/org/emunix/insteadlauncher/data/GameDiffCallback.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019 Boris Timofeev <btimofeev@emunix.org>
+ * Copyright (c) 2019-2021 Boris Timofeev <btimofeev@emunix.org>
  * Distributed under the MIT License (license terms are at http://opensource.org/licenses/MIT).
  */
 
@@ -10,33 +10,11 @@ import androidx.recyclerview.widget.DiffUtil
 
 class GameDiffCallback : DiffUtil.ItemCallback<Game>() {
 
-    enum class Diff {
-        IMAGE, TITLE, BRIEF, VERSION
-    }
-
     override fun areItemsTheSame(oldItem: Game, newItem: Game): Boolean {
-        return oldItem.name === newItem.name
+        return oldItem.name == newItem.name
     }
 
     override fun areContentsTheSame(oldItem: Game, newItem: Game): Boolean {
         return oldItem == newItem
     }
-
-    override fun getChangePayload(oldItem: Game, newItem: Game): List<Diff> {
-        val diff = mutableListOf<Diff>()
-
-        if (newItem.image != oldItem.image)
-            diff.add(Diff.IMAGE)
-
-        if (newItem.title != oldItem.title)
-            diff.add(Diff.TITLE)
-
-        if (newItem.brief != oldItem.brief)
-            diff.add(Diff.BRIEF)
-
-        if (newItem.version != oldItem.version || newItem.installedVersion != oldItem.installedVersion)
-            diff.add(Diff.VERSION)
-
-        return diff
-    }
 }

app/src/main/kotlin/org/emunix/insteadlauncher/ui/installedgames/InstalledGamesAdapter.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018-2019 Boris Timofeev <btimofeev@emunix.org>
+ * Copyright (c) 2018-2021 Boris Timofeev <btimofeev@emunix.org>
  * Distributed under the MIT License (license terms are at http://opensource.org/licenses/MIT).
  */
 
@@ -16,7 +16,6 @@ import org.emunix.insteadlauncher.data.Game
 import org.emunix.insteadlauncher.helpers.loadUrl
 import androidx.recyclerview.widget.ListAdapter
 import org.emunix.insteadlauncher.data.GameDiffCallback
-import org.emunix.insteadlauncher.data.GameDiffCallback.Diff
 
 class InstalledGamesAdapter(val onClickListener: (Game) -> Unit) : ListAdapter<Game, InstalledGamesAdapter.ViewHolder>(GameDiffCallback()) {
 
@@ -43,20 +42,6 @@ class InstalledGamesAdapter(val onClickListener: (Game) -> Unit) : ListAdapter<G
         }
     }
 
-    override fun onBindViewHolder(holder: ViewHolder, position: Int, payloads: MutableList<Any>) {
-        if (payloads.isEmpty()) {
-            onBindViewHolder(holder, position)
-        } else {
-            val diff = payloads[0] as List<Diff>
-            for (key in diff) {
-                when (key) {
-                    Diff.IMAGE -> holder.image.loadUrl(getItem(position).image)
-                    Diff.BRIEF -> getItem(position).title
-                }
-            }
-        }
-    }
-
     override fun onViewRecycled(holder: ViewHolder) {
         holder.itemView.setOnLongClickListener(null)
         super.onViewRecycled(holder)

app/src/main/kotlin/org/emunix/insteadlauncher/ui/repository/RepositoryAdapter.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018 Boris Timofeev <btimofeev@emunix.org>
+ * Copyright (c) 2018-2021 Boris Timofeev <btimofeev@emunix.org>
  * Distributed under the MIT License (license terms are at http://opensource.org/licenses/MIT).
  */
 
@@ -10,13 +10,11 @@ import android.view.View
 import android.view.ViewGroup
 import android.widget.ImageView
 import android.widget.TextView
-import androidx.core.view.ViewCompat
 import androidx.recyclerview.widget.ListAdapter
 import androidx.recyclerview.widget.RecyclerView
 import org.emunix.insteadlauncher.R
 import org.emunix.insteadlauncher.data.Game
 import org.emunix.insteadlauncher.data.GameDiffCallback
-import org.emunix.insteadlauncher.data.GameDiffCallback.Diff
 import org.emunix.insteadlauncher.helpers.loadUrl
 import org.emunix.insteadlauncher.helpers.visible
 
@@ -41,23 +39,6 @@ class RepositoryAdapter(val listener: (Game, ImageView) -> Unit): ListAdapter<Ga
         updateBadge(holder, position)
     }
 
-    override fun onBindViewHolder(holder: ViewHolder, position: Int, payloads: MutableList<Any>) {
-        ViewCompat.setTransitionName(holder.image, getItem(position).name)
-        if (payloads.isEmpty()) {
-            onBindViewHolder(holder, position)
-        } else {
-            val diff = payloads[0] as List<Diff>
-            for (key: Diff in diff) {
-                when (key) {
-                    Diff.IMAGE -> updateImage(holder, position)
-                    Diff.TITLE -> holder.name.text = getItem(position).title
-                    Diff.BRIEF -> holder.description.text = getItem(position).brief
-                    Diff.VERSION -> updateBadge(holder, position)
-                }
-            }
-        }
-    }
-
     override fun getItemId(position: Int): Long {
         return getItem(position).name.hashCode().toLong()
     }