Merge branch 'release-3.4.2' into release-3.5.0

Author: chikara1608

lib/checks/color/link-in-text-block-evaluate.js

@@ -135,6 +135,14 @@ function getColorContrast(node, parentBlock) {
   nodeColor = getForegroundColor(node);
   parentColor = getForegroundColor(parentBlock);
 
+  if (!nodeColor) {
+    nodeColor = new axe.commons.color.Color(0, 0, 0, 0);
+  }
+
+  if (!parentColor) {
+    parentColor = new axe.commons.color.Color(0, 0, 0, 0);
+  }
+
   if (!nodeColor || !parentColor) {
     return undefined;
   }

lib/commons/aria/ariadescribedby-text.js

@@ -0,0 +1,46 @@
+/**
+ * Get the accessible name based on aria-describedby
+ *
+ * @deprecated Do not use Element directly. Pass VirtualNode instead
+ * @param {VirtualNode|Element} element
+ * @param {Object} context
+ * @property {Bool} inLabelledByContext Whether or not the lookup is part of aria-describedby reference
+ * @property {Bool} inControlContext Whether or not the lookup is part of a native label reference
+ * @property {Element} startNode First node in accessible name computation
+ * @property {Bool} debug Enable logging for formControlValue
+ * @return {string} Concatenated text value for referenced elements
+ */
+function ariadescribedbyText(element, context = {}) {
+  const { vNode } = axe.utils.nodeLookup(element);
+  if (vNode?.props.nodeType !== 1) {
+    return '';
+  }
+
+  if (
+    vNode.props.nodeType !== 1 ||
+    context.inLabelledByContext ||
+    context.inControlContext ||
+    !vNode.attr('aria-describedby')
+  ) {
+    return '';
+  }
+
+  const refs = axe.commons.dom
+    .idrefs(vNode, 'aria-describedby')
+    .filter(elm => elm);
+  return refs.reduce((accessibleName, elm) => {
+    const accessibleNameAdd = axe.commons.text.accessibleText(elm, {
+      // Prevent the infinite reference loop:
+      inLabelledByContext: true,
+      startNode: context.startNode || vNode,
+      ...context
+    });
+
+    if (!accessibleName) {
+      return accessibleNameAdd;
+    }
+    return `${accessibleName} ${accessibleNameAdd}`;
+  }, '');
+}
+
+export default ariadescribedbyText;

lib/commons/aria/index.js

@@ -6,6 +6,7 @@
 export { default as allowedAttr } from './allowed-attr';
 export { default as arialabelText } from './arialabel-text';
 export { default as arialabelledbyText } from './arialabelledby-text';
+export { default as ariadescribedbyText } from './ariadescribedby-text';
 export { default as getAccessibleRefs } from './get-accessible-refs';
 export { default as getElementUnallowedRoles } from './get-element-unallowed-roles';
 export { default as getExplicitRole } from './get-explicit-role';

lib/core/utils/dq-element.js

@@ -26,7 +26,11 @@ function getSource(element) {
   if (!source && typeof window.XMLSerializer === 'function') {
     source = new window.XMLSerializer().serializeToString(element);
   }
-  return truncate(source || '');
+  let htmlString = truncate(source || '');
+  // Remove unwanted attributes
+  const regex = /\s*data-percy-[^=]+="[^"]*"/g;
+  htmlString = htmlString.replace(regex, '');
+  return htmlString;
 }
 
 /**

lib/rules/autocomplete-a11y-matches.js

@@ -57,14 +57,50 @@ function nodeIsASearchFunctionality(actualNode, currLevel = 0, maxLevels = 4) {
   return currentLevelSearch(actualNode, currLevel);
 }
 
+function quantityField(node) {
+  const keywords = [
+    'qty',
+    'quantity',
+    'quantities',
+    'km',
+    'kilometer',
+    'drive',
+    'code',
+    'mileage',
+    'power',
+    'fuel'
+  ];
+  const attributes = [
+    'name',
+    'id',
+    'title',
+    'placeholder',
+    'aria-label',
+    'data-label',
+    'data-title',
+    'data-placeholder',
+    'role'
+  ];
+  return attributes.some(attr => {
+    if (node.hasAttribute(attr)) {
+      const value = node.getAttribute(attr).toLowerCase();
+      return keywords.some(
+        keyword => value && value.includes(keyword.toLowerCase())
+      );
+    }
+    return false;
+  });
+}
+
 function autocompleteA11yMatches(node, virtualNode) {
   const a11yEngineFlag = true;
   /* the flag is used to tell autocomplete matcher that it is being called 
   by a11y-engine and thus bypass an if block 
   The second condition is to check we are not matching with search functionality */
   return (
     autocompleteMatches(node, virtualNode, a11yEngineFlag) &&
-    !nodeIsASearchFunctionality(node)
+    !nodeIsASearchFunctionality(node) &&
+    !quantityField(node)
   );
 }