Skip to content

Commit 5370d4c

Browse files
authored
autocomplete enhancement fixes (#126)
1 parent ab7f795 commit 5370d4c

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

lib/rules/autocomplete-a11y-matches.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,14 @@ function quantityField(node) {
9292
});
9393
}
9494

95+
function isReadOnly(node) {
96+
return node.hasAttribute('readonly');
97+
}
98+
99+
function isCombobox(node) {
100+
return node.getAttribute('role') === 'combobox';
101+
}
102+
95103
function autocompleteA11yMatches(node, virtualNode) {
96104
const a11yEngineFlag = true;
97105
/* the flag is used to tell autocomplete matcher that it is being called
@@ -100,7 +108,9 @@ function autocompleteA11yMatches(node, virtualNode) {
100108
return (
101109
autocompleteMatches(node, virtualNode, a11yEngineFlag) &&
102110
!nodeIsASearchFunctionality(node) &&
103-
!quantityField(node)
111+
!quantityField(node) &&
112+
!isReadOnly(node) &&
113+
!isCombobox(node)
104114
);
105115
}
106116

0 commit comments

Comments
 (0)