Skip to content

Commit 818a552

Browse files
authored
Fix login settings parsing (#87)
1 parent a631974 commit 818a552

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/background.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -778,7 +778,7 @@ async function parseFields(settings, login) {
778778
for (var key in login.fields) {
779779
if (
780780
Array.isArray(login.fields[key]) &&
781-
login.fields[key].indexOf(parts[0].toLowerCase()) >= 0
781+
login.fields[key].includes(parts[0].toLowerCase())
782782
) {
783783
login.fields[key] = parts[1];
784784
break;
@@ -789,7 +789,7 @@ async function parseFields(settings, login) {
789789
for (var key in login.settings) {
790790
if (
791791
typeof login.settings[key].type !== "undefined" &&
792-
login.settings[key].name.indexOf(parts[0].toLowerCase()) >= 0
792+
login.settings[key].name === parts[0].toLowerCase()
793793
) {
794794
if (login.settings[key].type === "bool") {
795795
login.settings[key] = ["true", "yes"].includes(parts[1].toLowerCase());
@@ -805,9 +805,9 @@ async function parseFields(settings, login) {
805805
// clean up unassigned fields
806806
for (var key in login.fields) {
807807
if (Array.isArray(login.fields[key])) {
808-
if (key == "secret" && lines.length) {
808+
if (key === "secret" && lines.length) {
809809
login.fields.secret = lines[0];
810-
} else if (key == "login") {
810+
} else if (key === "login") {
811811
const defaultUsername = getSetting("username", login, settings);
812812
login.fields[key] = defaultUsername || login.login.match(/([^\/]+)$/)[1];
813813
} else {
@@ -905,14 +905,14 @@ function onExtensionInstalled(details) {
905905
});
906906
};
907907

908-
if (details.reason == "install") {
908+
if (details.reason === "install") {
909909
show(
910910
"installed",
911911
"browserpass: Install native host app",
912912
"Remember to install the complementary native host app to use this extension.\n" +
913913
"Instructions here: https://github.com/browserpass/browserpass-native"
914914
);
915-
} else if (details.reason == "update") {
915+
} else if (details.reason === "update") {
916916
var changelog = {
917917
3000000:
918918
"New major update is out, please update the native host app to v3.\n" +

0 commit comments

Comments
 (0)