Skip to content

Commit cbbceeb

Browse files
committed
cleanup
1 parent 27e2e4d commit cbbceeb

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

v03_pipeline/lib/tasks/base/base_task.py renamed to v03_pipeline/lib/tasks/base/base_hail_table_task.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
logger = get_logger(__name__)
99

10-
class BaseTask(luigi.Task):
10+
class BaseHailTableTask(luigi.Task):
1111
reference_genome = luigi.EnumParameter(enum=ReferenceGenome)
1212
dataset_type = luigi.EnumParameter(enum=DatasetType)
1313
sample_type = luigi.EnumParameter(enum=SampleType)
@@ -25,6 +25,8 @@ def init_hail(self):
2525
# Interval ref data join causes shuffle death, this prevents it
2626
hl._set_flags(use_new_shuffle='1', no_whole_stage_codegen='1') # noqa: SLF001
2727

28+
# NB: these are defined over luigi.Task instead of the BaseHailTableTask so that
29+
# they work on file dependencies.
2830
@luigi.Task.event_handler(luigi.Event.DEPENDENCY_MISSING)
2931
def dependency_missing(task):
3032
logger.info(f'{task} dependency_missing')

v03_pipeline/lib/tasks/base/base_update_task.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import hail as hl
22

33
from v03_pipeline.lib.misc.io import write
4-
from v03_pipeline.lib.tasks.base.base_task import BaseTask
4+
from v03_pipeline.lib.tasks.base.base_hail_table_task import BaseHailTableTask
55

66

7-
class BaseUpdateTask(BaseTask):
7+
class BaseUpdateTask(BaseHailTableTask):
88
def run(self) -> None:
99
self.init_hail()
1010
if not self.output().exists():

v03_pipeline/lib/tasks/base/base_write_task.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import hail as hl
22

33
from v03_pipeline.lib.misc.io import write
4-
from v03_pipeline.lib.tasks.base.base_task import BaseTask
4+
from v03_pipeline.lib.tasks.base.base_hail_table_task import BaseHailTableTask
55

66

7-
class BaseWriteTask(BaseTask):
7+
class BaseWriteTask(BaseHailTableTask):
88
def run(self) -> None:
99
self.init_hail()
1010
ht = self.create_table()

0 commit comments

Comments
 (0)