Skip to content

Commit cb8b974

Browse files
committed
more scaffolding
1 parent 93cadea commit cb8b974

File tree

3 files changed

+9
-17
lines changed

3 files changed

+9
-17
lines changed

v03_pipeline/lib/tasks/base/base_loading_params.py renamed to v03_pipeline/lib/tasks/base/base_loading_run_params.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from v03_pipeline.lib.model import SampleType
44

55

6-
class BaseLoadingParams(luigi.Task):
6+
class BaseLoadingRunParams(luigi.Task):
77
# NB:
88
# These params are "inherited" with the special
99
# luigi.util.inherits function, copying params

v03_pipeline/lib/tasks/write_imported_callset.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import hail as hl
22
import luigi
3+
import luigi.util
34

45
from v03_pipeline.lib.misc.io import (
56
import_callset,
@@ -22,7 +23,7 @@
2223
imported_callset_path,
2324
sex_check_table_path,
2425
)
25-
from v03_pipeline.lib.tasks.base.base_loading_params import BaseLoadingParams
26+
from v03_pipeline.lib.tasks.base.base_loading_run_params import BaseLoadingRunParams
2627
from v03_pipeline.lib.tasks.base.base_write import BaseWriteTask
2728
from v03_pipeline.lib.tasks.files import CallsetTask, GCSorLocalTarget, HailTableTask
2829
from v03_pipeline.lib.tasks.reference_data.updated_cached_reference_dataset_query import (
@@ -31,7 +32,7 @@
3132
from v03_pipeline.lib.tasks.write_sex_check_table import WriteSexCheckTableTask
3233

3334

34-
@luigi.util.inherits(BaseLoadingParams)
35+
@luigi.util.inherits(BaseLoadingRunParams)
3536
class WriteImportedCallsetTask(BaseWriteTask):
3637
def complete(self) -> luigi.Target:
3738
if not self.force and super().complete():

v03_pipeline/lib/tasks/write_relatedness_check_table.py

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,12 @@
22
import luigi
33

44
from v03_pipeline.lib.methods.relatedness import call_relatedness
5-
from v03_pipeline.lib.model import CachedReferenceDatasetQuery, Env, SampleType
5+
from v03_pipeline.lib.model import CachedReferenceDatasetQuery, Env
66
from v03_pipeline.lib.paths import (
77
cached_reference_dataset_query_path,
88
relatedness_check_table_path,
99
)
10+
from v03_pipeline.lib.tasks.base.base_loading_run_params import BaseLoadingRunParams
1011
from v03_pipeline.lib.tasks.base.base_write import BaseWriteTask
1112
from v03_pipeline.lib.tasks.files import GCSorLocalTarget, HailTableTask
1213
from v03_pipeline.lib.tasks.reference_data.updated_cached_reference_dataset_query import (
@@ -15,10 +16,8 @@
1516
from v03_pipeline.lib.tasks.write_imported_callset import WriteImportedCallsetTask
1617

1718

19+
@luigi.util.inherits(BaseLoadingRunParams)
1820
class WriteRelatednessCheckTableTask(BaseWriteTask):
19-
sample_type = luigi.EnumParameter(enum=SampleType)
20-
callset_path = luigi.Parameter()
21-
2221
def output(self) -> luigi.Target:
2322
return GCSorLocalTarget(
2423
relatedness_check_table_path(
@@ -30,21 +29,13 @@ def output(self) -> luigi.Target:
3029

3130
def requires(self) -> luigi.Task:
3231
requirements = [
33-
WriteImportedCallsetTask(
34-
self.reference_genome,
35-
self.dataset_type,
36-
self.callset_path,
37-
),
32+
self.clone(WriteImportedCallsetTask),
3833
]
3934
if Env.ACCESS_PRIVATE_REFERENCE_DATASETS:
4035
requirements = [
4136
*requirements,
4237
(
43-
UpdatedCachedReferenceDatasetQuery(
44-
reference_genome=self.reference_genome,
45-
dataset_type=self.dataset_type,
46-
crdq=CachedReferenceDatasetQuery.GNOMAD_QC,
47-
)
38+
self.clone(UpdatedCachedReferenceDatasetQuery, crdq=CachedReferenceDatasetQuery.GNOMAD_QC)
4839
if Env.REFERENCE_DATA_AUTO_UPDATE
4940
else HailTableTask(
5041
cached_reference_dataset_query_path(

0 commit comments

Comments
 (0)