Skip to content

Commit c1a040f

Browse files
authored
Merge pull request #796 from broadinstitute/dev
main <- dev
2 parents b3995d8 + ff56115 commit c1a040f

File tree

6 files changed

+8
-5
lines changed

6 files changed

+8
-5
lines changed

v03_pipeline/lib/misc/family_loading_failures.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,10 @@ def get_families_failed_sex_check(
175175
failed_families = defaultdict(list)
176176
for family in families:
177177
for sample_id in family.samples:
178-
if family.samples[sample_id].sex != sex_check_lookup[sample_id]:
178+
if family.samples[sample_id].sex not in {
179+
sex_check_lookup[sample_id],
180+
Sex.UNKNOWN,
181+
}: # NB: Unknown samples in pedigree are excluded from sex check.
179182
failed_families[family].append(
180183
f'Sample {sample_id} has pedigree sex {family.samples[sample_id].sex.value} but imputed sex {sex_check_lookup[sample_id].value}',
181184
)

v03_pipeline/lib/misc/family_loading_failures_test.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,6 @@ def test_get_families_failed_sex_check(self):
202202
[
203203
[
204204
'Sample ROS_006_18Y03226_D1 has pedigree sex F but imputed sex M',
205-
'Sample ROS_006_18Y03227_D1 has pedigree sex M but imputed sex F',
206205
],
207206
],
208207
)

v03_pipeline/lib/misc/pedigree_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ def test_parse_project(self) -> None:
316316
samples={
317317
'BBL_BC1-000345_01_D1': Sample(
318318
sample_id='BBL_BC1-000345_01_D1',
319-
sex=Sex.FEMALE,
319+
sex=Sex.UNKNOWN,
320320
mother='BBL_BC1-000345_03_D1',
321321
father='BBL_BC1-000345_02_D1',
322322
maternal_grandmother=None,

v03_pipeline/lib/model/definitions.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ class AccessControl(Enum):
1111
class Sex(Enum):
1212
FEMALE = 'F'
1313
MALE = 'M'
14+
UNKNOWN = 'U'
1415

1516

1617
class PipelineVersion(Enum):

v03_pipeline/var/test/pedigrees/test_pedigree_2.tsv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ R0111_tgg_bblanken_wes BBL_HT-007-5195_1 BBL_HT-007-5195 BBL_HT-007-5195_03_D1
66
R0111_tgg_bblanken_wes BBL_HT-007-5195_1 BBL_HT-007-5195 BBL_HT-007-5195_04_D1 BBL_HT-007-5195_02_D1 BBL_HT-007-5195_03_D1 M
77
R0111_tgg_bblanken_wes BBL_HT-007-5195_1 BBL_HT-007-5195 BBL_HT-007-5195_05_D1 BBL_HT-007-5195_02_D1 BBL_HT-007-5195_03_D1 F
88
R0111_tgg_bblanken_wes BBL_HT-007-5195_1 BBL_HT-007-5195 BBL_HT-007-5195_06_D1 BBL_HT-007-5195_02_D1 BBL_HT-007-5195_03_D1 M
9-
R0111_tgg_bblanken_wes BBL_BC1-000345_1 BBL_BC1-000345 BBL_BC1-000345_01_D1 BBL_BC1-000345_02_D1 BBL_BC1-000345_03_D1 F
9+
R0111_tgg_bblanken_wes BBL_BC1-000345_1 BBL_BC1-000345 BBL_BC1-000345_01_D1 BBL_BC1-000345_02_D1 BBL_BC1-000345_03_D1 U
1010
R0111_tgg_bblanken_wes BBL_BC1-000345_1 BBL_BC1-000345 BBL_BC1-000345_02_D1 M
1111
R0111_tgg_bblanken_wes BBL_BC1-000345_1 BBL_BC1-000345 BBL_BC1-000345_03_D1 F

v03_pipeline/var/test/pedigrees/test_pedigree_6.tsv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Project_GUID Family_GUID Family_ID Individual_ID Paternal_ID Maternal_ID Sex
22
R0116_sex_check_project2 family_1 family_1 ROS_006_18Y03226_D1 F
3-
R0116_sex_check_project2 family_1 family_1 ROS_006_18Y03227_D1 M
3+
R0116_sex_check_project2 family_1 family_1 ROS_006_18Y03227_D1 U
44
R0116_sex_check_project2 family_1 family_1 ROS_006_18Y03228_D1 ROS_006_18Y03226_D1 ROS_006_18Y03227_D1 F
55
R0116_sex_check_project2 family_2 family_2 ROS_007_19Y05919_D1 F
66
R0116_sex_check_project2 family_2 family_2 ROS_007_19Y05939_D1 F

0 commit comments

Comments
 (0)