Skip to content

Commit 5dc7972

Browse files
authored
add some logging (#741)
1 parent 92ad4a7 commit 5dc7972

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

v03_pipeline/lib/tasks/base/base_hail_table_task.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ def output(self) -> luigi.Target:
1717
raise NotImplementedError
1818

1919
def complete(self) -> bool:
20+
logger.info(f'BaseHailTableTask: checking if {self.output().path} exists')
2021
return GCSorLocalFolderTarget(self.output().path).exists()
2122

2223
def init_hail(self):
@@ -33,7 +34,7 @@ def init_hail(self):
3334

3435
@luigi.Task.event_handler(luigi.Event.DEPENDENCY_DISCOVERED)
3536
def dependency_discovered(task, dependency):
36-
logger.info(f'{task} dependency_discovered {dependency}')
37+
logger.info(f'{task} dependency_discovered {dependency} at {task.output()}')
3738

3839

3940
@luigi.Task.event_handler(luigi.Event.DEPENDENCY_MISSING)
@@ -43,7 +44,7 @@ def dependency_missing(task):
4344

4445
@luigi.Task.event_handler(luigi.Event.DEPENDENCY_PRESENT)
4546
def dependency_present(task):
46-
logger.info(f'{task} dependency_present')
47+
logger.info(f'{task} dependency_present at {task.output()}')
4748

4849

4950
@luigi.Task.event_handler(luigi.Event.START)

v03_pipeline/lib/tasks/reference_data/updated_cached_reference_dataset_query.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import hail as hl
22
import luigi
33

4+
from v03_pipeline.lib.logger import get_logger
45
from v03_pipeline.lib.model import (
56
CachedReferenceDatasetQuery,
67
Env,
@@ -25,12 +26,17 @@
2526
UpdatedReferenceDatasetCollectionTask,
2627
)
2728

29+
logger = get_logger(__name__)
30+
2831

2932
class UpdatedCachedReferenceDatasetQuery(BaseWriteTask):
3033
crdq = luigi.EnumParameter(enum=CachedReferenceDatasetQuery)
3134

3235
def complete(self) -> bool:
3336
if not super().complete():
37+
logger.info(
38+
f'UpdatedCachedReferenceDatasetQuery: {self.output().path} does not exist',
39+
)
3440
return False
3541

3642
datasets_to_check = [self.crdq.dataset(self.dataset_type)]

0 commit comments

Comments
 (0)