Skip to content

Commit 5580bfc

Browse files
committed
do not drop columns
1 parent 2770d0a commit 5580bfc

File tree

2 files changed

+29
-9
lines changed

2 files changed

+29
-9
lines changed

v03_pipeline/lib/methods/sample_qc.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import hail as hl
22
from gnomad.sample_qc.pipeline import filter_rows_for_qc
33

4-
from v03_pipeline.lib.misc.terra_data_repository import BIGQUERY_METRICS
54
from v03_pipeline.lib.model import SampleType
65

76
GNOMAD_FILTER_MIN_AF = 0.001
@@ -64,7 +63,4 @@ def annotate_filter_flags(
6463
filter_flags=hl.array(
6564
[hl.or_missing(filter_cond, name) for name, filter_cond in flags.items()],
6665
).filter(hl.is_defined),
67-
).drop(
68-
*BIGQUERY_METRICS[2:5],
69-
'filtered_callrate',
7066
)

v03_pipeline/lib/tasks/write_sample_qc_json_test.py

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,17 +47,41 @@ def test_call_sample_qc(
4747

4848
self.assertCountEqual(
4949
res['HG00731'],
50-
{'filter_flags': ['contamination', 'coverage']},
50+
{
51+
'filtered_callrate': 1.0,
52+
'contamination_rate': 5.099999904632568,
53+
'percent_bases_at_20x': 93.69000244140625,
54+
'mean_coverage': 29.309999465942383,
55+
'filter_flags': ['contamination', 'coverage'],
56+
},
5157
)
5258
self.assertCountEqual(
5359
res['HG00732'],
54-
{'filter_flags': ['coverage']},
60+
{
61+
'filtered_callrate': 1.0,
62+
'contamination_rate': 5.0,
63+
'percent_bases_at_20x': 90.0,
64+
'mean_coverage': 28.0,
65+
'filter_flags': ['coverage'],
66+
},
5567
)
5668
self.assertCountEqual(
5769
res['HG00733'],
58-
{'filter_flags': ['contamination']},
70+
{
71+
'filtered_callrate': 1.0,
72+
'contamination_rate': 6.0,
73+
'percent_bases_at_20x': 85.0,
74+
'mean_coverage': 36.400001525878906,
75+
'filter_flags': ['contamination'],
76+
},
5977
)
6078
self.assertCountEqual(
61-
res['HG00732'],
62-
{'filter_flags': []},
79+
res['NA19675'],
80+
{
81+
'filtered_callrate': 1.0,
82+
'contamination_rate': 0.0,
83+
'percent_bases_at_20x': 80.0,
84+
'mean_coverage': 30.0,
85+
'filter_flags': [],
86+
},
6387
)

0 commit comments

Comments
 (0)